Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestTCPServer flaky on macOS 10.12 builders #32919

Closed
bcmills opened this issue Jul 3, 2019 · 12 comments
Closed

net: TestTCPServer flaky on macOS 10.12 builders #32919

bcmills opened this issue Jul 3, 2019 · 12 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jul 3, 2019

From https://build.golang.org/log/19f0ac1d66a927076b256862638641e261489304 on the darwin-amd64-race builder:

--- FAIL: TestTCPServer (10.01s)
    server_test.go:60: skipping tcp :0<-127.0.0.1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::]:0<-::1 test
    server_test.go:60: skipping tcp :0<-::1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-::1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-::1 test
    server_test.go:60: skipping tcp [::]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp :0<-127.0.0.1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-127.0.0.1 test
    server_test.go:60: skipping tcp [::]:0<-::1 test
    server_test.go:60: skipping tcp :0<-::1 test
    server_test.go:60: skipping tcp 0.0.0.0:0<-::1 test
    server_test.go:60: skipping tcp [::ffff:0.0.0.0]:0<-::1 test
    server_test.go:60: skipping tcp [::]:0<-127.0.0.1 test
    server_test.go:107: dial tcp [::1]:49737: i/o timeout
FAIL
FAIL	net	23.757s

CC @mikioh @ianlancetaylor
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 3, 2019
@bcmills bcmills added this to the Go1.14 milestone Jul 3, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Jul 3, 2019

Compare #32534.

@bcmills
Copy link
Contributor Author

bcmills commented Aug 13, 2019

Another darwin-amd64-race: https://build.golang.org/log/9b0ba4fa74c5011965aebec20f6794e1186837ce

@bcmills
Copy link
Contributor Author

bcmills commented Aug 29, 2019

darwin-amd64-race: https://build.golang.org/log/87a6a195e770baea9298ed4f3b87e640700a1477

@bcmills bcmills changed the title net: TestTCPServer flake on darwin-amd64-race net: TestTCPServer flaky on darwin-amd64-race Aug 29, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Aug 29, 2019

Seems like we have enough of these to form a pattern.

CC @mikioh @bradfitz @ianlancetaylor

@bcmills
Copy link
Contributor Author

bcmills commented Sep 3, 2019

darwin-amd64-10_12: https://build.golang.org/log/d33cf20b1cc2056d235cb49e5b504e1217eb8971

@bcmills bcmills changed the title net: TestTCPServer flaky on darwin-amd64-race net: TestTCPServer flaky on darwin-amd64 builders Sep 3, 2019
@bcmills bcmills mentioned this issue Sep 24, 2019
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Sep 27, 2019 •
edited

darwin-amd64-race: https://build.golang.org/log/b1b0acc773357589c52b772d1f5064b12e1f711a

This was referenced Oct 2, 2019
Closed
Open
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Oct 11, 2019

darwin-amd64-race: https://build.golang.org/log/17f5dc994f9cdbda9c3f6baf87e15a2c7c599e0d

@ianlancetaylor
Copy link
Contributor

It would be interesting to know whether this ever occurs on a version of Darwin later than 10.12.

@bcmills
Copy link
Contributor Author

bcmills commented Oct 11, 2019

Looks like it hasn't so far: darwin-amd64-race is still 10.12.

@bcmills
Copy link
Contributor Author

bcmills commented Oct 15, 2019

That suggests that this may be the same underlying issue as #22019.

@bcmills bcmills mentioned this issue Oct 15, 2019
Closed
@bcmills bcmills changed the title net: TestTCPServer flaky on darwin-amd64 builders net: TestTCPServer flaky on macOS 10.12 builders Oct 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/202618 mentions this issue: net: ignore or skip known-flaky localhost Dial operations on macOS 10.12 builder

@gopherbot
Copy link

Change https://golang.org/cl/202561 mentions this issue: net: convert TestTCPServer to use subtests

gopherbot pushed a commit that referenced this issue Oct 22, 2019
net: convert TestTCPServer to use subtests
22278ca 
My fix in CL 202618 inadvertently violated an invariant in the inner
loop of TestTCPServer (namely, that len(trchs) == i). That causes a
panic when one or more of the channels is omitted due to a flake.

Instead of trying to fix up the test, let's just factor out a subtest
and skip the whole thing if the transceiver's Dial flakes out.

Updates #32919

Change-Id: Ib6f274a44194311c8c5a2faf19f586cc9eccfd4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/202561
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rsc @ianlancetaylor @bcmills @gopherbot