You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
msoedov
changed the title
x/net/websocket missing doc example for origin check function
x/net/websocket: missing doc example for origin check function
Jul 1, 2019
bcmills
changed the title
x/net/websocket: missing doc example for origin check function
x/net/websocket: add runnable versions of examples mentioned in (*Server).Handshake documentation
Jul 1, 2019
bcmills
changed the title
x/net/websocket: add runnable versions of examples mentioned in (*Server).Handshake documentation
x/net/websocket: add runnable versions of examples mentioned in Server.Handshake documentation
Jul 1, 2019
// Handshake is an optional function in WebSocket handshake.// For example, you can check, or don't check Origin header.// Another example, you can select config.Protocol.
Since both of those examples are mentioned explicitly, they should probably be illustrated more complete in runnable (and testable!) examples.
https://godoc.org/golang.org/x/net/websocket there is missing example for redefining your own check origin callback or even disabling the existing one
The text was updated successfully, but these errors were encountered: