x/tools/gopls: server stucks with a lot of meaningless messages of errors #32857

inliquid · 2019-06-29T20:43:29Z

VS Code.
Actually this happens all the time, if you work more than 30 min with some editing. It just stops working normally forcing to restart VS Code. And in fact there are no errors in files. See screenshot and logs for more information.

[Error - 23:30:16] unable to check package for file:///c:/***/***/***/git:/c:/***/***/***/pkg/config/defaults.go%3F%7B%22path%22:%22c:/***/***/***/pkg/config/defaults.go%22,%22ref%22:%22~%22%7D: go/packages.Load: no packages found for c:\***\***\***\git:\c:\***\***\***\pkg\config\defaults.go?{"path":"c:\***\***\***\pkg\config\defaults.go","ref":"~"}
[Error - 23:30:53] unable to check package for file:///c:/***/***/***/git:/c:/***/***/***/init.go%3F%7B%22path%22:%22c:/***/***/***/init.go%22,%22ref%22:%22~%22%7D: go/packages.Load: no packages found for c:\***\***\***\git:\c:\***\***\***\init.go?{"path":"c:\***\***\***\init.go","ref":"~"}

The text was updated successfully, but these errors were encountered:

stamblerre · 2019-07-01T18:26:39Z

@inliquid: Can you confirm that this happens with the latest version of gopls? You can update by running go get -u golang.org/x/tools/gopls@master.

inliquid · 2019-07-01T19:14:44Z

I'm updating gopls from master regularly. Gonna update now and see if this happens again. It also may be somehow related to vscode-go extension itself, because recently I seen quite similar messages from linter output.

inliquid · 2019-07-01T19:17:27Z

@stamblerre I think -u is not needed when you are querying @master with modules. As I understand -u in this command will force to update dependencies of gopls module.

stamblerre · 2019-07-01T19:26:33Z

Hm, well LSP is marked as the source of the diagnostic, so I expect it is probably gopls in this case. Please let me know if you still see this issue on master.

And yes, -u updates the dependencies, but I typically recommend it when updating to master because some of the fixes are in go/packages, which is in the x/tools repo, and as a result, a dependency of gopls.

inliquid · 2019-07-01T21:28:57Z

Yep, still getting these errors;

stamblerre · 2019-07-01T23:25:45Z

Are you able to share the full gopls for this case?

inliquid · 2019-07-02T00:05:28Z

Sorry, what do you mean?

stamblerre · 2019-07-02T00:07:33Z

Oh, I'm sorry, typo - meant to say - can you share the full gopls log?

inliquid · 2019-07-02T00:20:27Z

Ah, ok when I next time see this error I'll share more logs.

DrGo · 2019-07-28T13:47:39Z

Logs from few occasions where similar behaviour happened. Thanks

➜  ~ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/salah/Library/Caches/go-build"
GOENV="/Users/salah/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/salah/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kz/fc7nstbx16q2gvb1w6rry8cm0000gn/T/go-build012474209=/tmp/go-build -gno-record-gcc-switches -fno-common"
➜  ~ go version
go version go1.13beta1 darwin/amd64
➜  ~ gopls version
version v0.1.0-cmd.gopls, built in $GOPATH mode
➜  ~

gopls3.log
gopls2.log
gopls.log

stamblerre · 2019-07-29T02:00:38Z

@DrGo: It looks like you are using an old version of gopls - can you please update by running go get golang.org/x/tools/gopls@latest?

DrGo · 2019-07-29T14:17:24Z

Thanks Rebecca,
I updated to golang.org/x/tools/gopls v0.1.2

While using it briefly this morning, I am getting a different error that I do not understand

[Error - 9:08:03 AM] unable to check package for file:///Users/salah/local/git/core/options.go: go/packages.Load: no packages found for /Users/salah/local/git/core/options.go
[Error - 9:08:03 AM] Request textDocument/documentLink failed.
  Message: no AST for file:///Users/salah/local/git/core/options.go
  Code: 0

I do not see anything different about this file. gopls does not complain about other files in the same package.

Also, do you know why I am getting this error when opening a mod file

[Error - 9:12:09 AM] Request textDocument/codeAction failed.
  Message: not a Go file file:///Users/salah/local/git/core/go.mod
  Code: 0

Many thanks,

stamblerre · 2019-08-05T23:24:53Z

@DrGo: For your first error, can you please share additional information as described here? In particular, what is the output of gopls -rpc.trace -v check /Users/salah/local/git/core/options.go?

Regarding the error with the go.mod file, we do not support any codeActions on go.mod files, which is why we log that error (though we probably shouldn't). I expect you would only see this error message in the logs, not in the "Problems" pane - correct?

DrGo · 2019-08-10T17:54:40Z

correct.

2019/08/10 12:51:38 Info:Build info

golang.org/x/tools/gopls v0.1.2
golang.org/x/tools/gopls@v0.1.3 h1:CB5ECiPysqZrwxcyRjN+exyZpY0gODTZvNiqQi3lpeo=
golang.org/x/sync@v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=
golang.org/x/tools@v0.0.0-20190710153321-831012c29e42 h1:4IOeC7p+OItq3+O5BWkcmVu2uBe3jekXau5S4QZX9DU=

Go info

go version go1.13beta1 darwin/amd64

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/salah/Library/Caches/go-build"
GOENV="/Users/salah/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/salah/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/salah/local/git/carpenter/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kz/fc7nstbx16q2gvb1w6rry8cm0000gn/T/go-build098138432=/tmp/go-build -gno-record-gcc-switches -fno-common"

stamblerre · 2019-08-12T15:23:26Z

Ok, in that case, I don't think that this should be a problem that necessarily needs fixing, though I did actually remove this logging in https://golang.org/cl/189039. Logged messages are just for troubleshooting, only the errors in the Problems pane should affect the user.

inliquid · 2019-08-12T19:03:10Z

Problem is not "errors" and "logging". problem is that at the same time gopls stopped doing anything.

stamblerre · 2019-08-12T19:11:49Z

@inliquid: I was replying to @DrGo's issue here. It seems to have been a different issue from the one you had experienced. Please share your gopls logs or the output of gopls -rpc.trace -v check /path/to/file.go, and I would be happy to help diagnose this issue.

DrGo · 2019-08-16T17:48:59Z

@stamblerre gopls freezes in my case too forcing multiple restarts. However, I have disabled gopls so I do not know if the issue was fixed more recently.

stamblerre · 2019-08-16T17:53:41Z

@DrGo: If you choose to re-enable gopls and encounter problems, please open a new issue. Thanks!

stamblerre · 2019-10-22T04:25:13Z

A lot has changed in gopls since this issue was filed, so I will close it. If you encounter new problems with gopls, please file a new issue. Thanks!

gopherbot added this to the Unreleased milestone Jun 29, 2019

gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 29, 2019

stamblerre changed the title ~~x/tools/cmd/gopls: server stucks with a lot of meaningless messages of errors~~ x/tools/gopls: server stucks with a lot of meaningless messages of errors Jul 2, 2019

stamblerre added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 5, 2019

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019

stamblerre closed this as completed Oct 22, 2019

golang locked and limited conversation to collaborators Oct 21, 2020

gopherbot added the FrozenDueToAge label Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: server stucks with a lot of meaningless messages of errors #32857

x/tools/gopls: server stucks with a lot of meaningless messages of errors #32857

inliquid commented Jun 29, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 1, 2019

inliquid commented Jul 1, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 1, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 2, 2019

stamblerre commented Jul 2, 2019

inliquid commented Jul 2, 2019

DrGo commented Jul 28, 2019

stamblerre commented Jul 29, 2019

DrGo commented Jul 29, 2019

stamblerre commented Aug 5, 2019

DrGo commented Aug 10, 2019

stamblerre commented Aug 12, 2019

inliquid commented Aug 12, 2019

stamblerre commented Aug 12, 2019

DrGo commented Aug 16, 2019

stamblerre commented Aug 16, 2019

stamblerre commented Oct 22, 2019

x/tools/gopls: server stucks with a lot of meaningless messages of errors #32857

x/tools/gopls: server stucks with a lot of meaningless messages of errors #32857

Comments

inliquid commented Jun 29, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 1, 2019

inliquid commented Jul 1, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 1, 2019

stamblerre commented Jul 1, 2019

inliquid commented Jul 2, 2019

stamblerre commented Jul 2, 2019

inliquid commented Jul 2, 2019

DrGo commented Jul 28, 2019

stamblerre commented Jul 29, 2019

DrGo commented Jul 29, 2019

stamblerre commented Aug 5, 2019

DrGo commented Aug 10, 2019

2019/08/10 12:51:38 Info:Build info

Go info

stamblerre commented Aug 12, 2019

inliquid commented Aug 12, 2019

stamblerre commented Aug 12, 2019

DrGo commented Aug 16, 2019

stamblerre commented Aug 16, 2019

stamblerre commented Oct 22, 2019