Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: frequent "expected full AST […], returned trimmed" failures in builders #32832

Closed
bcmills opened this issue Jun 28, 2019 · 3 comments
Closed

x/tools/gopls: frequent "expected full AST […], returned trimmed" failures in builders #32832

bcmills opened this issue Jun 28, 2019 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 28, 2019 •
edited

I've been looking through flakes on the build dashboard, and noticed a pattern in the x/tools/internal/lsp tests. They seem to fail frequently with error messages of the form expected full AST for file:///tmp/workdir/tmp/[…].go, returned trimmed.

Examples:
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/bd47b4f273b8fba6536cbb47257a2340c0575bad
https://build.golang.org/log/035d6f57a677b538aa7bcbab8e4d959d225896b3
https://build.golang.org/log/2d45e4b10c7e990d922b9606b99db59c4d10635c
https://build.golang.org/log/008b9f9c6839ab16253155c23b5f22f5df9a2222

CC @stamblerre @ianthehat
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 28, 2019
@bcmills bcmills added this to the Unreleased milestone Jun 28, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 28, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Jun 28, 2019

It's not clear to me whether this one is related or not: a no AST for rather than expected full AST.
https://build.golang.org/log/13d5da81654a025a3bf86d38b616d7936a0788f2

@bcmills bcmills mentioned this issue Jun 28, 2019
Open
@stamblerre
Copy link
Contributor

There are some race conditions in gopls but we are working on a significant rewrite, so hopefully those flakes will go away once those are in.

@stamblerre stamblerre changed the title x/tools/internal/lsp: frequent "expected full AST […], returned trimmed" failures in builders x/tools/gopls: frequent "expected full AST […], returned trimmed" failures in builders Jul 2, 2019
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 2, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@stamblerre
Copy link
Contributor

This issue is fairly old and we have resolved the races between full/trimmed ASTs, so I think this can be closed now.

@golang golang locked and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @stamblerre @gopherbot