Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update release notes for library support for new literals #32815

Closed
rsc opened this issue Jun 27, 2019 · 9 comments
Closed

doc: update release notes for library support for new literals #32815

rsc opened this issue Jun 27, 2019 · 9 comments
Labels
Documentation FrozenDueToAge release-blocker
Milestone
Go1.13

Comments

@rsc
Copy link
Contributor

rsc commented Jun 27, 2019

The release notes don't mention all the library changes related to the new number literals.
In particular there is new printing in fmt, new parsing in strconv, math/big, and text/scanner.

I started to update the notes but there's a lot to add. Filing so I don't forget.
@rsc rsc added this to the Go1.13 milestone Jun 27, 2019
@rsc rsc self-assigned this Jun 27, 2019
@griesemer griesemer self-assigned this Jul 10, 2019
@odeke-em
Copy link
Member

odeke-em commented Aug 21, 2019 •
edited

For the checklist, as we update release notes for this issue we can update accordingly here

  • textscanner -- completed by CL 183357
  • strconv -- completed by CL 191077
  • math/big -- completed by CL 191077
  • fmt -- completed by CL191578

@gopherbot
Copy link

Change https://golang.org/cl/191077 mentions this issue: doc/go1.13: document _ between digits for math/big

gopherbot pushed a commit that referenced this issue Aug 21, 2019
@odeke-em @griesemer
doc/go1.13: document _ between digits for math/big, strconv
e764432 
Document that:
* math/big.Float.Parse
* math/big.Int.SetString
* strconv.ParseFloat
* strconv.ParseInt
* strconv.ParseUint
now accept underscores to group digits only if base = 0,
as per the Go 2 language changes.

Updates #32815

Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c
Reviewed-on: https://go-review.googlesource.com/c/go/+/191077
Reviewed-by: Robert Griesemer <gri@golang.org>
@odeke-em
Copy link
Member

Alright, all the packages on our checklist have been completed. With that I shall close this issue.

@odeke-em
Copy link
Member

I'll reopen this until we have fully verified that fmt's release notes also document the updates; perhaps tonight when I get time.

@odeke-em odeke-em reopened this Aug 22, 2019
@gopherbot
Copy link

Change https://golang.org/cl/191477 mentions this issue: [release-branch.go1.13] doc/go1.13: document _ between digits for math/big, strconv

@gopherbot
Copy link

Change https://golang.org/cl/191578 mentions this issue: doc/go1.13: document fmt's number syntax updates

gopherbot pushed a commit that referenced this issue Aug 23, 2019
@odeke-em @andybons
[release-branch.go1.13] doc/go1.13: document _ between digits for mat…
a5a92aa 
…h/big, strconv

Document that:
* math/big.Float.Parse
* math/big.Int.SetString
* strconv.ParseFloat
* strconv.ParseInt
* strconv.ParseUint
now accept underscores to group digits only if base = 0,
as per the Go 2 language changes.

Updates #32815

Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c
Reviewed-on: https://go-review.googlesource.com/c/go/+/191077
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit e764432)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191477
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@odeke-em
Copy link
Member

And can now confirm that this issue is completely done.

@odeke-em
Copy link
Member

@andybons could you please help me cherry pick https://go-review.googlesource.com/c/go/+/191578 as my two emails aren't associated to my +2's hence I can't do it. Thank you.

@gopherbot
Copy link

Change https://golang.org/cl/191738 mentions this issue: [release-branch.go1.13] doc/go1.13: document fmt's number syntax updates

gopherbot pushed a commit that referenced this issue Aug 25, 2019
@odeke-em @andybons
[release-branch.go1.13] doc/go1.13: document fmt's number syntax updates
55a5beb 
Fixes #32815

Change-Id: Ia8ac9943a920a056ba7dbc69c1c70fa188f7aca8
Reviewed-on: https://go-review.googlesource.com/c/go/+/191578
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit 9e1c864)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191738
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@odeke-em @t4n6a1ka
doc/go1.13: document _ between digits for math/big, strconv
25bfd09 
Document that:
* math/big.Float.Parse
* math/big.Int.SetString
* strconv.ParseFloat
* strconv.ParseInt
* strconv.ParseUint
now accept underscores to group digits only if base = 0,
as per the Go 2 language changes.

Updates golang#32815

Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c
Reviewed-on: https://go-review.googlesource.com/c/go/+/191077
Reviewed-by: Robert Griesemer <gri@golang.org>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@odeke-em @t4n6a1ka
doc/go1.13: document fmt's number syntax updates
8cb5ef7 
Fixes golang#32815

Change-Id: Ia8ac9943a920a056ba7dbc69c1c70fa188f7aca8
Reviewed-on: https://go-review.googlesource.com/c/go/+/191578
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Aug 23, 2020
@rsc rsc unassigned rsc and griesemer Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
4 participants
@rsc @odeke-em @griesemer @gopherbot