-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update release notes for library support for new literals #32815
Comments
Change https://golang.org/cl/191077 mentions this issue: |
Document that: * math/big.Float.Parse * math/big.Int.SetString * strconv.ParseFloat * strconv.ParseInt * strconv.ParseUint now accept underscores to group digits only if base = 0, as per the Go 2 language changes. Updates #32815 Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c Reviewed-on: https://go-review.googlesource.com/c/go/+/191077 Reviewed-by: Robert Griesemer <gri@golang.org>
Alright, all the packages on our checklist have been completed. With that I shall close this issue. |
I'll reopen this until we have fully verified that fmt's release notes also document the updates; perhaps tonight when I get time. |
Change https://golang.org/cl/191477 mentions this issue: |
Change https://golang.org/cl/191578 mentions this issue: |
…h/big, strconv Document that: * math/big.Float.Parse * math/big.Int.SetString * strconv.ParseFloat * strconv.ParseInt * strconv.ParseUint now accept underscores to group digits only if base = 0, as per the Go 2 language changes. Updates #32815 Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c Reviewed-on: https://go-review.googlesource.com/c/go/+/191077 Reviewed-by: Robert Griesemer <gri@golang.org> (cherry picked from commit e764432) Reviewed-on: https://go-review.googlesource.com/c/go/+/191477 Run-TryBot: Andrew Bonventre <andybons@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
And can now confirm that this issue is completely done. |
@andybons could you please help me cherry pick https://go-review.googlesource.com/c/go/+/191578 as my two emails aren't associated to my +2's hence I can't do it. Thank you. |
Change https://golang.org/cl/191738 mentions this issue: |
Fixes #32815 Change-Id: Ia8ac9943a920a056ba7dbc69c1c70fa188f7aca8 Reviewed-on: https://go-review.googlesource.com/c/go/+/191578 Reviewed-by: Robert Griesemer <gri@golang.org> (cherry picked from commit 9e1c864) Reviewed-on: https://go-review.googlesource.com/c/go/+/191738 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Document that: * math/big.Float.Parse * math/big.Int.SetString * strconv.ParseFloat * strconv.ParseInt * strconv.ParseUint now accept underscores to group digits only if base = 0, as per the Go 2 language changes. Updates golang#32815 Change-Id: Id45bd803a18442436419739297e8aed0d32ca56c Reviewed-on: https://go-review.googlesource.com/c/go/+/191077 Reviewed-by: Robert Griesemer <gri@golang.org>
Fixes golang#32815 Change-Id: Ia8ac9943a920a056ba7dbc69c1c70fa188f7aca8 Reviewed-on: https://go-review.googlesource.com/c/go/+/191578 Reviewed-by: Robert Griesemer <gri@golang.org>
The release notes don't mention all the library changes related to the new number literals.
In particular there is new printing in fmt, new parsing in strconv, math/big, and text/scanner.
I started to update the notes but there's a lot to add. Filing so I don't forget.
The text was updated successfully, but these errors were encountered: