x/tools/go/packages: "no metadata for" error when mode contains LoadTypes without LoadImports #32814

jayconrod · 2019-06-27T20:17:26Z

What version of Go are you using (`go version`)?

go version devel +0d4de70c1c2 Thu Jun 27 17:26:05 2019 +0000 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org"
GOROOT="/Users/jayconrod/Code/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/jayconrod/Code/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build811718838=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I want to load type information for a set of packages. I tried to use this mode:

packages.NeedName | packages.NeedTypes | packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedTypesSizes,

This doesn't include NeedImports or NeedDeps. I know that go/packages needs to load transitive imports (or their export data) to get type information, but I don't care if the Imports field is populated in the returned packages.

This can be reproduced with the program below using golang.org/x/tools v0.0.0-20190627185803-429858501117:

package main

import (
	"log"

	"golang.org/x/tools/go/packages"
)

func main() {
	cfg := &packages.Config{
		Mode: packages.NeedName | packages.NeedTypes | packages.NeedSyntax | packages.NeedTypesInfo | packages.NeedTypesSizes,
	}
	pkgs, err := packages.Load(cfg, "fmt")
	if err != nil {
		log.Fatal(err)
	}
	for _, pkg := range pkgs {
		for _, e := range pkg.Errors {
			log.Fatal(e)
		}
	}
}

What did you expect to see?

I get a strange error message like:

/Users/jayconrod/Code/go/src/fmt/errors.go:7:8: could not import errors (no metadata for errors)

The message changes from run to run (I think it can be any imported package).

What did you see instead?

Type information loaded successfully. Imports field nil in returned packages.

The text was updated successfully, but these errors were encountered:

jayconrod · 2019-06-27T20:18:33Z

cc @matloob

gopherbot · 2019-06-28T16:41:48Z

Change https://golang.org/cl/184165 mentions this issue: go/packages: make sure to request dependencies when we NeedTypesInfo

matloob · 2019-06-28T16:42:09Z

I've got a fix in progress. It doesn't quite work completely yet.

jpap · 2019-08-26T19:32:44Z

I'm hitting this for packages that use Cgo (could not import C (no metadata for C)), where there was a compile-error in the C preamble. I wonder if a better error message could be had here? :)

Might also be related to this golangci issue.

Before separating Load* into Need* we could use LoadSyntax to get types information by loading inital packages from source code and loading it's direct dependencies from export data. It was broken when separation was introduced and before this commit everything was loading from source code what resulted into slow loading times. This commit fixes it. Also, do backwards-incompatible fix of definition of deprecated LoadImports and LoadAllSyntax. Improve an internal error message "internal error: nil Pkg importing x from y": replace it with "internal error: package x without types was imported from y". Remove packages.NeedDeps request for loading in tests TestLoadTypesBits and TestContainsOverlayXTest. Fixes golang/go#31752, fixes golang/go#33077, fixes golang/go#32814, fixes golang/go#31699, golang/go#31930

Before separating Load* into Need* we could use LoadSyntax to get types information by loading inital packages from source code and loading it's direct dependencies from export data. It was broken when separation was introduced and before this commit everything was loading from source code what resulted into slow loading times. This commit fixes it. Also, do backwards-incompatible fix of definition of deprecated LoadImports and LoadAllSyntax. Improve an internal error message "internal error: nil Pkg importing x from y": replace it with "internal error: package x without types was imported from y". Remove packages.NeedDeps request for loading in tests TestLoadTypesBits and TestContainsOverlayXTest. Fixes golang/go#31752, fixes golang/go#33077, fixes golang/go#32814, fixes golang/go#31699, fixes golang/go#31930

gopherbot · 2019-09-09T10:42:45Z

Change https://golang.org/cl/186337 mentions this issue: go/packages: allow types loading without NeedDeps

Before separating Load* into Need* we could use LoadSyntax to get types information by loading inital packages from source code and loading it's direct dependencies from export data. It was broken when separation was introduced and before this commit everything was loading from source code what resulted into slow loading times. This commit fixes it. Also, do backwards-incompatible fix of definition of deprecated LoadImports and LoadAllSyntax. Improve an internal error message "internal error: nil Pkg importing x from y": replace it with "internal error: package x without types was imported from y". Remove packages.NeedDeps request for loading in tests TestLoadTypesBits and TestContainsOverlayXTest. Fixes golang/go#31752, fixes golang/go#33077, fixes golang/go#32814, fixes golang/go#31699, fixes golang/go#31930

Before separating Load* into Need* we could use LoadSyntax to get types information by loading inital packages from source code and loading it's direct dependencies from export data. It was broken when separation was introduced and before this commit everything was loading from source code what resulted into slow loading times. This commit fixes it. Also, do backwards-incompatible fix of definition of deprecated LoadImports and LoadAllSyntax. Improve an internal error message "internal error: nil Pkg importing x from y": replace it with "internal error: package x without types was imported from y". Remove packages.NeedDeps request for loading in tests TestLoadTypesBits and TestContainsOverlayXTest. Fixes golang/go#31752, fixes golang/go#33077, fixes golang/go#32814, fixes golang/go#31699, fixes golang/go#31930 Change-Id: I416e3c1035d555d67039e45a4fdd1deb9b2184ef GitHub-Last-Rev: 2e3a46e GitHub-Pull-Request: #139 Reviewed-on: https://go-review.googlesource.com/c/tools/+/186337 Reviewed-by: Michael Matloob <matloob@golang.org>

Before separating Load* into Need* we could use LoadSyntax to get types information by loading inital packages from source code and loading it's direct dependencies from export data. It was broken when separation was introduced and before this commit everything was loading from source code what resulted into slow loading times. This commit fixes it. Also, do backwards-incompatible fix of definition of deprecated LoadImports and LoadAllSyntax. Improve an internal error message "internal error: nil Pkg importing x from y": replace it with "internal error: package x without types was imported from y". Remove packages.NeedDeps request for loading in tests TestLoadTypesBits and TestContainsOverlayXTest. Fixes golang/go#31752, fixes golang/go#33077, fixes golang/go#32814, fixes golang/go#31699, fixes golang/go#31930 Change-Id: I416e3c1035d555d67039e45a4fdd1deb9b2184ef GitHub-Last-Rev: 2e3a46e GitHub-Pull-Request: golang#139 Reviewed-on: https://go-review.googlesource.com/c/tools/+/186337 Reviewed-by: Michael Matloob <matloob@golang.org>

gopherbot added this to the Unreleased milestone Jun 27, 2019

jayconrod added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 27, 2019

ianthehat assigned matloob Jun 28, 2019

jirfag mentioned this issue Jul 16, 2019

go/packages: allow types loading without NeedDeps golang/tools#139

Closed

gopherbot closed this as completed in golang/tools@56125e7 Aug 30, 2019

golang locked and limited conversation to collaborators Sep 8, 2020

gopherbot added the FrozenDueToAge label Sep 8, 2020

rsc unassigned matloob Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/go/packages: "no metadata for" error when mode contains LoadTypes without LoadImports #32814

x/tools/go/packages: "no metadata for" error when mode contains LoadTypes without LoadImports #32814

jayconrod commented Jun 27, 2019

jayconrod commented Jun 27, 2019

gopherbot commented Jun 28, 2019

matloob commented Jun 28, 2019

jpap commented Aug 26, 2019 •

edited

gopherbot commented Sep 9, 2019

x/tools/go/packages: "no metadata for" error when mode contains LoadTypes without LoadImports #32814

x/tools/go/packages: "no metadata for" error when mode contains LoadTypes without LoadImports #32814

Comments

jayconrod commented Jun 27, 2019

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

jayconrod commented Jun 27, 2019

gopherbot commented Jun 28, 2019

matloob commented Jun 28, 2019

jpap commented Aug 26, 2019 • edited

gopherbot commented Sep 9, 2019

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

jpap commented Aug 26, 2019 •

edited