Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/digraph: allpaths non-deterministically misses cycles #32796

Closed
rsc opened this issue Jun 26, 2019 · 1 comment
Closed

x/tools/cmd/digraph: allpaths non-deterministically misses cycles #32796

rsc opened this issue Jun 26, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Jun 26, 2019

$ cat x
A B
A C
A D
C E
D B
D F
E B
E F
F E
$ for i in $(seq 20); do echo $(digraph allpaths A B < x); done
A B C D E
A B C D E
A B C D E
A B C D E
A B C D E F
A B C D E F
A B C D E F
A B C D E F
A B C D E F
A B C D E
A B C D E
A B C D E F
A B C D E
A B C D E
A B C D E
A B C D E
A B C D E
A B C D E
A B C D E F
A B C D E
$ 

There is a path A -> C -> E -> F -> B (among others), so F should be included 100% of the time.

@rsc rsc added this to the Unreleased milestone Jun 26, 2019
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 26, 2019
@alandonovan
Copy link
Contributor

Fixed by https://go-review.googlesource.com/c/tools/+/184337, I think.
@jadekler

@golang golang locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants