Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: add a race test #32783

Closed
griesemer opened this issue Jun 26, 2019 · 4 comments
Closed

go/types: add a race test #32783

griesemer opened this issue Jun 26, 2019 · 4 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@griesemer
Copy link
Contributor

Reminder issue: go/types can be invoked concurrently and while the design is such that this should be ok (we know it's working), it would be good to have a test for it.

See also #32154 for a most recent failure due to a race condition.

(A test can be added to (*tester).raceTest in cmd/dist/test.go.)
@griesemer griesemer added this to the Unplanned milestone Jun 26, 2019
@griesemer griesemer self-assigned this Jun 26, 2019
@dmitshur
Copy link
Contributor

#36605 (comment) is relevant. /cc @matloob

@dmitshur
Copy link
Contributor

dmitshur commented Feb 7, 2020

/cc @findleyr @stamblerre @heschik

@bcmills
Copy link
Contributor

bcmills commented Mar 5, 2020

This may be relevant to #37602 and #37690.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 5, 2020
@bcmills bcmills mentioned this issue Mar 19, 2020
Closed
@findleyr
Copy link
Contributor

This was done in #47729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @griesemer @findleyr