Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: generates code with inappropriate array copy [1.12 backport] #32756

Closed
gopherbot opened this issue Jun 24, 2019 · 2 comments
Closed

cmd/cgo: generates code with inappropriate array copy [1.12 backport] #32756

gopherbot opened this issue Jun 24, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.7

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #32579 to be considered for backport to the next 1.12 minor release.

@gopherbot please open backport to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 24, 2019
@gopherbot gopherbot mentioned this issue Jun 24, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.7 milestone Jun 24, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/183627 mentions this issue: [release-branch.go1.12] cmd/cgo: fix inappropriate array copy

@gopherbot
Copy link
Author

Closed by merging 77c14d2 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Jun 26, 2019
@ianlancetaylor
[release-branch.go1.12] cmd/cgo: fix inappropriate array copy
77c14d2 
Ensure that during rewriting of expressions that take the address of
an array, that we properly recognize *ast.IndexExpr as an operation
to create a pointer variable and thus assign the proper addressOf
and deference operators as "&" and "*" respectively.

This fixes a regression from CL 142884.

This is a backport of CLs 183458 and 183778 to the 1.12 release branch.
It is not a cherry pick because the code in misc/cgo/test has changed.

Updates #32579
Fixes #32756

Change-Id: I0daa75ec62cccbe82ab658cb2947f51423e0c235
Reviewed-on: https://go-review.googlesource.com/c/go/+/183627
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 1, 2019
@golang golang locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.7
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot