Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: support custom GOPROXY #32740

Closed
cep21 opened this issue Jun 23, 2019 · 3 comments
Closed

x/playground: support custom GOPROXY #32740

cep21 opened this issue Jun 23, 2019 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cep21
Copy link
Contributor

cep21 commented Jun 23, 2019

What version of Go are you using (go version)?

Playground depends upon docker build. I'm using the default build args.

$ github.com/golang/playground@master

What did you do?

Install the go playground inside my company VPN. I wrote a playground program that used internal only libraries.

What did you expect to see?

I expected my program to run.

What did you see instead?

The playground was unable to run my code.

The playground code hardcodes https://github.com/golang/playground/blob/a7b4d4c4bb72efd2ec20c9f30d5c1e6f09cee3d2/sandbox.go#L373 GOPROXY=https://proxy.golang.org.

I forked the playground code and replace GOPROXY=https://proxy.golang.org. with our company's internal athen's proxy GOPROXY=https://proxy.mycompany.intranet. . I was then able to use my company's internal software.

I would propose that the playground's Dockerfile https://github.com/golang/playground/blob/master/Dockerfile accept GOPROXY as an environment variable that configures where the playground uses the proxy

@gopherbot gopherbot added this to the Unreleased milestone Jun 23, 2019
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 25, 2019
@andybons
Copy link
Member

Seems fine with me. Mind submitting a patch that accepts an env var and defaults to https://proxy.golang.org if it’s not set?

@andybons andybons changed the title x/playground: Support custom GOPROXY x/playground: support custom GOPROXY Jun 25, 2019
@cep21
Copy link
Contributor Author

cep21 commented Jun 25, 2019

Sure thing!

@gopherbot
Copy link

Change https://golang.org/cl/184558 mentions this issue: playground: Allow explicit GOPROXY variable

@golang golang locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants