Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: ServerCapabilities.RenameProvider should be interface #32710

Closed
suzmue opened this issue Jun 20, 2019 · 3 comments
Closed

x/tools/gopls: ServerCapabilities.RenameProvider should be interface #32710

suzmue opened this issue Jun 20, 2019 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@suzmue
Copy link
Contributor

suzmue commented Jun 20, 2019

ServerCapabilities.RenameProvider needs to be interface in the generated struct.

The server may need to return either a boolean or RenameOptions to the client, since it may only send RenameOptions if the client specifies prepareSupport.

Re: Issue #32703
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 20, 2019
@suzmue suzmue changed the title internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface Jun 20, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2019
@suzmue
Copy link
Contributor Author

suzmue commented Jun 20, 2019

@pjweinb : Could we make this change in the protocol generator?

@pjweinb
Copy link

pjweinb commented Jun 21, 2019 via email

@stamblerre stamblerre changed the title x/tools/internal/lsp/protocol: ServerCapabilities.RenameProvider should be interface x/tools/gopls: ServerCapabilities.RenameProvider should be interface Jul 2, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@stamblerre
Copy link
Contributor

This is done as of CL 194177.

@golang golang locked and limited conversation to collaborators Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@pjweinb @stamblerre @suzmue @gopherbot