Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: TryBot fails for playground #32669

Closed
toothrot opened this issue Jun 18, 2019 · 3 comments
Closed

x/playground: TryBot fails for playground #32669

toothrot opened this issue Jun 18, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

What version of Go are you using (go version)?

 linux-amd64 (Go 1.12.x)
 linux-amd64 (Go 1.11.x)

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

(trybot linux-amd64 (Go 1.12.x) and linux-amd64 (Go 1.11.x))

What did you do?

Ran TryBot for a x/playground CR for #32606 : https://go-review.googlesource.com/c/playground/+/182180

What did you expect to see?

ok  	golang.org/x/playground	0.070s

What did you see instead?

linux-amd64 at 4ce6a8e89668b87dce67e2f55802903d6eb9110a building playground at 798aa1a16276f8ea745637da7b9fd4a8a3e06fec

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/playground/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn65a9b55" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=9.1s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.150:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/playground

main.go:13:2: cannot find package "cloud.google.com/go/compute/metadata" in any of:
	/workdir/go/src/cloud.google.com/go/compute/metadata (from $GOROOT)
	/workdir/gopath/src/cloud.google.com/go/compute/metadata (from $GOPATH)
edit.go:14:2: cannot find package "cloud.google.com/go/datastore" in any of:
	/workdir/go/src/cloud.google.com/go/datastore (from $GOROOT)
	/workdir/gopath/src/cloud.google.com/go/datastore (from $GOPATH)
cache.go:11:2: cannot find package "github.com/bradfitz/gomemcache/memcache" in any of:
	/workdir/go/src/github.com/bradfitz/gomemcache/memcache (from $GOROOT)
	/workdir/gopath/src/github.com/bradfitz/gomemcache/memcache (from $GOPATH)
fmt.go:14:2: cannot find package "github.com/rogpeppe/go-internal/modfile" in any of:
	/workdir/go/src/github.com/rogpeppe/go-internal/modfile (from $GOROOT)
	/workdir/gopath/src/github.com/rogpeppe/go-internal/modfile (from $GOPATH)
txtar.go:14:2: cannot find package "github.com/rogpeppe/go-internal/txtar" in any of:
	/workdir/go/src/github.com/rogpeppe/go-internal/txtar (from $GOROOT)
	/workdir/gopath/src/github.com/rogpeppe/go-internal/txtar (from $GOPATH)


Error: tests failed: exit status 1

According to the helpful feedback from @dmitshur and @bradfitz, we should be able to force GO111MODULE=yes for x/playground, which should allow this build to succeed.

Related issues: #17312, #30233
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 18, 2019
@toothrot toothrot added this to the Unreleased milestone Jun 18, 2019
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) Testing An issue that has been verified to require only test changes, not just a test failure. labels Jun 18, 2019
@toothrot
Copy link
Contributor Author

Duplicate of #24823

@toothrot toothrot marked this as a duplicate of #24823 Jun 18, 2019
@dmitshur
Copy link
Contributor

I'm not sure that it's a duplicate. As I understand, that issue is more about adding playground post-submit builders (i.e., on https://build.golang.org) and testing building the playground image is successful.

Perhaps we can use this issue for the smaller task of just fixing existing trybots so they don't fail.

@toothrot
Copy link
Contributor Author

It would be nice if trybot worked at all, but part of the reason why I feel like it is a duplicate is that many of the important playground tests run as part of the Docker build. I am not sure if there is enough utility of just making the trybot pass without actually fully considering the Docker build case, as it would be a potential false-positive. The trybot could pass with the docker based integration tests failing.

@golang golang locked and limited conversation to collaborators Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot