New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: blocking queue behavior can cause deadlocks #32631

Closed

muirdm opened this issue Jun 14, 2019 · 1 comment

Labels

FrozenDueToAge gopls

Milestone

muirdm commented Jun 14, 2019

Now that the gopls jsonrpc queue blocks when full instead of rejecting messages, I've started to get deadlocks starting gopls in Emacs:

Emacs starts gopls
Emacs sends tons of requests/notifications for all open buffers
Somewhere in the middle of 2) gopls sends a configuration request to Emacs
Emacs sends the response, but the gopls's queue is full so go gopls doesn't read it
Deadlock (Emacs is waiting for responses to its requests, gopls is waiting for response to configuration request)

@ianthehat suggested we should either get rid of the configuration request altogether, or rejigger things so that it can be asynchronous.

gopherbot added this to the Unreleased milestone

gopherbot added the gopls label

gopherbot commented Jun 27, 2019

Change https://golang.org/cl/183718 mentions this issue: internal/jsonrpc2: change the concurrency strategy

gopherbot closed this as completed in


      golang/tools@4874f86

golang locked and limited conversation to collaborators

gopherbot added the FrozenDueToAge label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.