Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: fails 'go test' vet check at head #32626

Closed
bcmills opened this issue Jun 14, 2019 · 1 comment
Closed

x/build/cmd/coordinator: fails 'go test' vet check at head #32626

bcmills opened this issue Jun 14, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2019

This causes x/build CLs to fail TryBots. (Why don't we have a builder for x/build?)

https://storage.googleapis.com/go-build-log/6a9b22ce/linux-amd64_3c1e5e69.log

# golang.org/x/build/cmd/coordinator
cmd/coordinator/status.go:204:23: Sprintf format %s reads arg #1, but call has 0 args
FAIL	golang.org/x/build/cmd/coordinator [build failed]

CC @dmitshur, since I think he's planning to make some changes in cmd/coordinator anyway.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 14, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 14, 2019
@dmitshur
Copy link
Contributor

This is already resolved via CL 182017. (Existing CLs may need to be rebased to pick up the change.)

(Why don't we have a builder for x/build?)

I thought we had an issue about it, but I couldn't find one. So I added it to #30640 instead.

Historically, x/build did not have even trybots, that was a relatively recent addition. It wasn't possible before because of third-party packages in x/build, but that's no longer a problem (in module mode, which x/build uses for its trybots).

@golang golang locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants