Skip to content

x/tools/cmd/godoc: ?m=all not showing t and T #32588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gertcuykens opened this issue Jun 12, 2019 · 7 comments
Closed

x/tools/cmd/godoc: ?m=all not showing t and T #32588

gertcuykens opened this issue Jun 12, 2019 · 7 comments

Comments

@gertcuykens
Copy link
Contributor

andrey mirtchovski https://groups.google.com/d/msg/golang-nuts/yurCBIjtVq8/ULFl7jwIBgAJ

collection is not an exported type:
https://github.com/couchbase/moss/blob/master/collection.go#L24

the ?m=all parameter should enable you to see those, but it's not
working for me https://godoc.org/github.com/couchbase/moss?m=all. Perhaps because "collection" and "Collection" are not considered by godoc to be two different things?

@gopherbot gopherbot added this to the Unreleased milestone Jun 12, 2019
@mirtchovski
Copy link
Contributor

mirtchovski commented Jun 12, 2019

i created the simplest package possible and am not seeing the problem locally with go 1.12.5:

package t

type T struct {
}

func (t *T) Do() {
}

type t struct {
}

func (t *t) Do() {
}

attached is a screencap from local godoc with ?m=all:

Screen Shot 2019-06-12 at 4 22 13 PM

@agnivade
Copy link
Contributor

It indeed shows up collection, but after all the exported types are shown. So you have to scroll down a bit. I think this is by design as people might not want to mix exported and unexported types. If you think this should be changed, please feel free to open a separate proposal. But there is no bug here.

@mirtchovski
Copy link
Contributor

mirtchovski commented Jun 13, 2019

Can you please post a screenshot, preferably capturing the URL at the top?

I'm failing to see ResetStackDirtyTop which is a method on (*collection) but not on (*Collection)

https://github.com/couchbase/moss/blob/master/collection.go#L287

@agnivade
Copy link
Contributor

godoc-collection

@agnivade
Copy link
Contributor

@dmitshur
Copy link
Contributor

dmitshur commented Jun 14, 2019

The ?m=all parameter is only supported by x/tools/cmd/godoc right now. The original issue linked to godoc.org, which is another website that does not support the ?m=all query parameter.

@mirtchovski
Copy link
Contributor

thank you. this clears up my confusion.

@golang golang locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants