Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: support ad-hoc packages #32587

Closed
stamblerre opened this issue Jun 12, 2019 · 3 comments
Closed

x/tools/go/packages: support ad-hoc packages #32587

stamblerre opened this issue Jun 12, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.14

Comments

@stamblerre
Copy link
Contributor

gopls users have been reporting a common issue - gopls fails outside of $GOPATH without a go.mod file. This is to be expected, because go/packages does not support the file= query on ad-hoc packages. Ideally, go list would support the file= query, eliminating the need for go/packages to implement this support. In the meantime, go/packages should add support for ad-hoc packages.

/cc @matloob
@stamblerre stamblerre mentioned this issue Jun 13, 2019
Closed
@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 13, 2019
@FiloSottile FiloSottile added this to the Go1.14 milestone Jun 13, 2019
@FiloSottile
Copy link
Contributor

@stamblerre Please apply NeedsInvestigation/NeedsFix and a milestone when opening issues. You are in a better position than the OSP team to triage :)

@stamblerre
Copy link
Contributor Author

Sorry, thank you for doing it. I usually try to, but forgot because, for once, it was not my issue to solve 😄

@gopherbot
Copy link

Change https://golang.org/cl/182465 mentions this issue: go/packages: add support for file= queries on ad-hoc packages

@dmitshur dmitshur changed the title go/packages: support ad-hoc packages x/tools/go/packages: support ad-hoc packages Jun 17, 2019
@golang golang locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@FiloSottile @stamblerre @gopherbot