Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gopls: use the internal goimports library #32585

Closed
stamblerre opened this issue Jun 12, 2019 · 1 comment
Closed

x/tools/cmd/gopls: use the internal goimports library #32585

stamblerre opened this issue Jun 12, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@stamblerre
Copy link
Contributor

From @heschik, regarding goimports speed: Switch from the public API in x/tools/imports to the private one in x/tools/internal/imports. That one lets you control the lifetime of the environment object, which contains all the caches.

/cc @suzmue

@gopherbot gopherbot added this to the Unreleased milestone Jun 12, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 12, 2019
@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/184198 mentions this issue: internal/lsp, internal/imports: use the internal goimports library

@golang golang locked and limited conversation to collaborators Jun 30, 2020
@rsc rsc unassigned suzmue Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants