Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialerControl flake on darwin-amd64-race #32534

Closed
bcmills opened this issue Jun 10, 2019 · 1 comment
Closed

net: TestDialerControl flake on darwin-amd64-race #32534

bcmills opened this issue Jun 10, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 10, 2019

https://build.golang.org/log/03a8960a27ab5e837fa3d57ae7b08f6ece4a4285:

--- FAIL: TestDialerControl (75.50s)
    --- FAIL: TestDialerControl/StreamDial (75.50s)
        dial_test.go:944: dial tcp6 [::1]:49570: connect: operation timed out
FAIL
FAIL	net	86.859s

Looks like the test was added about a year ago (in CL 72810). It's not obvious to me whether this is a recent regression or just a low-frequency flake.

CC @ianlancetaylor @mikioh

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 10, 2019
@bcmills bcmills added this to the Go1.13 milestone Jun 10, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Sep 8, 2020

No more failures in about a year. Possibly fixed (in the sense of no longer affected by a probable macOS kernel bug?) by #34920.

2019-08-30T17:07:53-9d480ed/darwin-amd64-race
2019-06-10T13:43:51-ec3ebf7/darwin-amd64-race

@bcmills bcmills closed this as completed Sep 8, 2020
@golang golang locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants