Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: should not consider backport requests inside backport issues #32533

Open
dmitshur opened this issue Jun 10, 2019 · 1 comment
Open

x/build/cmd/gopherbot: should not consider backport requests inside backport issues #32533

dmitshur opened this issue Jun 10, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 10, 2019 •
edited

A backport issue should never itself be backported, so gopherbot should reject requests to backport inside such issues.

See #32261 (comment) where it happened by accident and caused confusing backport-backport issues to be created.

Also happened in #34881 (comment).
@dmitshur dmitshur added help wanted Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jun 10, 2019
@dmitshur dmitshur added this to the Unreleased milestone Jun 10, 2019
@gopherbot
Copy link

Change https://golang.org/cl/185897 mentions this issue: x/build/cmd/gopherbot: do not consider nested backport requests

@dmitshur dmitshur mentioned this issue Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot