Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: test packages in nested modules (in multi-module repositories) #32528

Closed
dmitshur opened this issue Jun 10, 2019 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 10, 2019

Right now, the trybots and post-submit builders assume there's only one module in each subrepository, and run go test [-short] [-race] golang.org/x/subrepo/... inside the subrepo root directory:

https://github.com/golang/build/blob/a3d123a17ca979f921ade4800222d1b8586fff87/cmd/coordinator/coordinator.go#L2443-L2459

That means modules not at the root are not covered.

We have some subrepos that have nested modules (e.g., x/net/h2demo, x/build/maintner/cmd/maintserve), and we may have more in the future. They need to be tested.

/cc @bradfitz @bcmills @ianthehat

Somewhat related to #30233, because the golang.org/x/subrepo/... import path pattern matches different packages depending on whether operating in GOPATH mode or module mode.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 10, 2019
@dmitshur dmitshur added this to the Unreleased milestone Jun 10, 2019
@dmitshur
Copy link
Contributor Author

@bcmills Do you know how this was solved in the main go repository, which also has more than one module now? Is it all abstracted away in go tool dist test, or was there some logic added to builders?

@bcmills
Copy link
Contributor

bcmills commented Jun 10, 2019

go test golang.org/x/subrepo/...

That might not be quite as bad as it seems. If the root module has require directives for the nested modules, then the path wildcard will also cover them.

That said, we should probably have the builders look for go.mod files throughout each repo and run go test ./... (or, better still, go test golang.org/x/subrepo/path/to/module/... from outside the module) explicitly for each module.

@bcmills
Copy link
Contributor

bcmills commented Jun 10, 2019

The modules in the main repo are indeed abstracted away by go tool dist test.

@dmitshur
Copy link
Contributor Author

Here's how I expect this can be implemented.

runSubrepoTests would need to be modified to:

  1. Determine if the selected configuration (Go version + whether or not subrepo has go.mod file) results in building in module mode or GOPATH mode by default.
    • This can likely be done by running go env GOMOD and seeing if that's set to non-empty value, or something along those lines (but need to get this exactly right and confirm it works for all cases).
  2. Similarly to how findDeps finds deps in all packages in the subrepo, need to just walk the dir tree and find all the places with go.mod files, and save those in a list.
  3. For each dir where a go.mod file was found (in addition to the root), run go test [-short] [-race] {{.ModulePath}}/... like it's currently done once for the root.
  4. Test that everything works and deploy to prod.

@gopherbot
Copy link

Change https://golang.org/cl/194277 mentions this issue: cmd/coordinator: detect current build mode in subrepo tests

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 10, 2019
@gopherbot
Copy link

Change https://golang.org/cl/194559 mentions this issue: cmd/coordinator: find inner modules when testing repos

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 10, 2019
gopherbot pushed a commit to golang/build that referenced this issue Sep 11, 2019
It will be necessary to know whether the current environment
and configuration has resulted in module mode or GOPATH mode
being selected. Do this dynamically by invoking 'go env GOMOD',
since the outcome depends on the version of Go and its default
GO111MODULE behavior, as well as whether a go.mod file is added
to the subrepo, and what environment overrides were applied by
coordinator via the BuildConfig.ModulesEnv method.

This requires the repository being tested to be available on disk,
so move the step of fetching it to happen earlier.

For now, this change only detects and logs the build mode.
Future changes will use this information further.

Updates golang/go#34190
Updates golang/go#32528
Updates golang/go#30233

Change-Id: I641becaaae5b6cfad22961d8864a877241e61cd3
Reviewed-on: https://go-review.googlesource.com/c/build/+/194277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur
Copy link
Contributor Author

I've tested the coordinator change for this issue on x/build CL 191018 and x/tools CL 191018 by restarting their trybots just now, and watched the build logs very closely. It appears to be working as intended, I'm not seeing any issues.

It successfully detected the 5 modules in the x/build repo:

And the 2 modules in the x/tools repo, golang.org/x/tools and golang.org/x/tools/gopls, while intentionally ignoring other go.mod files in testdata directories:

image

Here are build logs for various builds of the successful trybot run for CL 191018:

linux-amd64 (Go tip)
  builder: linux-amd64
      rev: c3c53661ba8823ea7a051110aebbdea2650c25d0
 buildlet: http://10.240.0.104 GCE VM: buildlet-linux-stretch-rn57c1852
  started: 2019-09-17 13:22:37.767234486 +0000 UTC m=+964.685252265
   status: still running

Events:
  2019-09-17T13:22:37Z checking_for_snapshot 
  2019-09-17T13:22:38Z finish_checking_for_snapshot after 18.5ms
  2019-09-17T13:22:38Z get_buildlet 
  2019-09-17T13:22:38Z awaiting_gce_quota 
  2019-09-17T13:22:38Z finish_awaiting_gce_quota after 0s
  2019-09-17T13:22:38Z create_gce_buildlet buildlet-linux-stretch-rn57c1852
  2019-09-17T13:22:38Z create_gce_instance buildlet-linux-stretch-rn57c1852
  2019-09-17T13:22:47Z finish_create_gce_instance after 8.99s; buildlet-linux-stretch-rn57c1852
  2019-09-17T13:22:47Z wait_buildlet_start buildlet-linux-stretch-rn57c1852
  2019-09-17T13:22:47Z got_instance_info waiting_for_buildlet...
  2019-09-17T13:23:29Z finish_wait_buildlet_start after 42.5s; buildlet-linux-stretch-rn57c1852
  2019-09-17T13:23:29Z finish_create_gce_buildlet after 51.6s; buildlet-linux-stretch-rn57c1852
  2019-09-17T13:23:29Z finish_get_buildlet after 51.8s
  2019-09-17T13:23:29Z using_buildlet 10.240.0.104:80
  2019-09-17T13:23:29Z write_snapshot_tar 
  2019-09-17T13:23:33Z finish_write_snapshot_tar after 3.9s
  2019-09-17T13:23:33Z make_and_test 
  2019-09-17T13:23:33Z fetching_subrepo tools
  2019-09-17T13:23:33Z get_source 
  2019-09-17T13:23:34Z finish_get_source after 0s
  2019-09-17T13:23:34Z listing_subrepo_modules tools
  2019-09-17T13:23:34Z finish_listing_subrepo_modules after 16.9ms; tools
  2019-09-17T13:23:34Z running_subrepo_tests tools
   +6.1s (now)

Build log:
linux-amd64 at c3c53661ba8823ea7a051110aebbdea2650c25d0 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn57c1852" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=2.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok    golang.org/x/tools/benchmark/parse  0.003s
ok    golang.org/x/tools/blog 0.007s
?     golang.org/x/tools/blog/atom  [no test files]
?     golang.org/x/tools/cmd/auth/authtest  [no test files]
?     golang.org/x/tools/cmd/auth/cookieauth  [no test files]
?     golang.org/x/tools/cmd/auth/gitauth [no test files]
?     golang.org/x/tools/cmd/auth/netrcauth [no test files]
ok    golang.org/x/tools/cmd/benchcmp 0.008s
ok    golang.org/x/tools/cmd/bundle 0.008s
ok    golang.org/x/tools/cmd/callgraph  9.190s
?     golang.org/x/tools/cmd/compilebench [no test files]
ok    golang.org/x/tools/cmd/cover  1.821s
ok    golang.org/x/tools/cmd/digraph  0.008s
?     golang.org/x/tools/cmd/eg [no test files]
ok    golang.org/x/tools/cmd/fiximports 8.834s
ok    golang.org/x/tools/cmd/getgo  0.032s
?     golang.org/x/tools/cmd/getgo/server [no test files]
ok    golang.org/x/tools/cmd/go-contrib-init  0.004s
?     golang.org/x/tools/cmd/godex  [no test files]
ok    golang.org/x/tools/cmd/godoc  12.003s
?     golang.org/x/tools/cmd/goimports  [no test files]
?     golang.org/x/tools/cmd/gomvpkg  [no test files]
?     golang.org/x/tools/cmd/gopls  [no test files]
ok    golang.org/x/tools/cmd/gorename 9.114s
?     golang.org/x/tools/cmd/gotype [no test files]
?     golang.org/x/tools/cmd/goyacc [no test files]
ok    golang.org/x/tools/cmd/guru 0.023s
?     golang.org/x/tools/cmd/guru/serial  [no test files]
?     golang.org/x/tools/cmd/html2article [no test files]
?     golang.org/x/tools/cmd/present  [no test files]
?     golang.org/x/tools/cmd/splitdwarf [no test files]
ok    golang.org/x/tools/cmd/splitdwarf/internal/macho  0.016s
?     golang.org/x/tools/cmd/ssadump  [no test files]
?     golang.org/x/tools/cmd/stress [no test files]
ok    golang.org/x/tools/cmd/stringer 38.807s
?     golang.org/x/tools/cmd/toolstash  [no test files]
ok    golang.org/x/tools/container/intsets  0.739s
?     golang.org/x/tools/cover  [no test files]
?     golang.org/x/tools/go/analysis  [no test files]
ok    golang.org/x/tools/go/analysis/analysistest 0.242s
ok    golang.org/x/tools/go/analysis/internal/analysisflags 0.134s
ok    golang.org/x/tools/go/analysis/internal/checker 0.135s
ok    golang.org/x/tools/go/analysis/internal/facts 0.195s
ok    golang.org/x/tools/go/analysis/multichecker 18.411s
ok    golang.org/x/tools/go/analysis/passes/asmdecl 0.733s
ok    golang.org/x/tools/go/analysis/passes/assign  2.055s
ok    golang.org/x/tools/go/analysis/passes/atomic  0.058s
ok    golang.org/x/tools/go/analysis/passes/atomicalign 0.074s
ok    golang.org/x/tools/go/analysis/passes/bools 1.546s
ok    golang.org/x/tools/go/analysis/passes/buildssa  0.066s
ok    golang.org/x/tools/go/analysis/passes/buildtag  0.045s
ok    golang.org/x/tools/go/analysis/passes/cgocall 3.486s
ok    golang.org/x/tools/go/analysis/passes/composite 2.823s
ok    golang.org/x/tools/go/analysis/passes/copylock  1.644s
ok    golang.org/x/tools/go/analysis/passes/ctrlflow  3.431s
ok    golang.org/x/tools/go/analysis/passes/deepequalerrors 2.312s
ok    golang.org/x/tools/go/analysis/passes/errorsas  1.599s
ok    golang.org/x/tools/go/analysis/passes/findcall  0.277s
?     golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
ok    golang.org/x/tools/go/analysis/passes/httpresponse  3.901s
?     golang.org/x/tools/go/analysis/passes/inspect [no test files]
?     golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
ok    golang.org/x/tools/go/analysis/passes/loopclosure 0.116s
ok    golang.org/x/tools/go/analysis/passes/lostcancel  2.952s
?     golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
ok    golang.org/x/tools/go/analysis/passes/nilfunc 0.080s
ok    golang.org/x/tools/go/analysis/passes/nilness 0.093s
?     golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
ok    golang.org/x/tools/go/analysis/passes/pkgfact 0.033s
ok    golang.org/x/tools/go/analysis/passes/printf  2.735s
ok    golang.org/x/tools/go/analysis/passes/shadow  1.973s
?     golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
ok    golang.org/x/tools/go/analysis/passes/shift 0.039s
ok    golang.org/x/tools/go/analysis/passes/stdmethods  4.750s
ok    golang.org/x/tools/go/analysis/passes/structtag 2.889s
ok    golang.org/x/tools/go/analysis/passes/tests 2.272s
ok    golang.org/x/tools/go/analysis/passes/unmarshal 2.483s
?     golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
ok    golang.org/x/tools/go/analysis/passes/unreachable 0.094s
ok    golang.org/x/tools/go/analysis/passes/unsafeptr 2.705s
ok    golang.org/x/tools/go/analysis/passes/unusedresult  2.760s
?     golang.org/x/tools/go/analysis/singlechecker  [no test files]
ok    golang.org/x/tools/go/analysis/unitchecker  2.832s
ok    golang.org/x/tools/go/ast/astutil 0.030s
ok    golang.org/x/tools/go/ast/inspector 0.134s
ok    golang.org/x/tools/go/buildutil 0.049s
?     golang.org/x/tools/go/callgraph [no test files]
ok    golang.org/x/tools/go/callgraph/cha 0.024s
ok    golang.org/x/tools/go/callgraph/rta 0.018s
ok    golang.org/x/tools/go/callgraph/static  0.025s
ok    golang.org/x/tools/go/cfg 0.004s
ok    golang.org/x/tools/go/expect  0.041s
ok    golang.org/x/tools/go/gccgoexportdata 0.026s
ok    golang.org/x/tools/go/gcexportdata  0.029s
?     golang.org/x/tools/go/internal/cgo  [no test files]
ok    golang.org/x/tools/go/internal/gccgoimporter  0.021s
ok    golang.org/x/tools/go/internal/gcimporter 39.290s
?     golang.org/x/tools/go/internal/packagesdriver [no test files]
ok    golang.org/x/tools/go/loader  13.180s
ok    golang.org/x/tools/go/packages  42.885s
?     golang.org/x/tools/go/packages/gopackages [no test files]
ok    golang.org/x/tools/go/packages/packagestest 0.079s
ok    golang.org/x/tools/go/pointer 6.114s
ok    golang.org/x/tools/go/ssa 7.986s
ok    golang.org/x/tools/go/ssa/interp  0.453s
ok    golang.org/x/tools/go/ssa/ssautil 5.046s
ok    golang.org/x/tools/go/types/objectpath  0.033s
ok    golang.org/x/tools/go/types/typeutil  0.983s
ok    golang.org/x/tools/go/vcs 0.030s
ok    golang.org/x/tools/godoc  0.614s
?     golang.org/x/tools/godoc/analysis [no test files]
?     golang.org/x/tools/godoc/golangorgenv [no test files]
ok    golang.org/x/tools/godoc/redirect 5.139s
ok    golang.org/x/tools/godoc/static 1.920s
?     golang.org/x/tools/godoc/util [no test files]
ok    golang.org/x/tools/godoc/vfs  0.007s
ok    golang.org/x/tools/godoc/vfs/gatefs 0.021s
?     golang.org/x/tools/godoc/vfs/httpfs [no test files]
ok    golang.org/x/tools/godoc/vfs/mapfs  0.004s
ok    golang.org/x/tools/godoc/vfs/zipfs  0.005s
?     golang.org/x/tools/imports  [no test files]
ok    golang.org/x/tools/internal/apidiff 0.600s
ok    golang.org/x/tools/internal/fastwalk  0.025s
ok    golang.org/x/tools/internal/gopathwalk  0.028s
ok    golang.org/x/tools/internal/imports 18.871s
ok    golang.org/x/tools/internal/jsonrpc2  0.039s
ok    golang.org/x/tools/internal/lsp 15.935s
?     golang.org/x/tools/internal/lsp/browser [no test files]
?     golang.org/x/tools/internal/lsp/cache [no test files]
ok    golang.org/x/tools/internal/lsp/cmd 5.511s
?     golang.org/x/tools/internal/lsp/debug [no test files]
ok    golang.org/x/tools/internal/lsp/diff  0.019s
?     golang.org/x/tools/internal/lsp/diff/difftest [no test files]
ok    golang.org/x/tools/internal/lsp/diff/myers  0.013s
ok    golang.org/x/tools/internal/lsp/fuzzy 0.020s
?     golang.org/x/tools/internal/lsp/protocol  [no test files]
ok    golang.org/x/tools/internal/lsp/snippet 0.013s
ok    golang.org/x/tools/internal/lsp/source  9.907s
?     golang.org/x/tools/internal/lsp/telemetry [no test files]
?     golang.org/x/tools/internal/lsp/tests [no test files]
ok    golang.org/x/tools/internal/memoize 0.043s
ok    golang.org/x/tools/internal/module  0.004s
ok    golang.org/x/tools/internal/semver  0.018s
ok    golang.org/x/tools/internal/span  0.021s
?     golang.org/x/tools/internal/telemetry [no test files]
?     golang.org/x/tools/internal/telemetry/export  [no test files]
ok    golang.org/x/tools/internal/telemetry/export/ocagent  0.009s
?     golang.org/x/tools/internal/telemetry/export/ocagent/wire [no test files]
?     golang.org/x/tools/internal/telemetry/export/prometheus [no test files]
?     golang.org/x/tools/internal/telemetry/log [no test files]
?     golang.org/x/tools/internal/telemetry/metric  [no test files]
?     golang.org/x/tools/internal/telemetry/stats [no test files]
?     golang.org/x/tools/internal/telemetry/tag [no test files]
?     golang.org/x/tools/internal/telemetry/trace [no test files]
?     golang.org/x/tools/internal/telemetry/unit  [no test files]
?     golang.org/x/tools/internal/testenv [no test files]
?     golang.org/x/tools/internal/tool  [no test files]
ok    golang.org/x/tools/internal/txtar 0.010s
?     golang.org/x/tools/internal/xcontext  [no test files]
?     golang.org/x/tools/playground [no test files]
ok    golang.org/x/tools/playground/socket  0.015s
ok    golang.org/x/tools/present  0.017s
ok    golang.org/x/tools/refactor/eg  3.771s
ok    golang.org/x/tools/refactor/importgraph 0.730s
ok    golang.org/x/tools/refactor/rename  0.135s
?     golang.org/x/tools/refactor/satisfy [no test files]
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/gopls/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn57c1852" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=2.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools/gopls

go: downloading github.com/sergi/go-diff v1.0.0
go: extracting github.com/sergi/go-diff v1.0.0
go: finding github.com/sergi/go-diff v1.0.0
?     golang.org/x/tools/gopls  [no test files]
ok    golang.org/x/tools/gopls/hooks  0.002s
linux-amd64-race (Go tip)
  builder: linux-amd64-race
      rev: c3c53661ba8823ea7a051110aebbdea2650c25d0
 buildlet: http://10.240.0.101 GCE VM: buildlet-linux-jessie-rnbc682a5
  started: 2019-09-17 13:22:37.767239662 +0000 UTC m=+964.685257455
   status: still running

Events:
  2019-09-17T13:22:37Z checking_for_snapshot 
  2019-09-17T13:22:38Z finish_checking_for_snapshot after 33.7ms
  2019-09-17T13:22:38Z get_buildlet 
  2019-09-17T13:22:38Z awaiting_gce_quota 
  2019-09-17T13:22:38Z finish_awaiting_gce_quota after 0s
  2019-09-17T13:22:38Z create_gce_buildlet buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:22:38Z create_gce_instance buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:22:47Z finish_create_gce_instance after 8.94s; buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:22:47Z wait_buildlet_start buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:22:47Z got_instance_info waiting_for_buildlet...
  2019-09-17T13:23:30Z finish_wait_buildlet_start after 42.4s; buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:23:30Z finish_create_gce_buildlet after 51.9s; buildlet-linux-jessie-rnbc682a5
  2019-09-17T13:23:30Z finish_get_buildlet after 52.2s
  2019-09-17T13:23:30Z using_buildlet 10.240.0.101:80
  2019-09-17T13:23:30Z write_snapshot_tar 
  2019-09-17T13:23:35Z finish_write_snapshot_tar after 4.8s
  2019-09-17T13:23:35Z make_and_test 
  2019-09-17T13:23:35Z fetching_subrepo tools
  2019-09-17T13:23:35Z get_source 
  2019-09-17T13:23:35Z finish_get_source after 0s
  2019-09-17T13:23:35Z listing_subrepo_modules tools
  2019-09-17T13:23:35Z finish_listing_subrepo_modules after 17.3ms; tools
  2019-09-17T13:23:35Z running_subrepo_tests tools
   +6.6s (now)

Build log:
linux-amd64-race at c3c53661ba8823ea7a051110aebbdea2650c25d0 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "-race" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rnbc682a5" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=3.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64-race" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok    golang.org/x/tools/benchmark/parse  1.020s
ok    golang.org/x/tools/blog 1.040s
?     golang.org/x/tools/blog/atom  [no test files]
?     golang.org/x/tools/cmd/auth/authtest  [no test files]
?     golang.org/x/tools/cmd/auth/cookieauth  [no test files]
?     golang.org/x/tools/cmd/auth/gitauth [no test files]
?     golang.org/x/tools/cmd/auth/netrcauth [no test files]
ok    golang.org/x/tools/cmd/benchcmp 1.034s
ok    golang.org/x/tools/cmd/bundle 1.031s
ok    golang.org/x/tools/cmd/callgraph  28.326s
?     golang.org/x/tools/cmd/compilebench [no test files]
ok    golang.org/x/tools/cmd/cover  2.647s
ok    golang.org/x/tools/cmd/digraph  1.032s
?     golang.org/x/tools/cmd/eg [no test files]
ok    golang.org/x/tools/cmd/fiximports 10.632s
ok    golang.org/x/tools/cmd/getgo  1.014s
?     golang.org/x/tools/cmd/getgo/server [no test files]
ok    golang.org/x/tools/cmd/go-contrib-init  1.054s
?     golang.org/x/tools/cmd/godex  [no test files]
ok    golang.org/x/tools/cmd/godoc  18.501s
?     golang.org/x/tools/cmd/goimports  [no test files]
?     golang.org/x/tools/cmd/gomvpkg  [no test files]
?     golang.org/x/tools/cmd/gopls  [no test files]
ok    golang.org/x/tools/cmd/gorename 10.347s
?     golang.org/x/tools/cmd/gotype [no test files]
?     golang.org/x/tools/cmd/goyacc [no test files]
ok    golang.org/x/tools/cmd/guru 1.060s
?     golang.org/x/tools/cmd/guru/serial  [no test files]
?     golang.org/x/tools/cmd/html2article [no test files]
?     golang.org/x/tools/cmd/present  [no test files]
?     golang.org/x/tools/cmd/splitdwarf [no test files]
ok    golang.org/x/tools/cmd/splitdwarf/internal/macho  1.021s
?     golang.org/x/tools/cmd/ssadump  [no test files]
?     golang.org/x/tools/cmd/stress [no test files]
ok    golang.org/x/tools/cmd/stringer 32.488s
?     golang.org/x/tools/cmd/toolstash  [no test files]
ok    golang.org/x/tools/container/intsets  3.000s
?     golang.org/x/tools/cover  [no test files]
?     golang.org/x/tools/go/analysis  [no test files]
ok    golang.org/x/tools/go/analysis/analysistest 1.157s
ok    golang.org/x/tools/go/analysis/internal/analysisflags 7.180s
ok    golang.org/x/tools/go/analysis/internal/checker 1.060s
ok    golang.org/x/tools/go/analysis/internal/facts 1.237s
ok    golang.org/x/tools/go/analysis/multichecker 70.897s
ok    golang.org/x/tools/go/analysis/passes/asmdecl 2.571s
ok    golang.org/x/tools/go/analysis/passes/assign  7.343s
ok    golang.org/x/tools/go/analysis/passes/atomic  1.162s
ok    golang.org/x/tools/go/analysis/passes/atomicalign 1.159s
ok    golang.org/x/tools/go/analysis/passes/bools 7.180s
ok    golang.org/x/tools/go/analysis/passes/buildssa  1.189s
ok    golang.org/x/tools/go/analysis/passes/buildtag  1.048s
ok    golang.org/x/tools/go/analysis/passes/cgocall 13.136s
ok    golang.org/x/tools/go/analysis/passes/composite 9.670s
ok    golang.org/x/tools/go/analysis/passes/copylock  5.519s
ok    golang.org/x/tools/go/analysis/passes/ctrlflow  12.508s
ok    golang.org/x/tools/go/analysis/passes/deepequalerrors 7.996s
ok    golang.org/x/tools/go/analysis/passes/errorsas  7.245s
ok    golang.org/x/tools/go/analysis/passes/findcall  1.249s
?     golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
ok    golang.org/x/tools/go/analysis/passes/httpresponse  17.178s
?     golang.org/x/tools/go/analysis/passes/inspect [no test files]
?     golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
ok    golang.org/x/tools/go/analysis/passes/loopclosure 1.067s
ok    golang.org/x/tools/go/analysis/passes/lostcancel  11.492s
?     golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
ok    golang.org/x/tools/go/analysis/passes/nilfunc 1.186s
ok    golang.org/x/tools/go/analysis/passes/nilness 1.072s
?     golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
ok    golang.org/x/tools/go/analysis/passes/pkgfact 1.085s
ok    golang.org/x/tools/go/analysis/passes/printf  11.080s
ok    golang.org/x/tools/go/analysis/passes/shadow  6.257s
?     golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
ok    golang.org/x/tools/go/analysis/passes/shift 1.179s
ok    golang.org/x/tools/go/analysis/passes/stdmethods  18.788s
ok    golang.org/x/tools/go/analysis/passes/structtag 9.792s
ok    golang.org/x/tools/go/analysis/passes/tests 9.492s
ok    golang.org/x/tools/go/analysis/passes/unmarshal 9.909s
?     golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
ok    golang.org/x/tools/go/analysis/passes/unreachable 1.191s
ok    golang.org/x/tools/go/analysis/passes/unsafeptr 7.558s
ok    golang.org/x/tools/go/analysis/passes/unusedresult  7.149s
?     golang.org/x/tools/go/analysis/singlechecker  [no test files]
ok    golang.org/x/tools/go/analysis/unitchecker  26.423s
ok    golang.org/x/tools/go/ast/astutil 1.181s
ok    golang.org/x/tools/go/ast/inspector 1.499s
ok    golang.org/x/tools/go/buildutil 1.239s
?     golang.org/x/tools/go/callgraph [no test files]
ok    golang.org/x/tools/go/callgraph/cha 1.025s
ok    golang.org/x/tools/go/callgraph/rta 1.024s
ok    golang.org/x/tools/go/callgraph/static  1.019s
ok    golang.org/x/tools/go/cfg 1.013s
ok    golang.org/x/tools/go/expect  1.013s
ok    golang.org/x/tools/go/gccgoexportdata 1.018s
ok    golang.org/x/tools/go/gcexportdata  1.188s
?     golang.org/x/tools/go/internal/cgo  [no test files]
ok    golang.org/x/tools/go/internal/gccgoimporter  1.050s
ok    golang.org/x/tools/go/internal/gcimporter 34.188s
?     golang.org/x/tools/go/internal/packagesdriver [no test files]
ok    golang.org/x/tools/go/loader  34.232s
ok    golang.org/x/tools/go/packages  82.154s
?     golang.org/x/tools/go/packages/gopackages [no test files]
ok    golang.org/x/tools/go/packages/packagestest 1.213s
ok    golang.org/x/tools/go/pointer 21.960s
ok    golang.org/x/tools/go/ssa 29.390s
ok    golang.org/x/tools/go/ssa/interp  2.924s
ok    golang.org/x/tools/go/ssa/ssautil 10.302s
ok    golang.org/x/tools/go/types/objectpath  1.084s
ok    golang.org/x/tools/go/types/typeutil  6.440s
ok    golang.org/x/tools/go/vcs 1.035s
ok    golang.org/x/tools/godoc  5.944s
?     golang.org/x/tools/godoc/analysis [no test files]
?     golang.org/x/tools/godoc/golangorgenv [no test files]
ok    golang.org/x/tools/godoc/redirect 6.275s
ok    golang.org/x/tools/godoc/static 26.086s
?     golang.org/x/tools/godoc/util [no test files]
ok    golang.org/x/tools/godoc/vfs  1.051s
ok    golang.org/x/tools/godoc/vfs/gatefs 1.016s
?     golang.org/x/tools/godoc/vfs/httpfs [no test files]
ok    golang.org/x/tools/godoc/vfs/mapfs  1.015s
ok    golang.org/x/tools/godoc/vfs/zipfs  1.041s
?     golang.org/x/tools/imports  [no test files]
ok    golang.org/x/tools/internal/apidiff 2.513s
ok    golang.org/x/tools/internal/fastwalk  1.050s
ok    golang.org/x/tools/internal/gopathwalk  1.026s
ok    golang.org/x/tools/internal/imports 47.416s
ok    golang.org/x/tools/internal/jsonrpc2  1.080s
ok    golang.org/x/tools/internal/lsp 25.480s
?     golang.org/x/tools/internal/lsp/browser [no test files]
?     golang.org/x/tools/internal/lsp/cache [no test files]
ok    golang.org/x/tools/internal/lsp/cmd 13.477s
?     golang.org/x/tools/internal/lsp/debug [no test files]
ok    golang.org/x/tools/internal/lsp/diff  1.011s
?     golang.org/x/tools/internal/lsp/diff/difftest [no test files]
ok    golang.org/x/tools/internal/lsp/diff/myers  1.016s
ok    golang.org/x/tools/internal/lsp/fuzzy 1.217s
?     golang.org/x/tools/internal/lsp/protocol  [no test files]
ok    golang.org/x/tools/internal/lsp/snippet 1.039s
ok    golang.org/x/tools/internal/lsp/source  24.204s
?     golang.org/x/tools/internal/lsp/telemetry [no test files]
?     golang.org/x/tools/internal/lsp/tests [no test files]
ok    golang.org/x/tools/internal/memoize 1.046s
ok    golang.org/x/tools/internal/module  1.023s
ok    golang.org/x/tools/internal/semver  1.023s
ok    golang.org/x/tools/internal/span  1.043s
?     golang.org/x/tools/internal/telemetry [no test files]
?     golang.org/x/tools/internal/telemetry/export  [no test files]
ok    golang.org/x/tools/internal/telemetry/export/ocagent  1.017s
?     golang.org/x/tools/internal/telemetry/export/ocagent/wire [no test files]
?     golang.org/x/tools/internal/telemetry/export/prometheus [no test files]
?     golang.org/x/tools/internal/telemetry/log [no test files]
?     golang.org/x/tools/internal/telemetry/metric  [no test files]
?     golang.org/x/tools/internal/telemetry/stats [no test files]
?     golang.org/x/tools/internal/telemetry/tag [no test files]
?     golang.org/x/tools/internal/telemetry/trace [no test files]
?     golang.org/x/tools/internal/telemetry/unit  [no test files]
?     golang.org/x/tools/internal/testenv [no test files]
?     golang.org/x/tools/internal/tool  [no test files]
ok    golang.org/x/tools/internal/txtar 1.012s
?     golang.org/x/tools/internal/xcontext  [no test files]
?     golang.org/x/tools/playground [no test files]
ok    golang.org/x/tools/playground/socket  1.028s
ok    golang.org/x/tools/present  1.031s
ok    golang.org/x/tools/refactor/eg  14.758s
ok    golang.org/x/tools/refactor/importgraph 5.950s
ok    golang.org/x/tools/refactor/rename  1.547s
?     golang.org/x/tools/refactor/satisfy [no test files]
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "-race" "golang.org/x/tools/gopls/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rnbc682a5" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=3.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64-race" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools/gopls

go: downloading github.com/sergi/go-diff v1.0.0
go: extracting github.com/sergi/go-diff v1.0.0
go: finding github.com/sergi/go-diff v1.0.0
?     golang.org/x/tools/gopls  [no test files]
ok    golang.org/x/tools/gopls/hooks  1.009s
windows-amd64-2016 (Go tip)
  builder: windows-amd64-2016
      rev: c3c53661ba8823ea7a051110aebbdea2650c25d0
 buildlet: http://10.240.0.100 GCE VM: buildlet-windows-amd64-2016-rn426760d
  started: 2019-09-17 13:22:37.767255658 +0000 UTC m=+964.685273446
   status: still running

Events:
  2019-09-17T13:22:37Z checking_for_snapshot 
  2019-09-17T13:22:38Z finish_checking_for_snapshot after 14.6ms
  2019-09-17T13:22:38Z get_buildlet 
  2019-09-17T13:22:38Z awaiting_gce_quota 
  2019-09-17T13:22:38Z finish_awaiting_gce_quota after 0s
  2019-09-17T13:22:38Z create_gce_buildlet buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:22:38Z create_gce_instance buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:22:47Z finish_create_gce_instance after 8.81s; buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:22:47Z wait_buildlet_start buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:22:47Z got_instance_info waiting_for_buildlet...
  2019-09-17T13:23:34Z finish_wait_buildlet_start after 47.4s; buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:23:34Z finish_create_gce_buildlet after 56.4s; buildlet-windows-amd64-2016-rn426760d
  2019-09-17T13:23:34Z finish_get_buildlet after 56.5s
  2019-09-17T13:23:34Z using_buildlet 10.240.0.100:80
  2019-09-17T13:23:34Z write_snapshot_tar 
  2019-09-17T13:23:43Z finish_write_snapshot_tar after 8.88s
  2019-09-17T13:23:43Z make_and_test 
  2019-09-17T13:23:43Z fetching_subrepo tools
  2019-09-17T13:23:43Z get_source 
  2019-09-17T13:23:43Z finish_get_source after 0s
  2019-09-17T13:23:44Z listing_subrepo_modules tools
  2019-09-17T13:23:45Z finish_listing_subrepo_modules after 47.8ms; tools
  2019-09-17T13:23:45Z running_subrepo_tests tools
   +0.3s (now)

Build log:
windows-amd64-2016 at c3c53661ba8823ea7a051110aebbdea2650c25d0 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=C:\workdir\gopath\src\golang.org\x\tools\go.mod

:: Running C:\workdir\go\bin\go with args ["C:\\workdir\\go\\bin\\go" "test" "-short" "golang.org/x/tools/..."] and env ["GOBUILDEXIT=1" "=C:=C:\\golang" "ALLUSERSPROFILE=C:\\ProgramData" "APPDATA=C:\\Users\\gopher\\AppData\\Roaming" "CommonProgramFiles=C:\\Program Files\\Common Files" "CommonProgramFiles(x86)=C:\\Program Files (x86)\\Common Files" "CommonProgramW6432=C:\\Program Files\\Common Files" "COMPUTERNAME=SERVER-2016-V7-" "ComSpec=C:\\Windows\\system32\\cmd.exe" "GooGetRoot=C:\\ProgramData\\GooGet" "GOROOT_BOOTSTRAP=C:\\workdir\\go1.4" "HOMEDRIVE=C:" "HOMEPATH=\\Users\\gopher" "LOCALAPPDATA=C:\\Users\\gopher\\AppData\\Local" "LOGONSERVER=\\\\SERVER-2016-V7-" "NUMBER_OF_PROCESSORS=4" "OS=Windows_NT" "PATH=C:\\workdir/go/bin;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\ProgramData\\GooGet;C:\\Program Files\\Google\\Compute Engine\\metadata_scripts;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\bin;C:\\Program Files\\Google\\Compute Engine\\sysprep;C:\\Users\\gopher\\AppData\\Local\\Microsoft\\WindowsApps;;C:\\godep\\gcc64\\bin" "PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC" "PROCESSOR_ARCHITECTURE=AMD64" "PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 63 Stepping 0, GenuineIntel" "PROCESSOR_LEVEL=6" "PROCESSOR_REVISION=3f00" "ProgramData=C:\\ProgramData" "ProgramFiles=C:\\Program Files" "ProgramFiles(x86)=C:\\Program Files (x86)" "ProgramW6432=C:\\Program Files" "PROMPT=$P$G" "PSModulePath=C:\\Program Files (x86)\\WindowsPowerShell\\Modules;C:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\platform\\PowerShell" "PUBLIC=C:\\Users\\Public" "SESSIONNAME=Console" "SystemDrive=C:" "SystemRoot=C:\\Windows" "TEMP=C:\\Users\\gopher\\AppData\\Local\\Temp\\1" "TMP=C:\\Users\\gopher\\AppData\\Local\\Temp\\1" "USERDOMAIN=SERVER-2016-V7-" "USERDOMAIN_ROAMINGPROFILE=SERVER-2016-V7-" "USERNAME=gopher" "USERPROFILE=C:\\Users\\gopher" "windir=C:\\Windows" "GO_STAGE0_NET_DELAY=40.2s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=C:\\workdir" "GO_BUILDER_NAME=windows-amd64-2016" "GOARCH=amd64" "GOHOSTARCH=amd64" "GO_TEST_TIMEOUT_SCALE=2" "GOROOT=C:\\workdir\\go" "GOPATH=C:\\workdir\\gopath" "GOPROXY=http://10.240.0.72:30157"] in dir C:\workdir\gopath\src\golang.org\x\tools

go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok    golang.org/x/tools/benchmark/parse  0.096s
ok    golang.org/x/tools/blog 0.049s
?     golang.org/x/tools/blog/atom  [no test files]
?     golang.org/x/tools/cmd/auth/authtest  [no test files]
?     golang.org/x/tools/cmd/auth/cookieauth  [no test files]
?     golang.org/x/tools/cmd/auth/gitauth [no test files]
?     golang.org/x/tools/cmd/auth/netrcauth [no test files]
ok    golang.org/x/tools/cmd/benchcmp 0.052s
ok    golang.org/x/tools/cmd/bundle 0.161s
ok    golang.org/x/tools/cmd/callgraph  7.433s
?     golang.org/x/tools/cmd/compilebench [no test files]
ok    golang.org/x/tools/cmd/cover  2.969s
ok    golang.org/x/tools/cmd/digraph  0.032s
?     golang.org/x/tools/cmd/eg [no test files]
ok    golang.org/x/tools/cmd/fiximports 15.607s
ok    golang.org/x/tools/cmd/getgo  7.172s
?     golang.org/x/tools/cmd/getgo/server [no test files]
ok    golang.org/x/tools/cmd/go-contrib-init  0.048s
?     golang.org/x/tools/cmd/godex  [no test files]
ok    golang.org/x/tools/cmd/godoc  12.906s
?     golang.org/x/tools/cmd/goimports  [no test files]
?     golang.org/x/tools/cmd/gomvpkg  [no test files]
?     golang.org/x/tools/cmd/gopls  [no test files]
ok    golang.org/x/tools/cmd/gorename 22.675s
?     golang.org/x/tools/cmd/gotype [no test files]
?     golang.org/x/tools/cmd/goyacc [no test files]
ok    golang.org/x/tools/cmd/guru 0.065s
?     golang.org/x/tools/cmd/guru/serial  [no test files]
?     golang.org/x/tools/cmd/html2article [no test files]
?     golang.org/x/tools/cmd/present  [no test files]
ok    golang.org/x/tools/cmd/splitdwarf/internal/macho  0.260s
?     golang.org/x/tools/cmd/ssadump  [no test files]
?     golang.org/x/tools/cmd/stress [no test files]
ok    golang.org/x/tools/cmd/stringer 44.594s
?     golang.org/x/tools/cmd/toolstash  [no test files]
ok    golang.org/x/tools/container/intsets  0.608s
?     golang.org/x/tools/cover  [no test files]
?     golang.org/x/tools/go/analysis  [no test files]
ok    golang.org/x/tools/go/analysis/analysistest 0.294s
ok    golang.org/x/tools/go/analysis/internal/analysisflags 0.032s
ok    golang.org/x/tools/go/analysis/internal/checker 0.276s
ok    golang.org/x/tools/go/analysis/internal/facts 0.496s
ok    golang.org/x/tools/go/analysis/multichecker 0.048s
ok    golang.org/x/tools/go/analysis/passes/asmdecl 1.186s
ok    golang.org/x/tools/go/analysis/passes/assign  1.414s
ok    golang.org/x/tools/go/analysis/passes/atomic  0.154s
ok    golang.org/x/tools/go/analysis/passes/atomicalign 0.177s
ok    golang.org/x/tools/go/analysis/passes/bools 1.253s
ok    golang.org/x/tools/go/analysis/passes/buildssa  0.135s
ok    golang.org/x/tools/go/analysis/passes/buildtag  0.175s
ok    golang.org/x/tools/go/analysis/passes/cgocall 3.216s
ok    golang.org/x/tools/go/analysis/passes/composite 1.815s
ok    golang.org/x/tools/go/analysis/passes/copylock  1.232s
ok    golang.org/x/tools/go/analysis/passes/ctrlflow  2.665s
ok    golang.org/x/tools/go/analysis/passes/deepequalerrors 2.548s
ok    golang.org/x/tools/go/analysis/passes/errorsas  1.281s
ok    golang.org/x/tools/go/analysis/passes/findcall  0.485s
?     golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
ok    golang.org/x/tools/go/analysis/passes/httpresponse  3.171s
?     golang.org/x/tools/go/analysis/passes/inspect [no test files]
?     golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
ok    golang.org/x/tools/go/analysis/passes/loopclosure 0.185s
ok    golang.org/x/tools/go/analysis/passes/lostcancel  2.898s
?     golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
ok    golang.org/x/tools/go/analysis/passes/nilfunc 0.269s
ok    golang.org/x/tools/go/analysis/passes/nilness 0.259s
?     golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
ok    golang.org/x/tools/go/analysis/passes/pkgfact 0.183s
ok    golang.org/x/tools/go/analysis/passes/printf  1.973s
ok    golang.org/x/tools/go/analysis/passes/shadow  1.916s
?     golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
ok    golang.org/x/tools/go/analysis/passes/shift 0.568s
ok    golang.org/x/tools/go/analysis/passes/stdmethods  5.840s
ok    golang.org/x/tools/go/analysis/passes/structtag 2.364s
ok    golang.org/x/tools/go/analysis/passes/tests 3.396s
ok    golang.org/x/tools/go/analysis/passes/unmarshal 1.950s
?     golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
ok    golang.org/x/tools/go/analysis/passes/unreachable 0.168s
ok    golang.org/x/tools/go/analysis/passes/unsafeptr 1.812s
ok    golang.org/x/tools/go/analysis/passes/unusedresult  2.499s
?     golang.org/x/tools/go/analysis/singlechecker  [no test files]
ok    golang.org/x/tools/go/analysis/unitchecker  0.049s
ok    golang.org/x/tools/go/ast/astutil 0.079s
ok    golang.org/x/tools/go/ast/inspector 0.195s
ok    golang.org/x/tools/go/buildutil 0.138s
?     golang.org/x/tools/go/callgraph [no test files]
ok    golang.org/x/tools/go/callgraph/cha 0.070s
ok    golang.org/x/tools/go/callgraph/rta 0.076s
ok    golang.org/x/tools/go/callgraph/static  0.093s
ok    golang.org/x/tools/go/cfg 0.077s
ok    golang.org/x/tools/go/expect  0.091s
ok    golang.org/x/tools/go/gccgoexportdata 0.171s
ok    golang.org/x/tools/go/gcexportdata  0.132s
?     golang.org/x/tools/go/internal/cgo  [no test files]
ok    golang.org/x/tools/go/internal/gccgoimporter  0.161s
ok    golang.org/x/tools/go/internal/gcimporter 30.388s
?     golang.org/x/tools/go/internal/packagesdriver [no test files]
ok    golang.org/x/tools/go/loader  10.726s
ok    golang.org/x/tools/go/packages  50.082s
?     golang.org/x/tools/go/packages/gopackages [no test files]
ok    golang.org/x/tools/go/packages/packagestest 0.314s
ok    golang.org/x/tools/go/pointer 6.440s
ok    golang.org/x/tools/go/ssa 7.963s
ok    golang.org/x/tools/go/ssa/interp  0.715s
ok    golang.org/x/tools/go/ssa/ssautil 2.463s
ok    golang.org/x/tools/go/types/objectpath  0.038s
ok    golang.org/x/tools/go/types/typeutil  1.229s
ok    golang.org/x/tools/go/vcs 0.121s
ok    golang.org/x/tools/godoc  1.444s
?     golang.org/x/tools/godoc/analysis [no test files]
?     golang.org/x/tools/godoc/golangorgenv [no test files]
ok    golang.org/x/tools/godoc/redirect 0.352s
ok    golang.org/x/tools/godoc/static 1.739s
?     golang.org/x/tools/godoc/util [no test files]
ok    golang.org/x/tools/godoc/vfs  0.026s
ok    golang.org/x/tools/godoc/vfs/gatefs 0.206s
?     golang.org/x/tools/godoc/vfs/httpfs [no test files]
ok    golang.org/x/tools/godoc/vfs/mapfs  0.140s
ok    golang.org/x/tools/godoc/vfs/zipfs  0.071s
?     golang.org/x/tools/imports  [no test files]
ok    golang.org/x/tools/internal/apidiff 1.054s
ok    golang.org/x/tools/internal/fastwalk  0.044s
ok    golang.org/x/tools/internal/gopathwalk  0.052s
ok    golang.org/x/tools/internal/imports 43.497s
ok    golang.org/x/tools/internal/jsonrpc2  0.022s
ok    golang.org/x/tools/internal/lsp 25.336s
?     golang.org/x/tools/internal/lsp/browser [no test files]
?     golang.org/x/tools/internal/lsp/cache [no test files]
ok    golang.org/x/tools/internal/lsp/cmd 8.678s
?     golang.org/x/tools/internal/lsp/debug [no test files]
ok    golang.org/x/tools/internal/lsp/diff  0.043s
?     golang.org/x/tools/internal/lsp/diff/difftest [no test files]
ok    golang.org/x/tools/internal/lsp/diff/myers  0.028s
ok    golang.org/x/tools/internal/lsp/fuzzy 0.044s
?     golang.org/x/tools/internal/lsp/protocol  [no test files]
ok    golang.org/x/tools/internal/lsp/snippet 0.054s
ok    golang.org/x/tools/internal/lsp/source  22.819s
?     golang.org/x/tools/internal/lsp/telemetry [no test files]
?     golang.org/x/tools/internal/lsp/tests [no test files]
ok    golang.org/x/tools/internal/memoize 0.045s
ok    golang.org/x/tools/internal/module  0.030s
ok    golang.org/x/tools/internal/semver  0.028s
ok    golang.org/x/tools/internal/span  0.030s
?     golang.org/x/tools/internal/telemetry [no test files]
?     golang.org/x/tools/internal/telemetry/export  [no test files]
ok    golang.org/x/tools/internal/telemetry/export/ocagent  0.041s
?     golang.org/x/tools/internal/telemetry/export/ocagent/wire [no test files]
?     golang.org/x/tools/internal/telemetry/export/prometheus [no test files]
?     golang.org/x/tools/internal/telemetry/log [no test files]
?     golang.org/x/tools/internal/telemetry/metric  [no test files]
?     golang.org/x/tools/internal/telemetry/stats [no test files]
?     golang.org/x/tools/internal/telemetry/tag [no test files]
?     golang.org/x/tools/internal/telemetry/trace [no test files]
?     golang.org/x/tools/internal/telemetry/unit  [no test files]
?     golang.org/x/tools/internal/testenv [no test files]
?     golang.org/x/tools/internal/tool  [no test files]
ok    golang.org/x/tools/internal/txtar 0.022s
?     golang.org/x/tools/internal/xcontext  [no test files]
?     golang.org/x/tools/playground [no test files]
ok    golang.org/x/tools/playground/socket  0.057s
ok    golang.org/x/tools/present  0.039s
ok    golang.org/x/tools/refactor/eg  0.048s
ok    golang.org/x/tools/refactor/importgraph 3.309s
ok    golang.org/x/tools/refactor/rename  0.225s
?     golang.org/x/tools/refactor/satisfy [no test files]
:: Running C:\workdir\go\bin\go with args ["C:\\workdir\\go\\bin\\go" "test" "-short" "golang.org/x/tools/gopls/..."] and env ["GOBUILDEXIT=1" "=C:=C:\\golang" "ALLUSERSPROFILE=C:\\ProgramData" "APPDATA=C:\\Users\\gopher\\AppData\\Roaming" "CommonProgramFiles=C:\\Program Files\\Common Files" "CommonProgramFiles(x86)=C:\\Program Files (x86)\\Common Files" "CommonProgramW6432=C:\\Program Files\\Common Files" "COMPUTERNAME=SERVER-2016-V7-" "ComSpec=C:\\Windows\\system32\\cmd.exe" "GooGetRoot=C:\\ProgramData\\GooGet" "GOROOT_BOOTSTRAP=C:\\workdir\\go1.4" "HOMEDRIVE=C:" "HOMEPATH=\\Users\\gopher" "LOCALAPPDATA=C:\\Users\\gopher\\AppData\\Local" "LOGONSERVER=\\\\SERVER-2016-V7-" "NUMBER_OF_PROCESSORS=4" "OS=Windows_NT" "PATH=C:\\workdir/go/bin;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\ProgramData\\GooGet;C:\\Program Files\\Google\\Compute Engine\\metadata_scripts;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\bin;C:\\Program Files\\Google\\Compute Engine\\sysprep;C:\\Users\\gopher\\AppData\\Local\\Microsoft\\WindowsApps;;C:\\godep\\gcc64\\bin" "PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC" "PROCESSOR_ARCHITECTURE=AMD64" "PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 63 Stepping 0, GenuineIntel" "PROCESSOR_LEVEL=6" "PROCESSOR_REVISION=3f00" "ProgramData=C:\\ProgramData" "ProgramFiles=C:\\Program Files" "ProgramFiles(x86)=C:\\Program Files (x86)" "ProgramW6432=C:\\Program Files" "PROMPT=$P$G" "PSModulePath=C:\\Program Files (x86)\\WindowsPowerShell\\Modules;C:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\platform\\PowerShell" "PUBLIC=C:\\Users\\Public" "SESSIONNAME=Console" "SystemDrive=C:" "SystemRoot=C:\\Windows" "TEMP=C:\\Users\\gopher\\AppData\\Local\\Temp\\1" "TMP=C:\\Users\\gopher\\AppData\\Local\\Temp\\1" "USERDOMAIN=SERVER-2016-V7-" "USERDOMAIN_ROAMINGPROFILE=SERVER-2016-V7-" "USERNAME=gopher" "USERPROFILE=C:\\Users\\gopher" "windir=C:\\Windows" "GO_STAGE0_NET_DELAY=40.2s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=C:\\workdir" "GO_BUILDER_NAME=windows-amd64-2016" "GOARCH=amd64" "GOHOSTARCH=amd64" "GO_TEST_TIMEOUT_SCALE=2" "GOROOT=C:\\workdir\\go" "GOPATH=C:\\workdir\\gopath" "GOPROXY=http://10.240.0.72:30157"] in dir C:\workdir\gopath\src\golang.org\x\tools\gopls

go: downloading github.com/sergi/go-diff v1.0.0
go: extracting github.com/sergi/go-diff v1.0.0
go: finding github.com/sergi/go-diff v1.0.0
?     golang.org/x/tools/gopls  [no test files]
ok    golang.org/x/tools/gopls/hooks  0.030s
linux-amd64 (Go 1.13.x)
  builder: linux-amd64
      rev: f0c623086396faf308fb7e626bf4bf8a5010c857
 buildlet: http://10.240.0.98 GCE VM: buildlet-linux-stretch-rna876dd5
  started: 2019-09-17 13:22:37.767263695 +0000 UTC m=+964.685281477
   status: still running

Events:
  2019-09-17T13:22:37Z checking_for_snapshot 
  2019-09-17T13:22:37Z finish_checking_for_snapshot after 39.2ms
  2019-09-17T13:22:37Z get_buildlet 
  2019-09-17T13:22:37Z awaiting_gce_quota 
  2019-09-17T13:22:38Z finish_awaiting_gce_quota after 0s
  2019-09-17T13:22:38Z create_gce_buildlet buildlet-linux-stretch-rna876dd5
  2019-09-17T13:22:38Z create_gce_instance buildlet-linux-stretch-rna876dd5
  2019-09-17T13:22:48Z finish_create_gce_instance after 10.7s; buildlet-linux-stretch-rna876dd5
  2019-09-17T13:22:48Z wait_buildlet_start buildlet-linux-stretch-rna876dd5
  2019-09-17T13:22:49Z got_instance_info waiting_for_buildlet...
  2019-09-17T13:23:29Z finish_wait_buildlet_start after 40.2s; buildlet-linux-stretch-rna876dd5
  2019-09-17T13:23:29Z finish_create_gce_buildlet after 51.2s; buildlet-linux-stretch-rna876dd5
  2019-09-17T13:23:29Z finish_get_buildlet after 51.4s
  2019-09-17T13:23:29Z using_buildlet 10.240.0.98:80
  2019-09-17T13:23:29Z write_snapshot_tar 
  2019-09-17T13:23:33Z finish_write_snapshot_tar after 4.14s
  2019-09-17T13:23:33Z make_and_test 
  2019-09-17T13:23:33Z fetching_subrepo tools
  2019-09-17T13:23:33Z get_source 
  2019-09-17T13:23:33Z finish_get_source after 0s
  2019-09-17T13:23:34Z listing_subrepo_modules tools
  2019-09-17T13:23:34Z finish_listing_subrepo_modules after 16.3ms; tools
  2019-09-17T13:23:34Z running_subrepo_tests tools
  +12.0s (now)

Build log:
linux-amd64 at f0c623086396faf308fb7e626bf4bf8a5010c857 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rna876dd5" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=1.1s" "GO_STAGE0_DL_DELAY=300ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok    golang.org/x/tools/benchmark/parse  0.017s
ok    golang.org/x/tools/blog 0.036s
?     golang.org/x/tools/blog/atom  [no test files]
?     golang.org/x/tools/cmd/auth/authtest  [no test files]
?     golang.org/x/tools/cmd/auth/cookieauth  [no test files]
?     golang.org/x/tools/cmd/auth/gitauth [no test files]
?     golang.org/x/tools/cmd/auth/netrcauth [no test files]
ok    golang.org/x/tools/cmd/benchcmp 0.006s
ok    golang.org/x/tools/cmd/bundle 0.047s
ok    golang.org/x/tools/cmd/callgraph  7.618s
?     golang.org/x/tools/cmd/compilebench [no test files]
ok    golang.org/x/tools/cmd/cover  2.068s
ok    golang.org/x/tools/cmd/digraph  0.015s
?     golang.org/x/tools/cmd/eg [no test files]
ok    golang.org/x/tools/cmd/fiximports 8.865s
ok    golang.org/x/tools/cmd/getgo  0.045s
?     golang.org/x/tools/cmd/getgo/server [no test files]
ok    golang.org/x/tools/cmd/go-contrib-init  0.005s
?     golang.org/x/tools/cmd/godex  [no test files]
ok    golang.org/x/tools/cmd/godoc  12.274s
?     golang.org/x/tools/cmd/goimports  [no test files]
?     golang.org/x/tools/cmd/gomvpkg  [no test files]
?     golang.org/x/tools/cmd/gopls  [no test files]
ok    golang.org/x/tools/cmd/gorename 8.995s
?     golang.org/x/tools/cmd/gotype [no test files]
?     golang.org/x/tools/cmd/goyacc [no test files]
ok    golang.org/x/tools/cmd/guru 0.057s
?     golang.org/x/tools/cmd/guru/serial  [no test files]
?     golang.org/x/tools/cmd/html2article [no test files]
?     golang.org/x/tools/cmd/present  [no test files]
?     golang.org/x/tools/cmd/splitdwarf [no test files]
ok    golang.org/x/tools/cmd/splitdwarf/internal/macho  0.013s
?     golang.org/x/tools/cmd/ssadump  [no test files]
?     golang.org/x/tools/cmd/stress [no test files]
ok    golang.org/x/tools/cmd/stringer 36.576s
?     golang.org/x/tools/cmd/toolstash  [no test files]
ok    golang.org/x/tools/container/intsets  0.837s
?     golang.org/x/tools/cover  [no test files]
?     golang.org/x/tools/go/analysis  [no test files]
ok    golang.org/x/tools/go/analysis/analysistest 0.151s
ok    golang.org/x/tools/go/analysis/internal/analysisflags 0.125s
ok    golang.org/x/tools/go/analysis/internal/checker 0.160s
ok    golang.org/x/tools/go/analysis/internal/facts 0.229s
ok    golang.org/x/tools/go/analysis/multichecker 20.138s
ok    golang.org/x/tools/go/analysis/passes/asmdecl 0.494s
ok    golang.org/x/tools/go/analysis/passes/assign  1.454s
ok    golang.org/x/tools/go/analysis/passes/atomic  0.042s
ok    golang.org/x/tools/go/analysis/passes/atomicalign 0.056s
ok    golang.org/x/tools/go/analysis/passes/bools 1.870s
ok    golang.org/x/tools/go/analysis/passes/buildssa  0.048s
ok    golang.org/x/tools/go/analysis/passes/buildtag  0.036s
ok    golang.org/x/tools/go/analysis/passes/cgocall 3.834s
ok    golang.org/x/tools/go/analysis/passes/composite 2.867s
ok    golang.org/x/tools/go/analysis/passes/copylock  3.014s
ok    golang.org/x/tools/go/analysis/passes/ctrlflow  2.523s
ok    golang.org/x/tools/go/analysis/passes/deepequalerrors 1.858s
ok    golang.org/x/tools/go/analysis/passes/errorsas  1.921s
ok    golang.org/x/tools/go/analysis/passes/findcall  0.244s
?     golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
ok    golang.org/x/tools/go/analysis/passes/httpresponse  5.305s
?     golang.org/x/tools/go/analysis/passes/inspect [no test files]
?     golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
ok    golang.org/x/tools/go/analysis/passes/loopclosure 0.077s
ok    golang.org/x/tools/go/analysis/passes/lostcancel  2.754s
?     golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
ok    golang.org/x/tools/go/analysis/passes/nilfunc 0.071s
ok    golang.org/x/tools/go/analysis/passes/nilness 0.061s
?     golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
ok    golang.org/x/tools/go/analysis/passes/pkgfact 0.050s
ok    golang.org/x/tools/go/analysis/passes/printf  2.743s
ok    golang.org/x/tools/go/analysis/passes/shadow  1.919s
?     golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
ok    golang.org/x/tools/go/analysis/passes/shift 0.103s
ok    golang.org/x/tools/go/analysis/passes/stdmethods  6.079s
ok    golang.org/x/tools/go/analysis/passes/structtag 2.215s
ok    golang.org/x/tools/go/analysis/passes/tests 2.796s
ok    golang.org/x/tools/go/analysis/passes/unmarshal 2.201s
?     golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
ok    golang.org/x/tools/go/analysis/passes/unreachable 0.100s
ok    golang.org/x/tools/go/analysis/passes/unsafeptr 1.998s
ok    golang.org/x/tools/go/analysis/passes/unusedresult  2.015s
?     golang.org/x/tools/go/analysis/singlechecker  [no test files]
ok    golang.org/x/tools/go/analysis/unitchecker  2.907s
ok    golang.org/x/tools/go/ast/astutil 0.035s
ok    golang.org/x/tools/go/ast/inspector 0.127s
ok    golang.org/x/tools/go/buildutil 0.056s
?     golang.org/x/tools/go/callgraph [no test files]
ok    golang.org/x/tools/go/callgraph/cha 0.019s
ok    golang.org/x/tools/go/callgraph/rta 0.018s
ok    golang.org/x/tools/go/callgraph/static  0.019s
ok    golang.org/x/tools/go/cfg 0.010s
ok    golang.org/x/tools/go/expect  0.003s
ok    golang.org/x/tools/go/gccgoexportdata 0.003s
ok    golang.org/x/tools/go/gcexportdata  0.040s
?     golang.org/x/tools/go/internal/cgo  [no test files]
ok    golang.org/x/tools/go/internal/gccgoimporter  0.027s
ok    golang.org/x/tools/go/internal/gcimporter 38.745s
?     golang.org/x/tools/go/internal/packagesdriver [no test files]
ok    golang.org/x/tools/go/loader  12.621s
ok    golang.org/x/tools/go/packages  43.188s
?     golang.org/x/tools/go/packages/gopackages [no test files]
ok    golang.org/x/tools/go/packages/packagestest 0.048s
ok    golang.org/x/tools/go/pointer 5.293s
ok    golang.org/x/tools/go/ssa 10.332s
ok    golang.org/x/tools/go/ssa/interp  0.475s
ok    golang.org/x/tools/go/ssa/ssautil 5.455s
ok    golang.org/x/tools/go/types/objectpath  0.054s
ok    golang.org/x/tools/go/types/typeutil  1.195s
ok    golang.org/x/tools/go/vcs 0.025s
ok    golang.org/x/tools/godoc  0.686s
?     golang.org/x/tools/godoc/analysis [no test files]
?     golang.org/x/tools/godoc/golangorgenv [no test files]
ok    golang.org/x/tools/godoc/redirect 5.165s
ok    golang.org/x/tools/godoc/static 1.808s
?     golang.org/x/tools/godoc/util [no test files]
ok    golang.org/x/tools/godoc/vfs  0.008s
ok    golang.org/x/tools/godoc/vfs/gatefs 0.007s
?     golang.org/x/tools/godoc/vfs/httpfs [no test files]
ok    golang.org/x/tools/godoc/vfs/mapfs  0.031s
ok    golang.org/x/tools/godoc/vfs/zipfs  0.034s
?     golang.org/x/tools/imports  [no test files]
ok    golang.org/x/tools/internal/apidiff 0.619s
ok    golang.org/x/tools/internal/fastwalk  0.023s
ok    golang.org/x/tools/internal/gopathwalk  0.032s
ok    golang.org/x/tools/internal/imports 18.458s
ok    golang.org/x/tools/internal/jsonrpc2  0.003s
ok    golang.org/x/tools/internal/lsp 16.129s
?     golang.org/x/tools/internal/lsp/browser [no test files]
?     golang.org/x/tools/internal/lsp/cache [no test files]
ok    golang.org/x/tools/internal/lsp/cmd 5.617s
?     golang.org/x/tools/internal/lsp/debug [no test files]
ok    golang.org/x/tools/internal/lsp/diff  0.011s
?     golang.org/x/tools/internal/lsp/diff/difftest [no test files]
ok    golang.org/x/tools/internal/lsp/diff/myers  0.015s
ok    golang.org/x/tools/internal/lsp/fuzzy 0.025s
?     golang.org/x/tools/internal/lsp/protocol  [no test files]
ok    golang.org/x/tools/internal/lsp/snippet 0.017s
ok    golang.org/x/tools/internal/lsp/source  9.991s
?     golang.org/x/tools/internal/lsp/telemetry [no test files]
?     golang.org/x/tools/internal/lsp/tests [no test files]
ok    golang.org/x/tools/internal/memoize 0.018s
ok    golang.org/x/tools/internal/module  0.008s
ok    golang.org/x/tools/internal/semver  0.020s
ok    golang.org/x/tools/internal/span  0.029s
?     golang.org/x/tools/internal/telemetry [no test files]
?     golang.org/x/tools/internal/telemetry/export  [no test files]
ok    golang.org/x/tools/internal/telemetry/export/ocagent  0.010s
?     golang.org/x/tools/internal/telemetry/export/ocagent/wire [no test files]
?     golang.org/x/tools/internal/telemetry/export/prometheus [no test files]
?     golang.org/x/tools/internal/telemetry/log [no test files]
?     golang.org/x/tools/internal/telemetry/metric  [no test files]
?     golang.org/x/tools/internal/telemetry/stats [no test files]
?     golang.org/x/tools/internal/telemetry/tag [no test files]
?     golang.org/x/tools/internal/telemetry/trace [no test files]
?     golang.org/x/tools/internal/telemetry/unit  [no test files]
?     golang.org/x/tools/internal/testenv [no test files]
?     golang.org/x/tools/internal/tool  [no test files]
ok    golang.org/x/tools/internal/txtar 0.008s
?     golang.org/x/tools/internal/xcontext  [no test files]
?     golang.org/x/tools/playground [no test files]
ok    golang.org/x/tools/playground/socket  0.018s
ok    golang.org/x/tools/present  0.011s
ok    golang.org/x/tools/refactor/eg  3.491s
ok    golang.org/x/tools/refactor/importgraph 0.776s
ok    golang.org/x/tools/refactor/rename  0.092s
?     golang.org/x/tools/refactor/satisfy [no test files]
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/gopls/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rna876dd5" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=1.1s" "GO_STAGE0_DL_DELAY=300ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools/gopls

go: downloading github.com/sergi/go-diff v1.0.0
go: extracting github.com/sergi/go-diff v1.0.0
go: finding github.com/sergi/go-diff v1.0.0
?     golang.org/x/tools/gopls  [no test files]
ok    golang.org/x/tools/gopls/hooks  0.002s
linux-amd64 (Go 1.12.x) - tests ran in GOPATH mode, module boundaries ignored
  builder: linux-amd64
      rev: cf06b9aa81004a017e5c98422fce2fafd1f24921
 buildlet: http://10.240.0.106 GCE VM: buildlet-linux-stretch-rnf2b892e
  started: 2019-09-17 13:22:37.767269727 +0000 UTC m=+964.685287513
   status: still running

Events:
  2019-09-17T13:22:37Z checking_for_snapshot 
  2019-09-17T13:22:38Z finish_checking_for_snapshot after 18.1ms
  2019-09-17T13:22:38Z get_buildlet 
  2019-09-17T13:22:38Z awaiting_gce_quota 
  2019-09-17T13:22:38Z finish_awaiting_gce_quota after 0s
  2019-09-17T13:22:38Z create_gce_buildlet buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:22:38Z create_gce_instance buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:22:50Z finish_create_gce_instance after 11.7s; buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:22:50Z wait_buildlet_start buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:22:50Z got_instance_info waiting_for_buildlet...
  2019-09-17T13:23:30Z finish_wait_buildlet_start after 40.3s; buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:23:30Z finish_create_gce_buildlet after 52.3s; buildlet-linux-stretch-rnf2b892e
  2019-09-17T13:23:30Z finish_get_buildlet after 52.6s
  2019-09-17T13:23:30Z using_buildlet 10.240.0.106:80
  2019-09-17T13:23:30Z write_snapshot_tar 
  2019-09-17T13:23:36Z finish_write_snapshot_tar after 5.36s
  2019-09-17T13:23:36Z make_and_test 
  2019-09-17T13:23:36Z fetching_subrepo tools
  2019-09-17T13:23:36Z get_source 
  2019-09-17T13:23:36Z finish_get_source after 0s
  2019-09-17T13:23:36Z get_source 
  2019-09-17T13:23:36Z get_source_from_gitmirror 
  2019-09-17T13:23:37Z finish_get_source_from_gitmirror after 255ms
  2019-09-17T13:23:37Z finish_get_source after 319.5ms
  2019-09-17T13:23:37Z get_source 
  2019-09-17T13:23:37Z get_source_from_gitmirror 
  2019-09-17T13:23:37Z finish_get_source_from_gitmirror after 12.7ms
  2019-09-17T13:23:37Z finish_get_source after 160.9ms
  2019-09-17T13:23:37Z get_source 
  2019-09-17T13:23:37Z get_source_from_gitmirror 
  2019-09-17T13:23:37Z finish_get_source_from_gitmirror after 13.8ms
  2019-09-17T13:23:38Z finish_get_source after 129.7ms
  2019-09-17T13:23:38Z get_source 
  2019-09-17T13:23:38Z get_source_from_gitmirror 
  2019-09-17T13:23:39Z finish_get_source_from_gitmirror after 1.75s
  2019-09-17T13:23:40Z finish_get_source after 1.88s
  2019-09-17T13:23:40Z get_source 
  2019-09-17T13:23:40Z get_source_from_gitmirror 
  2019-09-17T13:23:40Z finish_get_source_from_gitmirror after 219.6ms
  2019-09-17T13:23:41Z finish_get_source after 384.6ms
  2019-09-17T13:23:41Z get_source 
  2019-09-17T13:23:41Z get_source_from_gitmirror 
  2019-09-17T13:23:41Z finish_get_source_from_gitmirror after 345.5ms
  2019-09-17T13:23:41Z finish_get_source after 480ms
  2019-09-17T13:23:41Z listing_subrepo_packages tools
  2019-09-17T13:23:42Z finish_listing_subrepo_packages after 224.8ms; tools
  2019-09-17T13:23:42Z running_subrepo_tests tools
   +4.9s (now)

Build log:
linux-amd64 at cf06b9aa81004a017e5c98422fce2fafd1f24921 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in GOPATH mode

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/benchmark/parse" "golang.org/x/tools/blog" "golang.org/x/tools/blog/atom" "golang.org/x/tools/cmd/auth/authtest" "golang.org/x/tools/cmd/auth/cookieauth" "golang.org/x/tools/cmd/auth/gitauth" "golang.org/x/tools/cmd/auth/netrcauth" "golang.org/x/tools/cmd/benchcmp" "golang.org/x/tools/cmd/bundle" "golang.org/x/tools/cmd/callgraph" "golang.org/x/tools/cmd/compilebench" "golang.org/x/tools/cmd/cover" "golang.org/x/tools/cmd/digraph" "golang.org/x/tools/cmd/eg" "golang.org/x/tools/cmd/fiximports" "golang.org/x/tools/cmd/getgo" "golang.org/x/tools/cmd/getgo/server" "golang.org/x/tools/cmd/go-contrib-init" "golang.org/x/tools/cmd/godex" "golang.org/x/tools/cmd/godoc" "golang.org/x/tools/cmd/goimports" "golang.org/x/tools/cmd/gomvpkg" "golang.org/x/tools/cmd/gopls" "golang.org/x/tools/cmd/gorename" "golang.org/x/tools/cmd/gotype" "golang.org/x/tools/cmd/goyacc" "golang.org/x/tools/cmd/guru" "golang.org/x/tools/cmd/guru/serial" "golang.org/x/tools/cmd/html2article" "golang.org/x/tools/cmd/present" "golang.org/x/tools/cmd/splitdwarf" "golang.org/x/tools/cmd/splitdwarf/internal/macho" "golang.org/x/tools/cmd/ssadump" "golang.org/x/tools/cmd/stress" "golang.org/x/tools/cmd/stringer" "golang.org/x/tools/cmd/toolstash" "golang.org/x/tools/container/intsets" "golang.org/x/tools/cover" "golang.org/x/tools/go/analysis" "golang.org/x/tools/go/analysis/analysistest" "golang.org/x/tools/go/analysis/internal/analysisflags" "golang.org/x/tools/go/analysis/internal/checker" "golang.org/x/tools/go/analysis/internal/facts" "golang.org/x/tools/go/analysis/multichecker" "golang.org/x/tools/go/analysis/passes/asmdecl" "golang.org/x/tools/go/analysis/passes/assign" "golang.org/x/tools/go/analysis/passes/atomic" "golang.org/x/tools/go/analysis/passes/atomicalign" "golang.org/x/tools/go/analysis/passes/bools" "golang.org/x/tools/go/analysis/passes/buildssa" "golang.org/x/tools/go/analysis/passes/buildtag" "golang.org/x/tools/go/analysis/passes/cgocall" "golang.org/x/tools/go/analysis/passes/composite" "golang.org/x/tools/go/analysis/passes/copylock" "golang.org/x/tools/go/analysis/passes/ctrlflow" "golang.org/x/tools/go/analysis/passes/deepequalerrors" "golang.org/x/tools/go/analysis/passes/errorsas" "golang.org/x/tools/go/analysis/passes/findcall" "golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall" "golang.org/x/tools/go/analysis/passes/httpresponse" "golang.org/x/tools/go/analysis/passes/inspect" "golang.org/x/tools/go/analysis/passes/internal/analysisutil" "golang.org/x/tools/go/analysis/passes/loopclosure" "golang.org/x/tools/go/analysis/passes/lostcancel" "golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel" "golang.org/x/tools/go/analysis/passes/nilfunc" "golang.org/x/tools/go/analysis/passes/nilness" "golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness" "golang.org/x/tools/go/analysis/passes/pkgfact" "golang.org/x/tools/go/analysis/passes/printf" "golang.org/x/tools/go/analysis/passes/shadow" "golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow" "golang.org/x/tools/go/analysis/passes/shift" "golang.org/x/tools/go/analysis/passes/stdmethods" "golang.org/x/tools/go/analysis/passes/structtag" "golang.org/x/tools/go/analysis/passes/tests" "golang.org/x/tools/go/analysis/passes/unmarshal" "golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal" "golang.org/x/tools/go/analysis/passes/unreachable" "golang.org/x/tools/go/analysis/passes/unsafeptr" "golang.org/x/tools/go/analysis/passes/unusedresult" "golang.org/x/tools/go/analysis/singlechecker" "golang.org/x/tools/go/analysis/unitchecker" "golang.org/x/tools/go/ast/astutil" "golang.org/x/tools/go/ast/inspector" "golang.org/x/tools/go/buildutil" "golang.org/x/tools/go/callgraph" "golang.org/x/tools/go/callgraph/cha" "golang.org/x/tools/go/callgraph/rta" "golang.org/x/tools/go/callgraph/static" "golang.org/x/tools/go/cfg" "golang.org/x/tools/go/expect" "golang.org/x/tools/go/gccgoexportdata" "golang.org/x/tools/go/gcexportdata" "golang.org/x/tools/go/internal/cgo" "golang.org/x/tools/go/internal/gccgoimporter" "golang.org/x/tools/go/internal/gcimporter" "golang.org/x/tools/go/internal/packagesdriver" "golang.org/x/tools/go/loader" "golang.org/x/tools/go/packages" "golang.org/x/tools/go/packages/gopackages" "golang.org/x/tools/go/packages/packagestest" "golang.org/x/tools/go/pointer" "golang.org/x/tools/go/ssa" "golang.org/x/tools/go/ssa/interp" "golang.org/x/tools/go/ssa/ssautil" "golang.org/x/tools/go/types/objectpath" "golang.org/x/tools/go/types/typeutil" "golang.org/x/tools/go/vcs" "golang.org/x/tools/godoc" "golang.org/x/tools/godoc/analysis" "golang.org/x/tools/godoc/golangorgenv" "golang.org/x/tools/godoc/redirect" "golang.org/x/tools/godoc/static" "golang.org/x/tools/godoc/util" "golang.org/x/tools/godoc/vfs" "golang.org/x/tools/godoc/vfs/gatefs" "golang.org/x/tools/godoc/vfs/httpfs" "golang.org/x/tools/godoc/vfs/mapfs" "golang.org/x/tools/godoc/vfs/zipfs" "golang.org/x/tools/imports" "golang.org/x/tools/internal/apidiff" "golang.org/x/tools/internal/fastwalk" "golang.org/x/tools/internal/gopathwalk" "golang.org/x/tools/internal/imports" "golang.org/x/tools/internal/jsonrpc2" "golang.org/x/tools/internal/lsp" "golang.org/x/tools/internal/lsp/browser" "golang.org/x/tools/internal/lsp/cache" "golang.org/x/tools/internal/lsp/cmd" "golang.org/x/tools/internal/lsp/debug" "golang.org/x/tools/internal/lsp/diff" "golang.org/x/tools/internal/lsp/diff/difftest" "golang.org/x/tools/internal/lsp/diff/myers" "golang.org/x/tools/internal/lsp/fuzzy" "golang.org/x/tools/internal/lsp/protocol" "golang.org/x/tools/internal/lsp/snippet" "golang.org/x/tools/internal/lsp/source" "golang.org/x/tools/internal/lsp/telemetry" "golang.org/x/tools/internal/lsp/tests" "golang.org/x/tools/internal/memoize" "golang.org/x/tools/internal/module" "golang.org/x/tools/internal/semver" "golang.org/x/tools/internal/span" "golang.org/x/tools/internal/telemetry" "golang.org/x/tools/internal/telemetry/export" "golang.org/x/tools/internal/telemetry/export/ocagent" "golang.org/x/tools/internal/telemetry/export/ocagent/wire" "golang.org/x/tools/internal/telemetry/export/prometheus" "golang.org/x/tools/internal/telemetry/log" "golang.org/x/tools/internal/telemetry/metric" "golang.org/x/tools/internal/telemetry/stats" "golang.org/x/tools/internal/telemetry/tag" "golang.org/x/tools/internal/telemetry/trace" "golang.org/x/tools/internal/telemetry/unit" "golang.org/x/tools/internal/testenv" "golang.org/x/tools/internal/tool" "golang.org/x/tools/internal/txtar" "golang.org/x/tools/internal/xcontext" "golang.org/x/tools/playground" "golang.org/x/tools/playground/socket" "golang.org/x/tools/present" "golang.org/x/tools/refactor/eg" "golang.org/x/tools/refactor/importgraph" "golang.org/x/tools/refactor/rename" "golang.org/x/tools/refactor/satisfy"] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rnf2b892e" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=2.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

ok    golang.org/x/tools/benchmark/parse  0.006s
ok    golang.org/x/tools/blog 0.010s
?     golang.org/x/tools/blog/atom  [no test files]
?     golang.org/x/tools/cmd/auth/authtest  [no test files]
?     golang.org/x/tools/cmd/auth/cookieauth  [no test files]
?     golang.org/x/tools/cmd/auth/gitauth [no test files]
?     golang.org/x/tools/cmd/auth/netrcauth [no test files]
ok    golang.org/x/tools/cmd/benchcmp 0.013s
ok    golang.org/x/tools/cmd/bundle 0.013s
ok    golang.org/x/tools/cmd/callgraph  7.563s
?     golang.org/x/tools/cmd/compilebench [no test files]
ok    golang.org/x/tools/cmd/cover  1.964s
ok    golang.org/x/tools/cmd/digraph  0.040s
?     golang.org/x/tools/cmd/eg [no test files]
ok    golang.org/x/tools/cmd/fiximports 8.884s
ok    golang.org/x/tools/cmd/getgo  0.043s
?     golang.org/x/tools/cmd/getgo/server [no test files]
ok    golang.org/x/tools/cmd/go-contrib-init  0.025s
?     golang.org/x/tools/cmd/godex  [no test files]
ok    golang.org/x/tools/cmd/godoc  12.586s
?     golang.org/x/tools/cmd/goimports  [no test files]
?     golang.org/x/tools/cmd/gomvpkg  [no test files]
?     golang.org/x/tools/cmd/gopls  [no test files]
ok    golang.org/x/tools/cmd/gorename 9.237s
?     golang.org/x/tools/cmd/gotype [no test files]
?     golang.org/x/tools/cmd/goyacc [no test files]
ok    golang.org/x/tools/cmd/guru 0.008s
?     golang.org/x/tools/cmd/guru/serial  [no test files]
?     golang.org/x/tools/cmd/html2article [no test files]
?     golang.org/x/tools/cmd/present  [no test files]
?     golang.org/x/tools/cmd/splitdwarf [no test files]
ok    golang.org/x/tools/cmd/splitdwarf/internal/macho  0.004s
?     golang.org/x/tools/cmd/ssadump  [no test files]
?     golang.org/x/tools/cmd/stress [no test files]
ok    golang.org/x/tools/cmd/stringer 36.038s
?     golang.org/x/tools/cmd/toolstash  [no test files]
ok    golang.org/x/tools/container/intsets  0.764s
?     golang.org/x/tools/cover  [no test files]
?     golang.org/x/tools/go/analysis  [no test files]
ok    golang.org/x/tools/go/analysis/analysistest 0.106s
ok    golang.org/x/tools/go/analysis/internal/analysisflags 0.094s
ok    golang.org/x/tools/go/analysis/internal/checker 0.144s
ok    golang.org/x/tools/go/analysis/internal/facts 0.223s
ok    golang.org/x/tools/go/analysis/multichecker 19.643s
ok    golang.org/x/tools/go/analysis/passes/asmdecl 0.768s
ok    golang.org/x/tools/go/analysis/passes/assign  1.440s
ok    golang.org/x/tools/go/analysis/passes/atomic  0.124s
ok    golang.org/x/tools/go/analysis/passes/atomicalign 0.144s
ok    golang.org/x/tools/go/analysis/passes/bools 1.724s
ok    golang.org/x/tools/go/analysis/passes/buildssa  0.123s
ok    golang.org/x/tools/go/analysis/passes/buildtag  0.072s
ok    golang.org/x/tools/go/analysis/passes/cgocall 3.191s
ok    golang.org/x/tools/go/analysis/passes/composite 2.614s
ok    golang.org/x/tools/go/analysis/passes/copylock  1.123s
ok    golang.org/x/tools/go/analysis/passes/ctrlflow  3.304s
ok    golang.org/x/tools/go/analysis/passes/deepequalerrors 2.275s
?     golang.org/x/tools/go/analysis/passes/errorsas  [no test files]
ok    golang.org/x/tools/go/analysis/passes/findcall  0.288s
?     golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
ok    golang.org/x/tools/go/analysis/passes/httpresponse  4.207s
?     golang.org/x/tools/go/analysis/passes/inspect [no test files]
?     golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
ok    golang.org/x/tools/go/analysis/passes/loopclosure 0.080s
ok    golang.org/x/tools/go/analysis/passes/lostcancel  2.556s
?     golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
ok    golang.org/x/tools/go/analysis/passes/nilfunc 0.046s
ok    golang.org/x/tools/go/analysis/passes/nilness 0.121s
?     golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
ok    golang.org/x/tools/go/analysis/passes/pkgfact 0.060s
ok    golang.org/x/tools/go/analysis/passes/printf  2.385s
ok    golang.org/x/tools/go/analysis/passes/shadow  1.462s
?     golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
ok    golang.org/x/tools/go/analysis/passes/shift 0.105s
ok    golang.org/x/tools/go/analysis/passes/stdmethods  5.149s
ok    golang.org/x/tools/go/analysis/passes/structtag 2.156s
ok    golang.org/x/tools/go/analysis/passes/tests 2.678s
ok    golang.org/x/tools/go/analysis/passes/unmarshal 2.382s
?     golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
ok    golang.org/x/tools/go/analysis/passes/unreachable 0.111s
ok    golang.org/x/tools/go/analysis/passes/unsafeptr 1.795s
ok    golang.org/x/tools/go/analysis/passes/unusedresult  2.250s
?     golang.org/x/tools/go/analysis/singlechecker  [no test files]
ok    golang.org/x/tools/go/analysis/unitchecker  2.951s
ok    golang.org/x/tools/go/ast/astutil 0.030s
ok    golang.org/x/tools/go/ast/inspector 0.155s
ok    golang.org/x/tools/go/buildutil 0.066s
?     golang.org/x/tools/go/callgraph [no test files]
ok    golang.org/x/tools/go/callgraph/cha 0.011s
ok    golang.org/x/tools/go/callgraph/rta 0.020s
ok    golang.org/x/tools/go/callgraph/static  0.005s
ok    golang.org/x/tools/go/cfg 0.003s
ok    golang.org/x/tools/go/expect  0.018s
ok    golang.org/x/tools/go/gccgoexportdata 0.032s
ok    golang.org/x/tools/go/gcexportdata  0.042s
?     golang.org/x/tools/go/internal/cgo  [no test files]
ok    golang.org/x/tools/go/internal/gccgoimporter  0.023s
ok    golang.org/x/tools/go/internal/gcimporter 40.935s
?     golang.org/x/tools/go/internal/packagesdriver [no test files]
ok    golang.org/x/tools/go/loader  7.588s
ok    golang.org/x/tools/go/packages  41.389s
?     golang.org/x/tools/go/packages/gopackages [no test files]
ok    golang.org/x/tools/go/packages/packagestest 0.076s
ok    golang.org/x/tools/go/pointer 7.558s
ok    golang.org/x/tools/go/ssa 5.321s
ok    golang.org/x/tools/go/ssa/interp  0.515s
ok    golang.org/x/tools/go/ssa/ssautil 3.464s
ok    golang.org/x/tools/go/types/objectpath  0.013s
ok    golang.org/x/tools/go/types/typeutil  0.880s
ok    golang.org/x/tools/go/vcs 0.014s
ok    golang.org/x/tools/godoc  0.487s
?     golang.org/x/tools/godoc/analysis [no test files]
?     golang.org/x/tools/godoc/golangorgenv [no test files]
ok    golang.org/x/tools/godoc/redirect 5.134s
ok    golang.org/x/tools/godoc/static 2.430s
?     golang.org/x/tools/godoc/util [no test files]
ok    golang.org/x/tools/godoc/vfs  0.029s
ok    golang.org/x/tools/godoc/vfs/gatefs 0.052s
?     golang.org/x/tools/godoc/vfs/httpfs [no test files]
ok    golang.org/x/tools/godoc/vfs/mapfs  0.032s
ok    golang.org/x/tools/godoc/vfs/zipfs  0.013s
?     golang.org/x/tools/imports  [no test files]
ok    golang.org/x/tools/internal/apidiff 0.814s
ok    golang.org/x/tools/internal/fastwalk  0.020s
ok    golang.org/x/tools/internal/gopathwalk  0.023s
ok    golang.org/x/tools/internal/imports 29.921s
ok    golang.org/x/tools/internal/jsonrpc2  0.029s
ok    golang.org/x/tools/internal/lsp 17.411s
?     golang.org/x/tools/internal/lsp/browser [no test files]
?     golang.org/x/tools/internal/lsp/cache [no test files]
ok    golang.org/x/tools/internal/lsp/cmd 5.567s
?     golang.org/x/tools/internal/lsp/debug [no test files]
ok    golang.org/x/tools/internal/lsp/diff  0.006s
?     golang.org/x/tools/internal/lsp/diff/difftest [no test files]
ok    golang.org/x/tools/internal/lsp/diff/myers  0.016s
ok    golang.org/x/tools/internal/lsp/fuzzy 0.026s
?     golang.org/x/tools/internal/lsp/protocol  [no test files]
ok    golang.org/x/tools/internal/lsp/snippet 0.013s
ok    golang.org/x/tools/internal/lsp/source  12.735s
?     golang.org/x/tools/internal/lsp/telemetry [no test files]
?     golang.org/x/tools/internal/lsp/tests [no test files]
ok    golang.org/x/tools/internal/memoize 0.021s
ok    golang.org/x/tools/internal/module  0.005s
ok    golang.org/x/tools/internal/semver  0.011s
ok    golang.org/x/tools/internal/span  0.006s
?     golang.org/x/tools/internal/telemetry [no test files]
?     golang.org/x/tools/internal/telemetry/export  [no test files]
ok    golang.org/x/tools/internal/telemetry/export/ocagent  0.012s
?     golang.org/x/tools/internal/telemetry/export/ocagent/wire [no test files]
?     golang.org/x/tools/internal/telemetry/export/prometheus [no test files]
?     golang.org/x/tools/internal/telemetry/log [no test files]
?     golang.org/x/tools/internal/telemetry/metric  [no test files]
?     golang.org/x/tools/internal/telemetry/stats [no test files]
?     golang.org/x/tools/internal/telemetry/tag [no test files]
?     golang.org/x/tools/internal/telemetry/trace [no test files]
?     golang.org/x/tools/internal/telemetry/unit  [no test files]
?     golang.org/x/tools/internal/testenv [no test files]
?     golang.org/x/tools/internal/tool  [no test files]
ok    golang.org/x/tools/internal/txtar 0.006s
?     golang.org/x/tools/internal/xcontext  [no test files]
?     golang.org/x/tools/playground [no test files]
ok    golang.org/x/tools/playground/socket  0.027s
ok    golang.org/x/tools/present  0.017s
ok    golang.org/x/tools/refactor/eg  3.280s
ok    golang.org/x/tools/refactor/importgraph 0.944s
ok    golang.org/x/tools/refactor/rename  0.075s
?     golang.org/x/tools/refactor/satisfy [no test files]

Search the build logs for ":: Running" to find go test invocations for each module.

And here's the correctly failing trybot run for CL 182584. It has links to its build logs.

@dmitshur
Copy link
Contributor Author

I initially posted the above comment in the wrong issue at #34247 (comment). I've moved it here, but that issue has some additional discussion. /cc @bcmills

@bcmills
Copy link
Contributor

bcmills commented Sep 17, 2019

Filed #34352 as followup.

@gopherbot
Copy link

Change https://golang.org/cl/196034 mentions this issue: errors/fmt: disable failing TestPanics test on builders

gopherbot pushed a commit to golang/exp that referenced this issue Sep 18, 2019
Now that golang/go#32528 has been resolved and inner modules
are being tested too, disable this failing test until it can
be fixed. We don't want to distract people trying to do other
work in x/exp with trybot failures.

Updates golang/go#30622

Change-Id: Ia6f9c2b64100c7a9056a013453caf6e6c76177ad
Reviewed-on: https://go-review.googlesource.com/c/exp/+/196034
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
It will be necessary to know whether the current environment
and configuration has resulted in module mode or GOPATH mode
being selected. Do this dynamically by invoking 'go env GOMOD',
since the outcome depends on the version of Go and its default
GO111MODULE behavior, as well as whether a go.mod file is added
to the subrepo, and what environment overrides were applied by
coordinator via the BuildConfig.ModulesEnv method.

This requires the repository being tested to be available on disk,
so move the step of fetching it to happen earlier.

For now, this change only detects and logs the build mode.
Future changes will use this information further.

Updates golang/go#34190
Updates golang/go#32528
Updates golang/go#30233

Change-Id: I641becaaae5b6cfad22961d8864a877241e61cd3
Reviewed-on: https://go-review.googlesource.com/c/build/+/194277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
Previously, we were invoking a single 'go test' run at the repository
root with the import path pattern of 'golang.org/x/{repo}/...'. This
pattern does not match packages that are located in nested modules
in the repository.

Look for go.mod files in all subdirectories of the repository to find
all inner modules. Then, run 'go test' inside each module root, thus
testing all packages in all modules of the repository. If one of the
test invocations fails, keep testing others, and report all failures.

When looking for inner modules, consider only those that have module
path that would not be ignored by the go tool and aren't vendored.
This way, go.mod files inside testdata directories aren't treated as
if they're proper modules.

This is being done only when the tests are running in module mode,
since module boundaries don't exist in GOPATH mode.

Fixes golang/go#32528

Change-Id: I9f8558982885c9955d3b34127c80c485d713b380
Reviewed-on: https://go-review.googlesource.com/c/build/+/194559
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants