Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/env_write failed #32503

Closed
YoshikiShibata opened this issue Jun 9, 2019 · 7 comments
Closed

cmd/go: TestScript/env_write failed #32503

YoshikiShibata opened this issue Jun 9, 2019 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@YoshikiShibata
Copy link

What version of Go are you using (go version)?

$ go version
go version devel +13f179b9c8 Fri Jun 7 23:25:54 2019 +0000 darwin/amd64

Does this issue reproduce with the latest release?

N/A

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yoshiki/Library/Caches/go-build"
GOENV="/Users/yoshiki/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/yoshiki/gocode:/Users/yoshiki/exercises/gpl:/Users/yoshiki/oak"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/yoshiki/tools/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/yoshiki/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/yoshiki/tools/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r3/f30_9n8958j4ndrjyl1k7mp40000gn/T/go-build081806595=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +13f179b9c8 Fri Jun 7 23:25:54 2019 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +13f179b9c8 Fri Jun 7 23:25:54 2019 +0000
uname -v: Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.14.5
BuildVersion:	18F132
lldb --version: lldb-1001.0.13.3
  Swift-5.0

What did you do?

What did you expect to see?

I tried to rebuild the latest tip with all.bash. I expected the all.bash didn't fail.

What did you see instead?

ok  	cmd/fix	0.032s
go test proxy running at GOPROXY=http://127.0.0.1:57012/mod
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/env_write (0.04s)
        script_test.go:192: 
            # go env should default to the right places (0.034s)
            > env AppData=$HOME/windowsappdata
            > env home=$HOME/plan9home
            > go env GOENV
            [stdout]
            /no-home/Library/Application Support/go/env
            > [aix] stdout $HOME/.config/go/env
            > [darwin] stdout '$HOME/Library/Application Support/go/env'
            FAIL: testdata/script/env_write.txt:8: no match for `(?m)$HOME/Library/Application Support/go/env` found in stdout
            
FAIL
FAIL	cmd/go	131.354s
@agnivade
Copy link
Contributor

agnivade commented Jun 9, 2019

@mvdan

@agnivade agnivade added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin labels Jun 9, 2019
@agnivade agnivade added this to the Go1.13 milestone Jun 9, 2019
@av86743
Copy link

av86743 commented Jun 9, 2019

Issue #32475
CL https://golang.org/cl/181177
Change was not validated on target platform.

@mvdan
Copy link
Member

mvdan commented Jun 9, 2019

You can see similar failures on https://build.golang.org/. This is my bad; I didn't know that there were no mac machines in the trybot list.

Initially it was a syntax error, fixed in https://go-review.googlesource.com/c/go/+/181278. But that wasn't the end of the story.

I don't have a Mac to test this with unfortunately, and I've already made two mistakes when guessing :)

@mvdan
Copy link
Member

mvdan commented Jun 9, 2019

FYI @andybons @dmitshur for the first beta (and because I think either/both of you run on macs)

@av86743
Copy link

av86743 commented Jun 9, 2019

@mvdan

I don't have a Mac to test this with...

You are joking, right?

@mvdan
Copy link
Member

mvdan commented Jun 9, 2019

Why would I be joking?

@dmitshur dmitshur self-assigned this Jun 9, 2019
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/181418 mentions this issue: cmd/go: fix syntax mistake in a testscript file, take 2

@golang golang locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

6 participants