x/tools/gopls: dependency leaks across modules #32499

fhs · 2019-06-08T18:05:36Z

What version of Go are you using (`go version`)?

$ go version
go version devel +ce656af9b5 Sun Jun 2 19:28:21 2019 +0000 linux/amd64
$ gopls version
golang.org/x/tools/cmd/gopls
    golang.org/x/tools@v0.0.0-20190608022120-eacb66d2a7c3 h1:sU3tSV6wDhWsvf9NjL0FzRjgAmYnQL5NEhdmcN16UEg=

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/fhs/.cache/go-build"
GOENV="/home/fhs/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/fhs/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/big/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/big/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build362340636=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Load more than one module in gopls. Each module has its own workspace folder, passed in the workspaceFolders initialization option.

What did you expect to see?

No changes to go.mod file for any of the modules.

What did you see instead?

I have 2 files open in my editor, where the two files are from two different modules. When I start the LSP client, it sends a DidOpen notification for those two files. Depending on which notification was sent first, the dependencies of one module gets added to the go.mod file of the other module. Example:

DidOpen file:///path/to/mod1/foo.go
DidOpen file:///path/to/mod2/foo.go
# mod2's go.mod file will get mod1 dependencies added

Similarly, for 3 modules:

DidOpen file:///path/to/mod1/foo.go
DidOpen file:///path/to/mod2/foo.go
DidOpen file:///path/to/mod3/foo.go
# mod2's go.mod file will get mod1 dependencies added
# mod3's go.mod file will get mod1 and mod2 dependencies added

The text was updated successfully, but these errors were encountered:

stamblerre · 2019-08-08T22:14:21Z

I am not able to reproduce this in VSCode. What LSP client are you using?

fhs · 2019-08-09T04:15:28Z

I'm using acme-lsp. I'm also unsuccessful at reproducing it in VSCode.

With latest gopls from master branch, it seems I need to do few go-to-defenitions before I can reproduce the issue. Here is my gopls trace output: gopls.log. I'm not sure what exactly I'm doing different compared to VSCode. If you spot anything from the log it'll be helpful.

stamblerre · 2019-08-09T21:17:05Z

Based on the fact that this can't be reproduced in VSCode, I'm inclined to believe that it could be a bug with the Acme client.

The only thing that can edit the go.mod files in gopls would be the calls to go/packages.Load or import organization. It seems like you are not using the import organization feature, based on your logs, so my guess is that it would be go/packages. The output of go/packages is logged here. If you would like to investigate this further, perhaps you could determine exactly which call to packages.Load causes the change. You could also log additional information, like the contents of the packages.Config.

itchyny · 2019-08-10T00:27:42Z

I believe this is caused by go list command in determineRootDirs, where PWD seems not to be correct. I still cannot find the root cause, but the PWD of go list on didOpen in new project is in the root directory of the previous project. I'm debugging the bug with fatih/vim-go#2383 (comment).

debug log

sent: Content-Length: 544
�
�{"method":"initialize","jsonrpc":"2.0","id":1,"params":{"rootUri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a","capabilities":{"workspace":{"workspaceFolders":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":true}},"textDocument":{"hover":{"contentFormat":["plaintext"]}}},"processId":89698,"workspaceFolders":[{"uri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a","name":"/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a"}]}}
received: Content-Length: 292
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"71.561897ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-m" "-json" "all", stderr: \u003c\u003c\u003e\u003e\n"}}
received: Content-Length: 386
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"74.188355ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "builtin", stderr: \u003c\u003c\u003e\u003e\n"}}
received: Content-Length: 616
�
�{"jsonrpc":"2.0","result":{"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"hoverProvider":true,"completionProvider":{"triggerCharacters":["."]},"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"documentFormattingProvider":true,"renameProvider":true,"documentLinkProvider":{},"typeDefinitionProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"custom":null},"id":1}
sent: Content-Length: 52
�
�{"method":"initialized","jsonrpc":"2.0","params":{}}
sent: Content-Length: 290
�
�{"method":"textDocument/didOpen","jsonrpc":"2.0","params":{"textDocument":{"uri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a/main.go","languageId":"go","text":"package main\n\nimport "golang.org/x/xerrors"\n\nfunc main() {\n xerrors.New("")\n}\n"}}}
received: Content-Length: 268
�
�{"jsonrpc":"2.0","method":"client/registerCapability","params":{"registrations":[{"id":"workspace/didChangeConfiguration","method":"workspace/didChangeConfiguration"},{"id":"workspace/didChangeWorkspaceFolders","method":"workspace/didChangeWorkspaceFolders"}]},"id":1}
sent: Content-Length: 38
�
�{"id":1,"jsonrpc":"2.0","result":null}
stderr: 2019/08/10 08:31:49 Debug serving
received: Content-Length: 370
�
�{"jsonrpc":"2.0","method":"workspace/configuration","params":{"items":[{"scopeUri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a","section":"gopls"},{"scopeUri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a","section":"/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a"}]},"id":2}
sent: Content-Length: 131
�
�{"id":2,"jsonrpc":"2.0","result":[{"buildFlags":[],"hoverKind":"NoDocumentation"},{"buildFlags":[],"hoverKind":"NoDocumentation"}]}
stderr: Port = 62655
received: Content-Length: 1278
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Build info\n----------\ngolang.org/x/tools/cmd/gopls v0.1.3-cmd.gopls\n golang.org/x/tools@(devel)\n golang.org/x/sync@v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=\n golang.org/x/xerrors@v0.0.0-20190717185122-a985d3407aa7 h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=\n\nGo info\n-------\ngo version go1.12.7 darwin/amd64\n\nGOARCH="amd64"\nGOBIN=""\nGOCACHE="/Users/itchyny/Library/Caches/go-build"\nGOEXE=""\nGOFLAGS=""\nGOHOSTARCH="amd64"\nGOHOSTOS="darwin"\nGOOS="darwin"\nGOPATH="/Users/itchyny/.go"\nGOPROXY=""\nGORACE=""\nGOROOT="/usr/local/Cellar/go/1.12.7/libexec"\nGOTMPDIR=""\nGOTOOLDIR="/usr/local/Cellar/go/1.12.7/libexec/pkg/tool/darwin_amd64"\nGCCGO="gccgo"\nCC="clang"\nCXX="clang++"\nCGO_ENABLED="1"\nGOMOD="/dev/null"\nCGO_CFLAGS="-g -O2"\nCGO_CPPFLAGS=""\nCGO_CXXFLAGS="-g -O2"\nCGO_FFLAGS="-g -O2"\nCGO_LDFLAGS="-g -O2"\nPKG_CONFIG="pkg-config"\nGOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/go-build843905483=/tmp/go-build -gno-record-gcc-switches -fno-common"\n"}}
received: Content-Length: 292
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"37.503774ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-m" "-json" "all", stderr: \u003c\u003c\u003e\u003e\n"}}
received: Content-Length: 451
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"228.806934ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a", stderr: \u003c\u003c\u003e\u003e\n"}}
received: Content-Length: 203
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"go/packages.Load\n\tpackage = a\n\tfiles = [/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a/main.go]"}}
received: Content-Length: 111
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"go/packages.Load\n\tpackages = 1"}}
received: Content-Length: 183
�
�{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a/main.go","diagnostics":[]}}

sent: Content-Length: 309
�
�{"method":"textDocument/didOpen","jsonrpc":"2.0","params":{"textDocument":{"uri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/b/main.go","languageId":"go","text":"package main\n\nimport "golang.org/x/sys/unix"\n\nfunc main() {\n unix.SysctlRaw("kern.boottime")\n}\n\n"}}}
received: Content-Length: 293
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"107.029404ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-m" "-json" "all", stderr: \u003c\u003c\u003e\u003e\n"}}
received: Content-Length: 495
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"64.85989ms for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/b", stderr: \u003c\u003cgo: directory ../b outside available modules\n\u003e\u003e\n"}}
received: Content-Length: 538
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"1.678329771s for GOROOT= GOPATH=/Users/itchyny/.go GO111MODULE=on PWD=/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/a go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/b/main.go", stderr: \u003c\u003cgo: finding golang.org/x/sys/unix latest\ngo: finding golang.org/x/sys latest\n\u003e\u003e\n"}}
received: Content-Length: 224
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"go/packages.Load\n\tpackage = command-line-arguments\n\tfiles = [/private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/b/main.go]"}}
received: Content-Length: 111
�
�{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"go/packages.Load\n\tpackages = 1"}}
received: Content-Length: 183
�
�{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///private/var/folders/mg/nqgjy_l53n15b3_dfrjw9_600000gn/T/tmp.FiVYTGf3/b/main.go","diagnostics":[]}}

fhs · 2019-08-10T01:00:34Z

I've added logging of packages.Config. I noticed that it's using Overlay in acme but not in VSCode. In particular, this one looks suspecious:

[Trace - 8:22:19 PM] Received notification 'window/logMessage' in 0ms.
Params: {"type":3,"message":"go/packages.Load\n\tconfig = \u0026packages.Config{Mode:543, Context:context.Context(nil), Logf:(func(string, ...interface {}))(0x971600), 
Dir:\"/home/fhs/go/src/github.com/fhs/acme-lsp\", Env:[]string{...}, BuildFlags:[]string(nil), Fset:(*token.FileSet)(0xc000195a40), ParseFile:(func(*token.FileSet, string, []uint8) (*ast.File, error))(0x9715b0), Tests:true, 
Overlay:map[string][]uint8{
\"/home/fhs/go/src/github.com/fhs/acme-lsp/cmd/acme-lsp/main.go\":[]uint8{...}, 
\"/home/fhs/go/src/github.com/rjkroege/edwood/acme.go\":[]uint8{...}}}"}

Can Overlay have files from two different modules?

Later on, this go list command modifies the go.mod file (adds edwood as an indirect dependency to acme-lsp):

[Trace - 8:22:19 PM] Received notification 'window/logMessage' in 0ms.
Params: {"type":3,"message":"512.764166ms for GOROOT= GOPATH=/home/fhs/go GO111MODULE=on PWD=/home/fhs/go/src/github.com/fhs/acme-lsp go \"list\" \"-e\" \"-json\" \"-compiled=true\" \"-test=true\" \"-export=false\" \"-deps=true\" \"-find=false\" \"--\" \"net/http/pprof\" \"github.com/rjkroege/edwood/internal/draw\" \"github.com/rjkroege/edwood/internal/dumpfile\" \"github.com/rjkroege/edwood/internal/frame\" \"net/http\" \"os/signal\", stderr: \u003c\u003c\u003e\u003e\n"}

stamblerre · 2019-08-12T15:14:08Z

Thank you for digging into this further! Overlays can have files from different modules, and the extra go list calls for overlays are likely responsible here. The solution to this will probably be making sure that overlays are built per-view and not per-session here.

gopherbot · 2019-08-12T16:35:52Z

Change https://golang.org/cl/189938 mentions this issue: internal/lsp: build overlays per-view rather than per-session

stamblerre · 2019-08-12T16:37:04Z

@fhs: Can you download this patch and confirm that this fixes the issue for you? You can download it by clicking the ... in the top-right corner and selecting "Download patch".

fhs · 2019-08-12T18:11:55Z

@stamblerre I can no longer reproduce the issue with the patch. Thanks for the fix!

stamblerre · 2019-08-12T22:48:27Z

Glad to hear that we've at least identified the fix. Unfortunately, after some discussion with @ianthehat, we concluded that my patch was a hack that we can't actually submit to gopls. (It will cause breakages in $GOPATH mode, for instance.)

The real fix needs to be implemented in go/packages. I will write up a test case to reproduce the issue so that @matloob can add a proper fix. Sorry about the delay, but hopefully you can use the patch for now.

gopherbot · 2019-08-12T23:22:57Z

Change https://golang.org/cl/190037 mentions this issue: go/packages: add a test case for golang/go#32499

Updates golang/go#32499 Change-Id: Ib9daf7c0dc8c6052f84230e54e181ab60166349b Reviewed-on: https://go-review.googlesource.com/c/tools/+/190037 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot · 2019-08-13T21:35:21Z

Change https://golang.org/cl/190179 mentions this issue: go/packages: set -mod=readonly when processing overlays in module mode

* internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

stamblerre · 2019-08-14T18:03:21Z

@fhs: Please let me know if you are still seeing this issue.

fhs · 2019-08-14T18:17:51Z

@stamblerre I'm no longer seeing the issue with the -mod=readonly change. Thanks everyone who contributed to the fix!

* go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp: turn on completion documentation by default adb45749 * internal/lsp: fix declarations in references df305b82 * internal/lsp: fix deadlock in type-checking 70bfb602 * go/ssa/interp: skip recover2 testcase 958971f5 * gopls: update x/tools version a4fdb3a8 * internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp: avoid using the importer's context as much as possible 2a03e9e3 * internal/lsp: turn on completion documentation by default adb45749 * internal/lsp: fix declarations in references df305b82 * internal/lsp: fix deadlock in type-checking 70bfb602 * go/ssa/interp: skip recover2 testcase 958971f5 * gopls: update x/tools version a4fdb3a8 * internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp/cache: fix race condition in type-checking fd6a59f2 * internal/imports: ignore invalid mod cache entries 6b3d1c9b * internal/lsp: avoid using the importer's context as much as possible 2a03e9e3 * internal/lsp: turn on completion documentation by default adb45749 * internal/lsp: fix declarations in references df305b82 * internal/lsp: fix deadlock in type-checking 70bfb602 * go/ssa/interp: skip recover2 testcase 958971f5 * gopls: update x/tools version a4fdb3a8 * internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp/cache: add additional spans for tracing 1d492ad1 * internal/lsp/cache: fix race condition in type-checking fd6a59f2 * internal/imports: ignore invalid mod cache entries 6b3d1c9b * internal/lsp: avoid using the importer's context as much as possible 2a03e9e3 * internal/lsp: turn on completion documentation by default adb45749 * internal/lsp: fix declarations in references df305b82 * internal/lsp: fix deadlock in type-checking 70bfb602 * go/ssa/interp: skip recover2 testcase 958971f5 * gopls: update x/tools version a4fdb3a8 * internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

* internal/lsp: fix deadlock between f.mu and f.handleMu 4f238b92 * internal/lsp/cache: add additional spans for tracing 1d492ad1 * internal/lsp/cache: fix race condition in type-checking fd6a59f2 * internal/imports: ignore invalid mod cache entries 6b3d1c9b * internal/lsp: avoid using the importer's context as much as possible 2a03e9e3 * internal/lsp: turn on completion documentation by default adb45749 * internal/lsp: fix declarations in references df305b82 * internal/lsp: fix deadlock in type-checking 70bfb602 * go/ssa/interp: skip recover2 testcase 958971f5 * gopls: update x/tools version a4fdb3a8 * internal/lsp: use memoize store's context when type checking 2b65078b * go/packages: make sure to request dependencies when we NeedTypesInfo 56125e7d * internal/lsp/source: fixes completion for slice literals of pointers 2161848f * internal/lsp: enable deep completion and fuzzy matching by default 6afc7fca * x/tools/gopls: add fallback to default GOPATH if missing f340ed3a * internal/imports: skip scanned module cache dirs 340205e5 * go/packages,internal/lsp: skip memory-intensive tests on the linux-arm builder 5d7988b7 * internal/imports: use cache of mod cache pkgs in find packages ee1fc86a * internal/imports: avoid walking dir for mod file in mod cache 857b4dd9 * internal/lsp: add prepare rename support c9403068 * internal/lsp: add foldingRange support 114c5755 * go/packages: set GOPACKAGESDRIVER=off for all the tests 88604bcf * go/analysis/passes/printf: handle a potential nil pointer bce66953 * go/packages: ignore Cgo compilation error correctly f4d89772 * x/tools/gopls: reimplement rpc logging at a lower level d151469a * internal/lsp: use protocol.Ranges for source.Identifier 42f498d3 * go/analysis/cmd/vet: remove aed303cb * internal/lsp: initialize CodeActionProvider with supported actions a0cf054a * internal/lsp: limit deep completion search scope b29f5f60 * cmd/gopls: add documentation 062dbaeb * internal/lsp: add tests at the diff hook layer 71894ab6 * internal/lsp: start handling watched file change events 1f0dd028 * internal/lsp: add additional information when logging errors 11cc3c15 * go/internal/gcimporter: make safe for concurrent use 07722704 * go/analysis: handle common nil pointers c2567a22 * internal/lsp: support renaming of import spec c4a336ef * internal/lsp: use the explicit import spec name as ident 71f556f0 * internal/lsp: return error when renaming within an import spec fc82fb2a * internal/telemetry: add the ability to flush telemetry data 65e3620a * internal/telemetry: pass the http.Client to the ocagent fa80cb57 * internal/lsp: use protocol.Range in completion items 547ecf7b * internal/lsp: unlabel context, log errors when canceled 3aeeb259 * internal/imports: save information about the module cache 324b3533 * internal/lsp: speed up deep completion search f0be937d * internal/lsp: abstract the diff library so it can be substituted 85edb9ef * internal/telemetry: change concurrency model d9ab56aa * internal/lsp: test adding imports for package statements with comments 15fda70b * internal/lsp: prefer inserting imports into existing blocks d308a98e * internal/lsp: separate out getMapper function 6889da9d * internal/lsp: add completions of unimported std lib pkgs caa95bb4 * internal/lsp: use protocol.Range for diagnostics instead of span.Span a857023c * internal/lsp: return rename errors for one package only d5940c88 * internal/imports: get candidate imports d0b42650 * internal/telemetry: clean up the exporter api 5b08f89b * internal/lsp: propagate hoverKind to completion documentation 25624417 * internal/lsp: label context cancellation errors 3100af0b * internal/telemetry: extract units to their own package 922a4ee3 * internal/lsp: split the telemetry library out 156eb2ae * internal/lsp: limit concurrent file reads d87e9bba * internal/lsp: fix bug renaming local vars with test files present 9065c182 * internal/imports: merge import declarations ea414246 * internal/imports: use the resolver to load exports 578fe565 * internal/imports: test exported functions with nil args 4cb0cfd1 * go/packages: work around another case where go list doesn't respect -e 9fae7b2c * go/packages: add test case for golang/go#33462 f60b6e7d * go/packages: set -mod=readonly when processing overlays in module mode 5b18234b * go/packages: handle more errors that 'go list' prints to stderr 597f5776 * internal/lsp: fix race condition in caching 60bb3025 * internal/lsp: add fuzzy completion matching 2adf8288 * internal/lsp: show generated warning on didChange, not didOpen 9dba7caf * internal/lsp: use memoize package to cache source.Packages 62ee0342 * internal/lsp: don't deep complete struct field names 41f33577 * go/analysis: add a "-fix" flag to checker to apply suggested fixes 97f12d73 * internal/lsp: fix data race in cmd tests 528a2984 * go/packages: add a test case for golang/go#32499 afc36949 * internal/imports: return initialized options 2ad8dc80 * internal/lsp: ignore files that begin with underscores 1e8b33d6 * internal/lsp: support an experimental structured hover format 89a01ca1 * internal/lsp: change ordering of hover depending on hoverKind 0d62d440 * internal/imports: fix setting default options 4147ede4 * internal/lsp: fix documentation for completion items f07d81a5 * go/analysis: remove +experimental build tag from suggested fixes e713427f * go/packages: handle ad-hoc overlays with sources outside modules a804cf87 * internal/lsp: prevent too much open files issues 128824a2 * x/tools/cmd/gopls: prevent nil pointer dereferences b346f7fd * internal/lsp: minor refactoring for source.Identifier 8be58fba * internal/lsp: show "do not edit" message when user opens generated file cae9aa54 * go/packages: add a test for ad-hoc packages in overlays 88ddfceb * internal/lsp/testdata: delete nodisk/newdisk_exists.go 9fb8e5c8 * go/packages: rewrite Go 1.11's no such directory err to look like 1.13's 6743d409 * internal/lsp: use x/xerrors to create new errors be5259f2 * internal/lsp/cmd: handle errors when adding a file 249e2b9b * internal/lsp/cmd: remove unused isRace global variable in cmd 73d70853 * internal/lsp: do not show errors for code actions on go.mod files 1dcc99b6 * internal/lsp: support single-line hover for LSP clients like Vim 982211fc * go/analysis: change AllObjectFacts and AllPackageFacts to filter facts 35ef2682 * go/packages: handle case when go list returns absolute ImportPath c5a2fd39 * internal/lsp/telemetry/ocagent: add convertAnnotation tests e1fc249b * internal/lsp: format files that parse in packages with parse errors 2756c524 * gopls: return file error if file open fails 773fe550 * go/analysis/passes/printf: improve support for %w 1d172726 * internal/lsp: handle potential nil pointers in GetToken 43c5e4ca * internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") e9bb7d36 * internal/imports, internal/lsp: quick fix import errors 5f95ed59 * internal/imports: fix typos in documentation 1e85ed80 * x/tools/internal/imports: don't load package names for empty list 5a5cfefe * internal/lsp: extra telemetry tagging of files and packages c001e47e * internal/lsp: fix watched file protocol constants dddb7617 * internal/lsp: set initialized state 09f9cfa8 * internal/lsp: find import errors for named imports a81e99d7 * internal/lsp: use correct desc for annotation ed3277de * internal/lsp/cache: clean up parse.go 7deaedd4 * internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409 * internal/lsp: process configuration per workspace folder fc6e2057

[finishes #168789935](https://www.pivotaltracker.com/story/show/168789935) Submodule src/golang.org/x/crypto e84da0312..60c769a6c: > acme/autocert: remove tempfile after dircache write failed > ssh: skip testHandshakeErrorHandlingN on js/wasm > acme: send User-Agent and add Client.UserAgent > ed25519: turn into a wrapper for crypto/ed25519 beginning with Go 1.13 > ssh: add diffie-hellman-group-exchange-sha256 > internal/chacha20: fix variable naming > poly1305: improve performance with asm for ppc64le > internal/chacha20: improve performance for ppc64le > sha3: fix bug in cSHAKE Clone() > ssh/gss: support kerberos authentication for ssh server and client > openpgp: replace "currentTime" with "creationTime" as appropriate > scrypt: use math.bits rotate functions instead of ad-hoc implementation > ssh/test: add port for aix/ppc64 > openpgp/clearsign: reject potentially misleading headers and messages > blake2s: use math.bits rotate functions instead of ad-hoc implementation > acme/autocert: make host of TLS certificate to be obtained always Punycode > blake2b: use math.bits rotate functions instead of ad-hoc implementations > ssh: invert algorithm choices on the server > ssh/test: skip test on js/wasm > sha3: add cSHAKE support > all: change the old assembly style AX:CX to CX, AX > ssh/test: use t.Run for MAC/kex/pubkey tests > ssh: print server exit reason in tests > ssh: add packetTypeNames map for better debug info > ssh: rename ExampleHostKeyCheck to ExampleClientConfig_HostKeyCallback > ssh: remove testing.T from ExampleRetryableAuthMethod > ssh: rename methods in packetCipher interface > ssh/test: skip test to fix build on solaris and aix > crypto: update go.mod for s390x x/sys/cpu changes > ssh/terminal: Use move-N sequences for >1 cursor moves > salsa20/salsa: fix keystream loop in amd64 assembly when overflowing 32-bit counter > curve25519: add test vectors from BoringSSL > poly1305: implement a subset of the hash.Hash interface > internal/chacha20: use x/sys/cpu for s390x feature detection > poly1305: use x/sys/cpu for s390x feature detection > sha3: use x/sys/cpu for s390x feature detection > ssh/terminal: fix GetSize on Windows > all: add a go.mod file > ssh/agent: add checking for empty SSH requests > xts: reduce tweak allocations > bn256: fix String methods when g.p == nil > all: deprecate broken and legacy packages > acme: try to fetch nonce from directory first > internal/chacha20: add SIMD implementation on arm64 > curve25519: mask high bit when loading group point > all: fix ineffectual assignments > pkcs12: add a note suggesting ToPEM for multiple certificates/keys > acme: support IP address authorization type > pkcs12: note that this package is frozen and point to an alternative > Revert "pkcs12: add a DecodeAll method" > pkcs12: add a DecodeAll method > ssh/terminal: support ^N and ^P > crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr > blake2b: fix comments in grammar > sha3: add support for Keccak-512 > bn256: fix gfp12 MulScalar > openpgp: support SHA384 > ssh/terminal: enable tests for aix > ssh/terminal: use "reports whether" in IsTerminal doc > cryptobyte: fix typo in test > ssh/terminal: add AIX operating system > cryptobyte: don't ignore bytes added to BuilderContinuations of fixed-size Builders > ssh: return specific error for invalid signature algorithm > acme: support custom crypto.Signer implementations > ssh/agent: Fix error returned from agent responses that are too big. > bcrypt: benchmark defaults > cryptobyte: add (*Builder).Unwrite and (*Builder).SetError > openpgp: pass hash to Signer.Sign for ECDSA > ssh: support SSH agent signature flags and custom extensions > all: fix typos Submodule src/golang.org/x/net cdfb69ac3...13f9640d4: > [release-branch.go1.13] http2/h2demo: remove h2demo build constraint > [release-branch.go1.13] http2: fix memory leak in random write scheduler > http2: limit number of control frames in server send queue < [release-branch.go1.12] http2: limit number of control frames in server send queue > http2: use updated URI in doc > proxy: fix TestDial failures on wasm/js > internal/socket, ipv4, ipv6: add support for GOOS=illumos > publicsuffix: update table to latest list from publicsuffix.org > all: follow convention for generated code comment > internal/socket: add support for freebsd/arm64 > internal/socket: add support for openbsd/arm64 > http2: support getting the Server connection's base context from net/http > go.mod: add go language version > http2: disable a flaky test on Windows for now, add more logging > bpf: fix VM out of bounds LoadMemShift check > webdav: remove redundant trailing slash for root directory > internal/socket: add support for netbsd/arm64 > internal/socket: remove leftover AF_* and SOCK_RAW constants on aix > internal/socket: use AF_* and SOCK_RAW constants from x/sys > ipv4, ipv6, internal/socket: add riscv64 support > http2: track reused connections > http2/h2demo: stop using gitlock, use Go modules > proxy: add ProxyFromEnvironmentUsing > proxy: add Dial (with context) > html: implement ParseWithOptions and ParseFragmentWithOptions > idna: update to Unicode 11 > publicsuffix: domain labels may not be empty > html: Add missing condition to 'in cell' insertion mode, required by spec > html: add "in head noscript" im support > ipv4: clarify the range of broken freebsd kernel versions > icmp: add port for aix/ppc64 > ipv6: add port for aix/ppc64 > ipv4: add port for aix/ppc64 > internal/socket: add port for aix/ppc64 > http2: don't hang a stream if trailers values are not provided > ipv4: work around FreeBSD 12.0 kernel running COMPAT_FREEBSD32 > publicsuffix: add a who-manages-this example > http2/h2i: add port for aix/ppc64 > publicsuffix: update table to latest list from publicsuffix.org > all: use of nettest, remove internal/nettest > bpf: use of nettest > nettest: add SupportsRawSocket > http2: make empty method mean GET > nettest: move helpers from internal/nettest package > html: gofmt -w -s > html: fix parsing where nested tags of unknown types inadvertently close one another > nettest: remove Go 1.6 compatibility code > ipv4: work around FreeBSD 11.3 or 12 kernel running COMPAT_FREEBSD32 > all: make bit clear operator explicitly > Revert "ipv4: work around FreeBSD 12 kernel running COMPAT_FREEBSD32" > ipv4: work around FreeBSD 12 kernel running COMPAT_FREEBSD32 > ipv6: skip tests on aix, fuchsia and hurd > ipv4: skip tests on aix, fuchsia and hurd > ipv6: replace errOpNoSupport with errNotImplemented > ipv4: replace errOpNoSupport with errNotImplemented > icmp: make non-privileged tests more adaptive > icmp: replace errOpNoSupport with errNotImplemented > http2/h2demo: require golang.org/x/net@latest > all: add go.mod files, carve h2demo into separate module > icmp: add simple multipart message validation > ipv6: drop support for go1.8 or below > ipv4: drop support for go1.8 or below > internal/socket: drop support for go1.8 or below > ipv4: fix error values on header manipulation > internal/socket: use correct cmsg alignment for netbsd/arm > http2: remove use of DeepEqual for testing errors > webdav: add trailing slash on directories > ipv4: fix typo in comment > internal/socket: make not implemented errors more descriptive > ipv6: rename freebsd32o64 with compatFreeBSD32 for consistency > ipv4: rename freebsd32o64 with compatFreeBSD32 for consistency > ipv6: make not implemented errors more descriptive > icmp: don't run diagnostic tests by default, even in long mode > icmp: simplify Message.Marshal > nettest: mark test helper functions > nettest: fix doc for testPresentTimeout > html: remove G+ reference from testdata > http2: fix a typo > html: remove unnecessary break Submodule src/golang.org/x/sys 3b5209105..fde4db37a: > unix/linux: update Dockerfile to glibc 2.30 > unix: disable ptrace on iOS > unix: fix epoll_event padding on riscv64 > windows: add support for automatic delayed start in windows service > unix: remove nacl build tag from dirent code > unix: fix several staticcheck issues > windows: add CTRL_CLOSE_EVENT, CTRL_LOGOFF_EVENT, and CTRL_SHUTDOWN_EVENT > unix: add riscv64 tag to endian_little.go > unix: add constants and types to work with Linux loop devices > unix: update Dockerfile to Linux 5.2 and Go 1.13beta1 > unix: add missing dirent* helper functions on aix > unix: don't use syscall.ParseDirent > unix: add Getdents on dragonfly > unix: use ParseDirent in testGetdirentries > unix: fix nil pointer dereference in Getdirentries on 32-bit freebsd 12 > unix: add missing import in readdirent_getdirentries.go > unix: fix Getdirentries emulation using Getdents on netbsd, openbsd > unix: add test for Getdirentries > unix: merge implementation for ReadDirent > unix: add support to get/set Linux capabilities > unix: correctly rename Val member in Sigset_t on freebsd > unix: add ptrace support for FreeBSD > unix: add AT_SYMLINK_FOLLOW const on openbsd > unix: add AT_SYMLINK_FOLLOW const on netbsd > windows: make CoTaskMemFree public > unix: remove net dependency > windows: allow determining real version number > unix: fix Getdirentries emulation using Getdents on netbsd, openbsd > unix: change the mksysnum master to point to stable/11 on freebsd > windows: rename some arguments to follow MSDN > windows: allow looking up well-known folder paths > windows: add OpenThread function > windows: add GetProcessId function > unix: fix Getdirentries on 32-bit freebsd 12 > windows: expose GetCurrentProcessId function > windows: allow determining if manager is locked > windows: correct types and error values of internal GUID handling > windows: add Thread32{First,Next} funcions > windows: properly plumb sidtype into service creation > windows: add GUID handling functions > windows: add accessor for duration since boot > windows: add constants for access rights > windows: make it easier to iterate over groups and privileges > windows: delete mkerrors.go > unix: provide linux/riscv64 assembly for syscalls > unix: fix TestFchmodat on illumos > Revert "windows: make zsyscall_windows.go generatable on non-WSL env" > windows: make zsyscall_windows.go generatable on non-WSL env > windows: add GenerateConsoleCtrlEvent function > plan9: modify mkall.sh to support zsyscall*.go files generation > cpu: add missing linkname for libc_getsystemcfg on aix/ppc64 > windows: add SetInformationJobObject functions > windows: add functions for priority class > cpu: don't depend on the golang.org/x/sys/unix package for AIX > unix: fix Signalfd function signature on linux > windows: add ResumeThread function > windows: allow Windows-style printf debugging via MessageBox > windows: add ShellExecute > windows: allow determining if running 32-on-64bit > windows: add SID getter functions for the various components > windows: add SetErrorMode function > windows: add IP() accessor to SocketAddress type > windows: add JobObject functions > unix: add MCAST_* constants on linux > unix: add RawSockaddrDatalink on aix > windows: do not query library for inline functions > windows: add missing service constants > windows/registry: do not generate unaligned loads > unix: remove unused stringsFromByteSlice for tests on aix > unix: remove StTimespec type on AIX > windows: add functions for dealing with elevated tokens > windows: add token group adjustment function > unix: fix TestStatFieldNames on aix and TestUtimesNanoAt on darwin > unix: rename Stat_t time fields to [AMCB]tim > windows: add token environment functions > windows: add basic WTS functions for windows/svc usage > windows: add service notification support > windows: add token manipulation functions and constants > windows: add "generate" build tag > unix: add IoctlGetUint32 on Linux > unix: add BPF constants on Linux > unix: export KexecFileLoad on linux/arm > unix: update Dockerfile to Linux 5.1 > windows: CreateFile's templatefile parameter has always been a HANDLE > unix: add missing tpacket block (sub)header > unix: add illumos case > unix: support generating netbsd/arm64 files in mkall.sh > unix: drop reference to mkunix.pl from comment > windows: don't return EINVAL on zero Chmod mode > windows: document new ProcessId field > unix: replace "mksysctl_openbsd.pl" script with a Go program > unix: skip TestOpenByHandleAt if name_to_handle_at not supported > windows: allow querying service ProcessId > unix: add FileHandle, NewFileHandle, NameToHandleAt, OpenByHandleAt > unix: add Linux crypto configuration API constants and types > unix: add support for openbsd/arm64 > unix: remove arch specific build for openbsd_pledge.go > unix: add unexported name_to_handle_at and open_by_handle_at types & wrappers > unix: add Unmount syscall for AIX > unix: add Select syscall on AIX > unix: use nsendmsg and nrecvmsg on AIX > unix: fix cmsg alignment on aix > unix: move helper handler before AIX handler in TestPassFD > unix: enable TestPassFD on AIX 7.2 TL >= 2 > windows: add GetFileInformationByHandleEx function > windows: add missing error constants > unix: add missing rtnetlink IFLA_* constants on Linux > unix: add missing rtnetlink neighbor constants on Linux > unix: add missing rtnetlink IFA_* constants on Linux > unix: allow empty string argument to SetsockoptString > unix: don't generate raw syscall wrapper for ClockGettime on darwin > unix: remove ClockGettime for darwin/amd64 on Go 1.11 > unix: add SysctlClockinfo on darwin > unix: add GetsockoptUint64 and SetsockoptUint64 > windows: add GetOverlappedResult function for async I/O > windows: add missing file flags to types > unix: add SysctlClockinfo on OpenBSD > windows: add support for creating well known SIDs > cpu: use unix.Getsystemcfg to detect POWER8/POWER9 on aix/ppc64 > unix: run mkasm independent of mktypes in mkall.sh > unix: add Getsystemcfg on aix > windows: use proper system directory path in fallback loader > unix, unix/linux: add additional Linux perf API bits > cpu: add build tag to cpu_wasm.go > unix: add SetsockoptPacketMreq on Linux > all: add go directive to go.mod > cpu: define cacheLineSize and doinit for WASM > windows/svc: safely load system DLLs > unix: add functions to get/set tpacket socket options > unix: on ARM GNU/Linux let Pipe fall back to pipe > unix: add Lutimes > unix: update Dockerfile to Go 1.12 and Linux 5.0 > unix: add fanotify API on Linux > unix: add SignalNum to convert signal name to a number > windows/svc: align ctlHandler parameters > windows/svc: add Context to ChangeRequest > unix: use 64-bit alignment on netbsd-arm > cpu: add CPU features for s390x > cpu: don't panic on error reading /proc/self/auxv > all: add a go.mod file > unix: don't overwrite unrelated file descriptors in TestDup > unix: add type NdUseroptmsg on Linux > unix: add SetsockoptCanRawFilter for linux > unix: add SetsockoptSockFprog on Linux for attaching BPF filters > cpu: fix build for GOARCH=ppc64{,le} on GOOS!=linux > windows: gofmt -w windows/security_windows.go > unix: do not invoke Mkfifo with a relative path in a read-only directory > cpu: unexport HWCap and HWCap2 > cpu: fix auxval parsing on big-endian systems > cpu: fix build for GOARCH=arm64 on GOOS!=linux > unix: replace Perl script references in "README.md" with Go programs > unix: replace "mksyscall_solaris.pl" script with a Go program Submodule src/golang.org/x/text e6919f657..342b2e1fb: > all: upgrade to Unicode 11 > gen.go: update due to changes to core > cases: fix case mappings to allow for Gregorian uppercase > cases: add bit for exception index > internal/export/unicode: add scripts tests > internal/export/unicode: simplified generation > transform, unicode/cldr: spell "Deprecated: Use etc" consistently > currency: disable flaky TestLinking > internal/export/idna: hoist conformance test > gen: prepare for move to Unicode 11 > message/pipeline: skip test on GOOS=android > language: fix Region.ISO3 and reintroduce lookup tests > internal/export/unicode: add table generator > gen.go: fix breakage due to changes in core Submodule src/golang.org/x/tools aa8296574...65e3620a7: > internal/telemetry: add the ability to flush telemetry data > internal/telemetry: pass the http.Client to the ocagent > internal/lsp: use protocol.Range in completion items > internal/lsp: unlabel context, log errors when canceled > internal/imports: save information about the module cache > internal/lsp: speed up deep completion search > internal/lsp: abstract the diff library so it can be substituted > internal/telemetry: change concurrency model > internal/lsp: test adding imports for package statements with comments > internal/lsp: prefer inserting imports into existing blocks > internal/lsp: separate out getMapper function > internal/lsp: add completions of unimported std lib pkgs > internal/lsp: use protocol.Range for diagnostics instead of span.Span > internal/lsp: return rename errors for one package only > internal/imports: get candidate imports > internal/telemetry: clean up the exporter api > internal/lsp: propagate hoverKind to completion documentation > internal/lsp: label context cancellation errors > internal/telemetry: extract units to their own package > internal/lsp: split the telemetry library out > internal/lsp: limit concurrent file reads > internal/lsp: fix bug renaming local vars with test files present > internal/imports: merge import declarations > internal/imports: use the resolver to load exports > internal/imports: test exported functions with nil args > go/packages: work around another case where go list doesn't respect -e > go/packages: add test case for golang/go#33462 > go/packages: set -mod=readonly when processing overlays in module mode > go/packages: handle more errors that 'go list' prints to stderr > internal/lsp: fix race condition in caching > internal/lsp: add fuzzy completion matching > internal/lsp: show generated warning on didChange, not didOpen > internal/lsp: use memoize package to cache source.Packages > internal/lsp: don't deep complete struct field names > go/analysis: add a "-fix" flag to checker to apply suggested fixes > internal/lsp: fix data race in cmd tests > go/packages: add a test case for golang/go#32499 > internal/imports: return initialized options > internal/lsp: ignore files that begin with underscores > internal/lsp: support an experimental structured hover format > internal/lsp: change ordering of hover depending on hoverKind > internal/imports: fix setting default options > internal/lsp: fix documentation for completion items > digraph: add transpose > digraph: refactor somepath to print an adjacency list > go/analysis: remove +experimental build tag from suggested fixes > go/packages: handle ad-hoc overlays with sources outside modules > internal/lsp: prevent too much open files issues > x/tools/cmd/gopls: prevent nil pointer dereferences > internal/lsp: minor refactoring for source.Identifier > internal/lsp: show "do not edit" message when user opens generated file > go/packages: add a test for ad-hoc packages in overlays > internal/lsp/testdata: delete nodisk/newdisk_exists.go > go/packages: rewrite Go 1.11's no such directory err to look like 1.13's > internal/lsp: use x/xerrors to create new errors > internal/lsp/cmd: handle errors when adding a file > internal/lsp/cmd: remove unused isRace global variable in cmd > internal/lsp: do not show errors for code actions on go.mod files > internal/lsp: support single-line hover for LSP clients like Vim > go/analysis: change AllObjectFacts and AllPackageFacts to filter facts > go/packages: handle case when go list returns absolute ImportPath > internal/lsp/telemetry/ocagent: add convertAnnotation tests > internal/lsp: format files that parse in packages with parse errors > gopls: return file error if file open fails > go/analysis/passes/printf: improve support for %w > internal/lsp: handle potential nil pointers in GetToken > internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") > internal/imports, internal/lsp: quick fix import errors > internal/imports: fix typos in documentation > x/tools/internal/imports: don't load package names for empty list > internal/lsp: extra telemetry tagging of files and packages > internal/lsp: fix watched file protocol constants > internal/lsp: set initialized state > internal/lsp: find import errors for named imports > internal/lsp: use correct desc for annotation > internal/lsp/cache: clean up parse.go > internal/lsp/source: fix renaming of SuggestedFixes in experimental file > internal/lsp: process configuration per workspace folder > internal/lsp: compare mod file versions used in imports > internal/lsp: format files in packages with errors > internal/import: strings.Trim expects a cutset, not a string > gopls: update x/tools vesion in mod file > internal/lsp: swallow hover error over identifier not found > internal/lsp: fix lockup for packages with many files > internal/lsp: add an ocagent exporter for the telemetry system > go/cfg: stop once we've found the fallthrough target > internal/imports: disable go/packages-incompatible tests > internal/lsp: the json wire format of the open cencus agent > internal/lsp: have tests report a different application name to the main gopls binary > internal/lsp: new tracing system > internal/imports: save scanned module cache results > go/packages, internal/lsp: modify tests to expose overlays bug > internal/lsp: purge the remains of the xlog system now it is not used > internal/lsp: convert logging calls > internal/lsp: add a new telemetry based logging system > internal/lsp: use a background context for the background worker > internal/lsp: fixed broken tracing > go/packages: add debug logging via the packages.Config > internal/lsp: cache the imports ProcessEnv across imports calls > internal/lsp: fix the incomplete and broken commit > internal/lsp: cache the *ast.File and *token.File on the package > internal/jsonrpc2: move stats and logging across to gopls > internal/lsp: add tracing to the didOpen call > internal/lsp: add continue to source_test > digraph: refactor allpaths to print an adjacency list > internal/lsp: add temporary file to fix bug with tip go > internal/lsp: sort rename results > go/loader: normalize cycle to remove flake > internal/lsp: fix panics in loading, add more logging > internal/lsp: add an rpc summary debug page using the metrics > internal/lsp: remove the non context xlog path > internal/lsp: convert all logging calls to the context version > interal/lsp: add context based version of xlog > internal/jsonrpc2: extract logic to handler hooks > internal/jsonrpc2: cleanup the jsonrpc2 callbacks > internal/lsp: fix unnecessary error logging > internal/lsp: handle language ID in didOpen calls > internal/lsp: add links search in comments and string literals > internal/lsp: fix some cases of stuck files > go/analysis: update internal/facts and unit checker to support all(Package|Object)Facts methods > internal/lsp: update the generated lsp protocol > internal/lsp: add prometheus exporting of all metrics > internal/lsp: reduce trace package to minimal StartSpan for now > internal/lsp: add the metrics package > internal/lsp: support hover for *ast.ImportSpec > internal/lsp: stop making background contexts everywhere > digraph: clean up docs, usage, copyright > internal/lsp: update version and go.mod > internal/lsp/debug: increase gopls version before tagging new version > internal/lsp: rename identifiers in test packages > internal/lsp: add new stats library > internal/lsp: add the new form of the telemetry tagging package > internal/lsp: add the worker package > internal/lsp: add documentation to completion items > internal/lsp: compare names when finding references > internal/lsp: don't refresh metadata when context canceled > internal/lsp: return an error when renaming a builtin > go/packages: add documentation on the driver protocol. > internal/lsp: check no errs for assignability rename > internal/lsp: remove the unused function 'markupContent'. > internal/lsp: fix test failure introduced in CL 185058 > internal/span: handle character values beyond end of line in FromUTF16Column > internal/lsp/fuzzy: add fuzzy matching library > internal/lsp: move function signature into detail instead of label > internal/lsp: connect memoize actions to their callers > internal/lsp: add some trace spans to important functions > internal/lsp: include declaration for references > internal/lsp/cmd: replace time.Tick with time.After > internal/lsp: fix deadlocks loading lots of files at once > internal/lsp: add configuration for hover levels > internal/lsp: improve completion support for untyped constants > cmd/present: correct function reference. > internal/lsp: hide signature help in function literals > internal/lsp: support renaming import specs > internal/imports: refactor to split finding and applying fixes > internal/lsp, internal/imports: use the internal goimports library > internal/lsp: check file content on disk when opening > internal/lsp: find references in test packages > internal/lsp: handle the context.only parameter for code actions > internal/lsp: improve completion support for type conversions > internal/lsp: fix bug where gopls hangs on manually typed imports > internal/lsp: fix deadlock in type-checking > internal/lsp: clear diagnostics for files on close, even with errors > tools: update go.mod > internal/lsp: check ident exists for comment rename > internal/lsp: update version > gopls: update go.mod file > internal/lsp: fix bug in missing imports tracking > internal/lsp: new requests.ts to generate new versions of tsclient.go and tsserver.go > internal/lsp: match completions case-insensitively > internal/jsonrpc2: add some extra comments > internal/lsp: handle err in formatRange > go/packages: avoid loading some packages in when computing overlays > go/packages: fix bug in contains for ad-hoc packages > internal/lsp: provide deep completion candidates > internal/lsp: modify check for a missing package > internal/lsp/source: move the common path to the left > Revert "internal/lsp: modify check for a missing package" > internal/lsp: modify check for a missing package > internal/span: catch potential panics in go/token > internal/lsp: fix race condition in type-checking > all: go mod tidy all modules under x/tools > internal/jsonrpc2: change the concurrency strategy > internal/jsonrpc2: refactor to enable a more advanced request > internal/jsonrpc2: add telemetry to the rpc system > internal/lsp: propagate context.Canceled when type checking > internal/lsp: improve completion support for type assertions > go/packages: check error in addNeededOverlayPackages > internal/lsp: plumb suggested fixes through the LSP > internal/lsp: enable incrementalSync by default > internal/lsp: fix panic in computing file version > go/analysis/doc: add doc about suggested_fixes. > internal/lsp/source: don't panic compiling regex > internal/lsp: support a file belonging to multiple packages > internal/lsp: separate refactorings out of memoization CL > cmd/present: use unique key for destSlide in local store > go/loader: document that package is deprecated > go/packages: fix mistake for ad-hoc packages > internal/lsp: add telemetry stubs > internal/lsp: update doc comments on rename > refactor/rename: remove extraneous space > internal/lsp: fix bug in creating token.Files > internal/lsp: check for conflicts on rename > internal/lsp: send client expected rename provider > internal/lsp: fix function value completions > go/packages: trim errors returned by go list > internal/lsp: add identifier renaming > internal/lsp: apply type modifiers to completion candidate > internal/lsp: fix references for type switch vars > internal/lsp: add a field on the package to store diagnostics > go/packages: support test files in overlays > internal/lsp: remove the redundant `Server.Run()` call. > internal/lsp: enable textDocument/didSave notifications > internal/lsp: switching debug pages to not use the default mux > internal/lsp: determine diagnostics to show per-file, not per-package > internal/lsp: suggest completions that satisfy interfaces > go/packages: fix support for ad-hoc packages to handle errors > go/analysis: add SuggestedFix to Diagnostic > go/packages: add support for file= queries on ad-hoc packages > internal/lsp/cache: fix ineffectual err assignment > internal/lsp/diff: remove redundant memory allocate and copy operations in function 'shortestEditSequence'. > internal/lsp: clear diagnostics when all files from a package are closed > internal/lsp/cache: fix nil check by adding missing "continue" > internal/lsp: parse filenames only out of go list errors > internal/lsp: use the memoize package to get *token.Files > internal/lsp: block rather than reject when the message queue is full > internal/lsp: clear out missing imports set when we re-load package > internal/lsp: update analysis runner for new features > go/analysis/passes/composite: whitelist unicode.Range32 > internal/span: improve invalid uri message > internal/lsp/protocol: bring the code generating programs up to date > gopls: adding the gopls module > cmd/gopls: preparing for v0.1.0 > internal/lsp: use ids instead of package paths as map keys > internal/lsp: fix typo on license year > internal/lsp/debug: add newlines to debug messages > internal/memoize: document the complicated parts of the memoize package > internal/lsp: fix errors when adding new file to existing package > internal/lsp: fix panic when file deleted > internal/lsp: create types for package paths and IDs > internal/lsp: move the fixup and parallel limits into the main parse function > internal/lsp: memoize all the parsing > internal/lsp: using memoize for all file contents > internal/lsp: fix type checking for unsafe package > internal/lsp: improve error handling while parsing > internal/lsp: add a Version constant > internal/span: handle empty paths correctly > internal/lsp: stop requiring a .go extension for all Go files > internal/lsp: fix check for changed imports > internal/memoize: a new library to memoize functions > internal/imports: suggest x for x_tests > internal/span: change URI.Filename so it just returns the filename > internal/lsp: allow fine-grained control over vet checks > internal/lsp: add find all references > internal/lsp: track missing imports, re-running packages.Load > internal/lsp: enable "ignoreFuncBodies" and fix caching > internal/imports: actually cache resolvers > internal/lsp: add an implementation for textDocument/didSave > internal/lsp: reply with nil, rather than empty, signature help > internal/imports: fix TestNoMainModule > internal/lsp: fix some issues with trimming ASTs > go/internal/gccgoimporter: update package to match std lib version > internal/lsp: attach documentation to signature help > go/internal/gccgoimporter: update importer tests to match std lib version > internal/lsp: remove source.FileContent > internal/lsp: don't queue content changes > go/internal/gcimporter: skip stdlib tests in race mode as they are too slow > internal/lsp: change file system to allow lazy reads > internal/lsp: add some basic tests for imports > internal/lsp: support build flags on processConfig > internal/lsp: trim ASTs for which we do not require function bodies > internal/lsp: fix regression from CL 179439 > internal/lsp: build the builtin package preemptively > internal/jsonrpc2: adding rpc trace tasks > internal/lsp: add memory debugging page > internal/lsp: debug pages for sessions views and files > internal/lsp: move PrintVersionInfo to the debug package > go/analysis/passes/structtag: allow field tag shadowing > errorsas: handle single-actual case > errorsas: ignore empty interface target > internal/lsp/cache: fix leaking wg.Done() and <-ioLimit > go/packages: update documentation for Package.Types and Package.Syntax > go/packages: support new main packages in overlays > internal/lsp: send void client response to client/registerCapapbility > go/analysis: add an End field to Diagnostic > internal/lsp: refactor to separate pieces of type-checking > internal/lsp: add debug page serving > go/analysis/passes/tests: add pointer to where test name conventions are specified > internal/lsp: fix setting overlays in tests > go/packages: handle potential nil pointer error > go/packages: officially deprecate LoadX values in favor of NeedX values > internal/lsp: set env to os.Environ to start > internal/lsp: run analyses despite some errors > godoc: re-add test for ignoring //line comments in source code > internal/lsp: client/registerCapapbility is a request, not a notification > go/packages: work around go list behavior for missing dependencies > cmd/splitdwarf: fix skip on Windows > internal/lsp: add modfile, sumfile structs, require Go files for diagnostics > internal/lsp: fix race condition in type-checking > all: GOSUMDB=off for tests that use fake modules > internal/lsp: add file watching and use it to trigger invalidations > internal/lsp: add a file system abstraction > internal/lsp: remove SelectionRange and textDocument/selectionRange > internal/lsp: don't show diagnostics for mod files > internal/lsp: re-run go/packages.Load when the package name changes > internal/lsp: build the packages config on demand from proper configuration > internal/lsp: log when we fail to type-check a package > imports: allow nil Options in Process > internal/lsp: fix completion insertion with non-identifier suffix > cmd/goimports: reuse cached state > imports: rename to internal/imports > internal/lsp: add nil checks for ASTs and token > internal/lsp: fix race in delivering diagnostics to the command line client > internal/lsp: update column mapper with content on incremental changes > internal/lsp: fix swallowed package errors > internal/lsp: fix completion insertion > godoc: declare small victory over the punched card tyranny > internal/lsp: support definitions and hover for builtins > internal/lsp: use ranges instead of positions in completion items > internal/lsp: add structured layers to the cache > internal/lsp: enable enhanced hover by default > internal/lsp: handle more expected type cases > godoc/util: serve SVG files raw > internal/lsp: prepare for non go files > internal/lsp: add shutdown handling > internal/lsp: remove constant value from label and add tests > internal/lsp: handle additional snippet cases > internal/lsp: reduce the api surface of the cache package > internal/lsp: use builtin package for signature help > internal/lsp: make snippets private fields > internal/lsp: fix missing parens in function call snippet > internal/lsp: ignore files in the builtin package > internal/lsp: fix typo on license year > internal/lsp: fix nil pointer when propagating diagnostics > go/analysis/internal/analysisflags: call gob.Register on deleted analyzers > internal/lsp: stop trimming prefix from InsertText > internal/lsp: fix composite literal completion > godoc/static: let client use vet check returned by /compile endpoint > go/analysis/passes/bools: eliminate quadratic runtime, output > internal/lsp: respond to shutdown requests and add DO NOT EDITs > internal/lsp: add some missing copyright notices > internal/lsp: add version and bug commands > internal/lsp: suppress info and default logging unless a verbose flag is supplied > internal/lsp: support dynamic workspace folder changes > internal/lsp: fix definition tests to use golden files > go/packages/packagestest: fix MustCopyFileTree so that file fragments are always slash form > internal/lsp: adding the test suite to the source package > internal/lsp: making cmd tests fast and small > internal/lsp: improve expected type determination > internal/lsp: add definition support for packages > cmd/vet: print help to stdout only > internal/lsp: propagate diagnostics for reverse dependencies > internal/lsp: add additional error handling for builtin packages > go/analysis/passes: fix bugs discovered in std > go/analysis/analysistest: fix word usage > compilebench: handle missing MemStats more gracefully > compilebench: add a linker benchmark > compilebench: factor running build tool commands > compilebench: clean up different benchmark types > internal/lsp: fix incremental updates and turn them on > internal/lsp: switch golden files to use txtar > internal/lsp: disable rangeFormatting temporarily > lostcancel: do not analyze cancel variable which defined outside current function scope > go/vcs: ignore "mod" VCS type > internal/lsp: add document link handling for import paths to godoc > internal/span: update the offset if the end offset should be valid but is not > go/analysis: proposed fact enumeration API > internal/span: add a filename only print for spans > internal/lsp: support builtin types without hardcoding > internal/lsp: first pass at some hover tests > internal/lsp: generate RPC interface from Typescript source > internal/lsp: change some comments and variable names in completion code > cmd/goimports: add -format-only flag > internal/lsp: clean up formatting header handling > internal/lsp: handle nil pointer in (*Package).GetActionGraph > internal/span: fix another off-by-one in ToUTF16Column > internal/lsp: add struct literal field snippets > internal/lsp/source: refactor completion > internal/lsp: handle shadowed variables in lexical completions > internal/lsp: add the format command line > internal/lsp: fix utf16 conversion for end of file cursor > internal/lsp: extensive utf16 tests > internal/lsp: handle error from runAnalyses > go/packages/packagestest: fix GOPROXY file URLs for Windows > internal/lsp: fix stuck diagnostic messages > internal/lsp: return errors when we can't find a package > internal/lsp: introduce snippet builder object > x/tools/go/packages/packagestest: fix GOPROXY file URLs for Windows > cmd/vet: verify potentially-recursive Stringers are actually Stringers > go/internal/gccgoimporter: update package to match std lib version > internal/lsp: handle completion after defer, go statements > internal/lsp: suppress more completions in comments and literals > go/packages: deduplicate file parsing > internal/lsp: make interface methods children of the interface symbol > internal/span: fix off-by-one in ToUTF16Column > internal/lsp: add more error propagation and logging for analyses > go/packages: add some documentation for extractPackage > all: run go mod tidy > internal/lsp: improve composite literal completion > internal/lsp: delay the running of gofmt until the test is running > internal/lsp: adding golden file support to the test harness > apidiff: represent a Report as a list of Changes > internal/lsp: add more error handling to analysis > internal/lsp: add check for nil package > internal/lsp: add additional debug logging for diagnostics > internal/lsp: fix typo on 'textDocument/foldingRange' method > internal/lsp: fix error handling in cmd > internal/lsp: fix query cmd usage > internal/lsp: extract the common test logic > internal/lsp: support comments on hover for typenames, funcs, fields > internal/lsp: handle embedded struct pointer definitions > go/internal/gccgoimporter: update package to match std lib version > internal/lsp: add type to placeholders in completion parameters > internal/lsp: add an additional check to ToUTF16Column > internal/lsp: use ast.Nodes for hover information > internal/lsp: use strings.EqualFold instead of == > internal/lsp/protocol: add a compare function for span.URI > internal/lsp: add compare functions for spans > internal/lsp: check content format instead of assuming markdown > internal/lsp: a cleaner way of doing overlays > internal/lsp: trigger signature help after completing a function > internal/lsp: refactor server.go to separate into LSP categories > internal/lsp: reply to shutdown request > internal/lsp: improve signatureHelp in various cases > internal/lsp: switch completion item tests to using the enum strings > go/packages: add support for entire packages defined in overlays > internal/lsp: make the symbols tests use the enum names rather than hard coding the values > internal/lsp: set the diagnostic source earlier > internal/lsp: cleanup the diagnostic and completion tests > internal/lsp: run source.organizeImports on all codeActions > internal/lsp: minor clean up of symbol tests > internal/lsp: Add to and from string handling for the enums > go/packages: fix broken test that checks errors > internal/lsp: fix badly formatted error messages from go vet > internal/lsp: organize imports as a quickfix > go/gcexportdata: fix example test for changes in net/rpc > internal/lsp: log errors when diagnostics fail > internal/lsp: fix crash when there is a type alias to a struct in the symbols code > internal/lsp: handle definitions for variables with error types > internal/lsp: normalise and make public diff<->edit conversions > internal/lsp: add unified diff > internal/lsp: Remove 1.10 compatability in tests > cmd/compilebench: update document > internal/lsp: enhance document symbols support > apidiff: fix old reference to golang.org/x/exp > cmd/getgo: fix build on aix > internal/lsp: ignore errors for completion and signature help > internal/apidiff: diffs of package APIs > cmd/gopls: fix incomplete ClientCapabilities struct > internal/lsp: stop formatting on files that do not parse > internal/lsp: remove defunct copy of the LSP protocol > go/packages: add a work around for go list behavior for missing ad-hoc package > imports: fix circular imports > internal/lsp: change diff tests to take strings not string arrays to make them more realistic > cmd/gopls/integration/vscode: log diagnostics as they are received > internal/lsp: refactor code actions > internal/jsonrpc2: fix bug in direction logging of call responses > cmd/auth/cookieauth: add a GOAUTH implementation that reads from a cookiefile > cmd/auth/netrcauth: add a reference GOAUTH implementation using .netrc files > cmd/auth/gitauth: add a reference GOAUTH implementation using 'git credential fill' > cmd/auth/authtest: add a manual-test harness for GOAUTH implementations > internal/lsp: change diff Op.Content to be the unjoined strings > internal/lsp: make definition use the lsp protocol > internal/lsp: minor comment fix > internal/lsp: add a "usePlaceholders" setting to gopls configuration > internal/lsp: make the guru emulation tests slightly looser with a different matching system > go/packages: only test TestSizes on GOOS where 386 and amd64 GOARCH exists > go/packages: make sure TypesSizes are requested when Types are > go/packages: fix json struct tag on driverRequest.Command > internal/span: span to protocol needs position as well as offset > go/packages: rename golistDriverCurrent to golistDriver > internal/lsp: avoid extra work in *cache.View.remove > internal/lsp: suppress error message when there is no config > internal/lsp: check the client capabilities before calling workspace/configuration > internal/lsp: support multiple views > internal/lsp: create the undelivered map > internal/lsp: cache file objects for every dependency > internal/lsp: handle undelivered diagnostics > internal/lsp: make pipe mode the default for command line tests > internal/lsp: add the ability to log back to the client > go/analysis/unitchecker: allow dash in file paths > go/packages: add NeedTypesSizes to LoadTypes > imports: add syscall/js API to zstdlib.go > internal/lsp: add a work-around for golang.org/issue/31090 > internal/lsp: use new go/packages LoadMode to get TypesSizes > internal/lsp: add an error result to findFile > internal/lsp: clean up the confguraton handling > internal/lsp: decouple message processing from stream processing. > internal/jsonrpc2: split main loop from construction to fix race > internal/lsp: fix nil pointer exception in document symbols > internal/lsp: fix broken gopls query help comment > internal/lsp: allow command line tests to connect through a pipe > internal/lsp: adding command line access to diagnostics > internal/lsp: wire up configuration > internal/lsp: correctly report interface symbols > internal/lsp: fix tiny bug in getting files by basename > internal/lsp: match files by identity > go/packages: split LoadMode into fine-grained options > internal/lsp: unescape uris before we convert them to span.URI > internal/span: switch to an offset function that doesn't panic > internal/lsp: add back distinction between var and const symbols > internal/span: return error when on spans with invalid starts > internal/lsp: group document symbols and add more detail > go/analysis/cmd/vet: add errorsas analyzer > go/analysis/passes/errorsas: check type of errors.As target > internal/lsp: use main testdata folder > internal/lsp: add support for document highlight > x/tools/internal/lsp: add support for document symbols > go/packages/packagestest: convert to the span library > go/packages: remove spurious print > go/packages/testdata: add go directives to fake module files > go/packages: detect missing binary via exec.ErrNotFound error > go/ssa/interp: make tests fast and robust > go/analysis/passes/tests: break out of loop when we find a method > go/analysis/passes/tests: don't warn about missing method for each type > go/packages: fix the build > go/analysis/internal/checker: don't clobber fact when codeFact fails > go/packages: give a better error if 'go' is missing > go/packages: make error message for conflicting packages more clear > go/analysis/passes/test: remove some false positives > go/packages: remove fallback listfunc for Go 1.10.4 > third_party: remove > internal/lsp/cmd: fix regexp in test > x/tools/go/packages: seems to do nothing when given non-Go files > go/analysis: make stdmethods happy on encoding/xml > go/gcexportdata: fix gcexportdata example for new compiler behavior > internal/lsp: fix accepting line:colum forms to query definition > internal/lsp: refactor query definition test to allow adding a new test > cmd/stringer: compile error when constants change > internal/lsp,internal/lsp/cmd: skip tests on android > cmd/stringer: add temporary(?) fix to get stringer test working in module mode > imports: handle missing main module > go/packages: run name query tests in a temporary directory > internal/span: change to private fields > cmd/lsp: skip completion in string literals > internal/lsp: add correct handling for circular imports > internal/lsp: configure completion to preselect the first item > internal/lsp: propagate errors from in diagnostics > internal/lsp: filter on insert text, not label > cmd/compilebench: generate separate mem profiles when using -count > internal/lsp: handle common nil pointer exceptions > internal/span: fix utf16 column when span is line based < [release-branch.go1.12] go/analysis: disable embedded struct tag check < [release-branch.go1.12] go/analysis/passes/printf: fix big.Int false positive > internal/lsp: convert to the new location library > internal/lsp: stop providing insertText for completion items > go/packages/packagestest: add Exported as a type expectations can use > internal/lsp: make sure completion items are never null > internal/lsp: add a source.Package interface > tools/internal/lsp/protocol: generate LSP protocol types from source > tools/cmd/gopls: modify gopls to use automatcally generated types > go/ssa: fix import in comment > internal/lsp: adding utf16 handling to the span package > all: update golang.org/x/net dependency in go.mod > internal/lsp: using a non line based applyEdits in tests > internal/lsp: allow end of file byte offsets > internal/lsp: add cache for type information > internal/span: adding a source location package to unify the pos conversions > playground: use stdlib instead of appengine packages > godoc/env: replace with golangorgenv > internal/lsp: cache package metadata to minimize calls to packages.Load > cmd/godoc,cmd/gorename,refactor/rename: skip tests on GOOS=android > go/packages: skip tests for GOOS=android > internal/lsp: refactor type-checking code > internal/lsp: temporarily disable incremental changes > Revert "cmd/vet: add deepequalerrors" > internal/lsp: remove handling for circular imports > cmd/vet: add deepequalerrors > go/analysis/passes/printf: fix big.Int false positive > go/packages: make TestLoadImportsGraph more stable. > go/analysis/passes/deepequalerrors: check for reflect.DeepEqual on errors > internal/lsp: set severity levels for compiler errors and vet checks > go/packages: expand CompiledGoFiles workaround > go/packages: improve debug logging > cmd/guru: fix guessImportPath for Windows > cmd/golsp: remove golsp binary, since we've moved to gopls > go/gcexportdata: use a constant from a frozen package for testing > internal/lsp/cache: skip duplicate import of packages > internal/lsp: implement incremental updates to document > internal/lsp: absolutize paths when converting filenames to URIs > internal/lsp: create new cache for each analysis > go/gcexportdata: switch constant used in tests > godoc/dl, godoc/proxy, godoc/short, internal/memcache: delete > cmd/godoc: remove golang.org serving code > internal/lsp: use cached AST when parsing files, if available > internal/lsp: remove unused range parameter from computeTextEdits > internal/lsp: return an updated view after setting a file's contents > go/analysis: allow overriding V flag without code patches > godoc: don't clear user-set page mode for package builtin > godoc: remove unused CLI-only identifiers < [release-branch.go1.12] cmd/godoc: fix -url flag, add tests > cmd/godoc: fix -url flag, add tests > cmd/godoc: re-add documentation for flat presentation mode > all: add a go.mod file > internal/lsp: fix nil pointer exception on vendored packages > refactor/importgraph: get test to pass when run in modules mode > go/buildutil: get tests to pass when run from a module > go/analysis/singlechecker: use Stderr in flag.Usage > internal/lsp: change File.Read to a File.GetContent accessor > go/analysis/unitchecker: rewrite test in terms of packagestest > internal/lsp: allow ExecuteCommandParams to be nil > internal/lsp: remove error return values from interface "field" accessors > internal/lsp: add back check that a package was found for a given file > lsp/internal: fix incorrectly formatted file > go/analysis/passes/printf: add support for %w > internal/lsp/diff: fix bug that adds extra line to files on format > internal/lsp: use parallel parse files function > internal/lsp/cmd: set Serve.app when running with remote > refactor/rename: re-enable TestMoves on Windows > internal/lsp: copy fact support from go/analysis/internal/checker.go > go/analysis/analysistest: change error message checked in expectation > internal/lsp: changing server noun to serve verb Co-authored-by: Nick Wei <nwei@pivotal.io>

stamblerre · 2019-12-09T18:53:58Z

Re-opening this issue, as @ridersofrohan discovered that it is preventing us from correctly invalidating dependencies when go.mod files changed. We may need to modify the work-around here.

stamblerre · 2020-07-23T05:50:51Z

I believe that this was fixed by https://golang.org/cl/211058.

gopherbot added this to the Unreleased milestone Jun 8, 2019

gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 8, 2019

stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 12, 2019

stamblerre changed the title ~~x/tools/cmd/gopls: dependency leaks across modules~~ x/tools/gopls: dependency leaks across modules Jul 2, 2019

stamblerre mentioned this issue Jul 8, 2019

go.mod file is mixed when using vim-go in multiple projects fatih/vim-go#2383

Closed

stamblerre added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 8, 2019

stamblerre added NeedsFix The path to resolution is known, but the work has not been done. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Aug 12, 2019

dependabot-preview bot mentioned this issue Aug 14, 2019

build(deps): bump golang.org/x/tools from a2b3f7f to 9dba7ca gofunky/playground#250

Closed

gopherbot closed this as completed in golang/tools@5b18234 Aug 14, 2019

myitcv mentioned this issue Sep 4, 2019

deps: x/tools and gopls adb45749 govim/govim#487

Merged

stamblerre reopened this Dec 9, 2019

stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 10, 2019

stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 May 21, 2020

stamblerre mentioned this issue May 22, 2020

x/tools/gopls: support multi-module workspaces #32394

Closed

stamblerre added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 24, 2020

stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020

stamblerre closed this as completed Jul 23, 2020

stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.4 Jul 23, 2020

golang locked and limited conversation to collaborators Jul 23, 2021

gopherbot added the FrozenDueToAge label Jul 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: dependency leaks across modules #32499

x/tools/gopls: dependency leaks across modules #32499

fhs commented Jun 8, 2019 •

edited

stamblerre commented Aug 8, 2019

fhs commented Aug 9, 2019

stamblerre commented Aug 9, 2019

itchyny commented Aug 10, 2019

fhs commented Aug 10, 2019 •

edited

stamblerre commented Aug 12, 2019

gopherbot commented Aug 12, 2019

stamblerre commented Aug 12, 2019

fhs commented Aug 12, 2019

stamblerre commented Aug 12, 2019

gopherbot commented Aug 12, 2019

gopherbot commented Aug 13, 2019

stamblerre commented Aug 14, 2019

fhs commented Aug 14, 2019

stamblerre commented Dec 9, 2019

stamblerre commented Jul 23, 2020

x/tools/gopls: dependency leaks across modules #32499

x/tools/gopls: dependency leaks across modules #32499

Comments

fhs commented Jun 8, 2019 • edited

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

stamblerre commented Aug 8, 2019

fhs commented Aug 9, 2019

stamblerre commented Aug 9, 2019

itchyny commented Aug 10, 2019

fhs commented Aug 10, 2019 • edited

stamblerre commented Aug 12, 2019

gopherbot commented Aug 12, 2019

stamblerre commented Aug 12, 2019

fhs commented Aug 12, 2019

stamblerre commented Aug 12, 2019

gopherbot commented Aug 12, 2019

gopherbot commented Aug 13, 2019

stamblerre commented Aug 14, 2019

fhs commented Aug 14, 2019

stamblerre commented Dec 9, 2019

stamblerre commented Jul 23, 2020

fhs commented Jun 8, 2019 •

edited

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

fhs commented Aug 10, 2019 •

edited