Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/textproto: unclear statement about ReadContinuedLine #32493

Closed
pam4 opened this issue Jun 8, 2019 · 3 comments
Closed

net/textproto: unclear statement about ReadContinuedLine #32493

pam4 opened this issue Jun 8, 2019 · 3 comments
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@pam4
Copy link

pam4 commented Jun 8, 2019

From the documentation:

A line consisting of only white space is never continued.

I can't make sense of the above statement.

var txt string
txt += "A \n" // line 1
txt += "  \n" // line 2
txt += " B\n" // line 3
tp := textproto.NewReader(bufio.NewReader(strings.NewReader(txt)))
s, err := tp.ReadContinuedLine()
fmt.Printf("%q %v\n", s, err)

Prints "A  B" <nil> (https://play.golang.org/p/Bsrs8-5bAft).

Line 2 consists of only white space but it is "continued" (as it should be, I think).
I propose to clarify or remove the statement in question.

EDIT: It should probably read: "An empty line is never continued".

@FiloSottile FiloSottile added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 14, 2019
@FiloSottile FiloSottile modified the milestones: Gccgo, Go1.13 Jun 14, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@gopherbot
Copy link

Change https://golang.org/cl/185542 mentions this issue: net/textproto: corrected documentation of empty line handling

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@pam4
Copy link
Author

pam4 commented Jul 9, 2020

Is this lost in bureaucracy?
The CL is 6 words of documentation and has been sitting for a year with no feedback. I'm not familiar enough with the process here, but it seems far from ideal.

@ianlancetaylor
Copy link
Contributor

Sorry about that. I'm not sure why that change got lost.

@golang golang locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

6 participants