Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: extendslice contains n.SetLikely(false), which does nothing #32486

Closed
josharian opened this issue Jun 7, 2019 · 2 comments
Closed

cmd/compile: extendslice contains n.SetLikely(false), which does nothing #32486

josharian opened this issue Jun 7, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.14

Comments

@josharian
Copy link
Contributor

extendslice contains: nifneg.SetLikely(false). But the Likely flag on Node is boolean; setting it to false has no effect at all. To make it do something, we'd need to invert the condition and set it to true. But given that the body contains a panic-style call, I suspect we already do the right thing for likeliness, and we should just delete the call to SetLikely.

This issue is a reminder to investigate and either delete or fix the SetLikely call.

cc @martisch
@josharian josharian added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 7, 2019
@josharian josharian added this to the Go1.14 milestone Jun 7, 2019
@martisch
Copy link
Contributor

martisch commented Jun 7, 2019

Thanks for filling the reminder. Makes sense to remove for Go1.14 after confirming the branch layout is correct without it. I wonder if we have any way (or should have) to explicit communicate from front to backbend that an if is not taken.

@gopherbot
Copy link

Change https://golang.org/cl/195197 mentions this issue: cmd/compile: remove n.SetLikely(false), which does nothing

@golang golang locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@josharian @martisch @gopherbot