Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: gobind drops package function comments #32470

Closed
i9 opened this issue Jun 6, 2019 · 2 comments
Closed

x/mobile: gobind drops package function comments #32470

i9 opened this issue Jun 6, 2019 · 2 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@i9
Copy link

i9 commented Jun 6, 2019

What version of Go are you using (go version)?

$ go version
go version go1.11.10 darwin/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

gomobile bind to generate Android .aar and sources.jar

What did you expect to see?

Package level function comments are kept as javadoc

What did you see instead?

Package level function comments are ignored in generated java file
@gopherbot gopherbot added this to the Unreleased milestone Jun 6, 2019
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Jun 6, 2019
@i9
Copy link
Author

i9 commented Jun 6, 2019

identify the cause at bind/genjava.go

https://go-review.googlesource.com/c/mobile/+/181038 for review

@gopherbot
Copy link

Change https://golang.org/cl/181038 mentions this issue: bind/genjava: keep package function comments in java file

@hyangah hyangah closed this as completed Jun 8, 2019
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 10, 2019
@golang golang locked and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@i9 @dmitshur @hyangah @gopherbot