Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: expand '!' go module special mark #32435

Closed
zchee opened this issue Jun 4, 2019 · 2 comments
Closed

x/tools/internal/lsp: expand '!' go module special mark #32435

zchee opened this issue Jun 4, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone

Comments

@zchee
Copy link
Contributor

zchee commented Jun 4, 2019

What did you do?

Some LSP method results not expand ! go module mark.

What did you expect to see?

At lease, Definition result:
[{"uri":"file:///Users/zchee/go/pkg/mod/github.com/%21data%21dog/opencensus-go-exporter-datadog@v0.0.0-20190503082300-0f32ad59ab08/datadog.go","range":{"start":{"line":50,"character":5},"end":{"line":50,"character":12}}}]

It's included %21 actually ! uppercase go module special mark, not expanded.

What did you see instead?

[{"uri":"file:///Users/zchee/go/pkg/mod/github.com/!data!dog/opencensus-go-exporter-datadog@v0.0.0-20190503082300-0f32ad59ab08/datadog.go","range":{"start":{"line":50,"character":5},"end":{"line":50,"character":12}}}]

Build info

golang.org/x/tools/cmd/gopls
    golang.org/x/tools@(devel)
    golang.org/x/sync@v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=

Go info

go version devel +6f7542e4cb Fri May 31 23:00:43 2019 +0000 darwin/amd64

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/zchee/.cache/go-build"
GOENV="/Users/zchee/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/zchee/go"
GOPROXY="https://proxy.golang.org"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang"
CXX="/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD="/Users/zchee/go/src/golang.org/x/tools/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6_/10hjzx0d027_8rfblcw1lbm40000gp/T/go-build429931051=/tmp/go-build -gno-record-gcc-switches -fno-common"
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 4, 2019
@zchee zchee changed the title gopls: expand '!' go module special mark x/tools/internal/lsp: expand '!' go module special mark Jun 4, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 4, 2019
@zchee
Copy link
Contributor Author

zchee commented Jun 4, 2019

It should be handled client side?
If so, sorry noisy. Feel free to close it.

@zchee
Copy link
Contributor Author

zchee commented Jun 5, 2019

seems to handles client side. sorry noisy.
Close it.

@zchee zchee closed this as completed Jun 5, 2019
@golang golang locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Development

No branches or pull requests

2 participants