New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/build: Recognize .sx
as equivalent to .S
#32434
Comments
Seems reasonable to me. |
Hi, I am working with Go from past few months and I was thinking about contributing to Go. So if no one is working then I would like to work on this. |
After some code reading, I figured that I will need to update src/cmd/go/internal/work/exec.go and src/cmd/go/internal/work/gc.go mainly and some other places in internal/load accordingly. Can anyone explain how the go build works in an abstract way so that I can understand the working of current build toolchains and then add changes necessary for the issues? Thanks. |
For general questions like these please reach out to the forums here on the Questions wiki page. |
I understand that you are asking an abstract question, but it's a bit too abstract for me to know what the answer is. My first guess, without looking at the code, would be that this could be done entirely in the go/build package by handling ".sx" files like ".S" files. |
Change https://golang.org/cl/181699 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I tried to rename an assembly file from lowercase
.s
to capital.S
(PR) in order to use preprocessor directives in it.What did you expect to see?
Renaming the file from lowercase
.s
to capital.S
should cause the preprocessor directives to work.What did you see instead?
Some combination of git and the macos filesystem (case-insensitive but case preserving) made the rename difficult. I had to change the base name of the file to make sure the rename "stuck".
This worked, but it would have been simpler if go recognized the suffix
.sx
for assembly files that use the preprocessor. This suffix is supported by gcc.The text was updated successfully, but these errors were encountered: