Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: document interaction with test sources #32408

Open
cosmin-mogos opened this issue Jun 3, 2019 · 7 comments
Open

cmd/vet: document interaction with test sources #32408

cosmin-mogos opened this issue Jun 3, 2019 · 7 comments
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@cosmin-mogos
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.12.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/cosmin/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/cosmin/go:/home/cosmin/dev/git"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go-1.12.5"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.12.5/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build217071151=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Run go vet something_test.go

What did you expect to see?

Successful execution

What did you see instead?

isomething_test.go: undefined: MyModel

even if MyModel is defined and go test executes successfully.

It may be a regression of #26797
@cosmin-mogos cosmin-mogos mentioned this issue Jun 3, 2019
Closed
@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2019

Run go vet something_test.go

Does this reproduce for all _test.go files, or just a specific one?

@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2019

The arguments to go vet are a list of packages. Per https://tip.golang.org/cmd/go/#hdr-Package_lists_and_patterns:

As a special case, if the package list is a list of .go files from a single directory, the command is applied to a single synthesized package made up of exactly those files, ignoring any build constraints in those files and ignoring any other files in the directory.

So go vet is correct to treat references to symbols from other files as unresolved.

@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2019

It seems like the underlying problem you're stumbling on here is that the vet documentation isn't particularly clear on when and how the contents of _test.go files are vetted. Perhaps we can at least improve the documentation.

@bcmills bcmills changed the title go vet fails with undefined, even when go test works cmd/vet: document interaction with test sources Jun 3, 2019
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 3, 2019
@bcmills bcmills added this to the Go1.13 milestone Jun 3, 2019
@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2019

CC @ianthehat @matloob @jayconrod

@cosmin-mogos
Copy link
Author

Thank you for the fast reply, I have completely missed this detail.

@maruel
Copy link
Contributor

maruel commented Jun 5, 2019

@bcmills I found this issue while trying to understand what the hell was happening for my project (panicparse).

In the end, the issue I was seeing had the following characteristics:

  • A new global in main.go
  • Use it in main_test.go
  • Use +build options in other files, in my case one with race, one with !race.
  • Use go vet ./...
  • I was not able to reproduce locally.

The failure looked like this: https://travis-ci.org/maruel/panicparse/jobs/541748155 on go version go1.12.5 linux/amd64.

go vet ./...
# github.com/maruel/panicparse/cmd/panic [github.com/maruel/panicparse/cmd/panic.test]
cmd/panic/main_test.go:15:3: undefined: stdErr
cmd/panic/main_test.go:17:4: undefined: stdErr
cmd/panic/main_test.go:32:7: undefined: raceEnabled

After much fiddling, I realized that I was caching the project's directory in travis, and this was somehow causing the problem. Tweaking the cache entry fixed it for me.

I'm noting this in case others are experiencing similar issues.

@tx0c

This comment has been minimized.

Sign in to view
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@adonovan adonovan added the Analysis Issues related to static analysis (vet, x/tools/go/analysis) label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
8 participants
@maruel @rsc @andybons @bcmills @adonovan @gopherbot @cosmin-mogos @tx0c