Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: Docs imply that methods can take structs #32376

Open
bemasc opened this issue May 31, 2019 · 1 comment
Open

x/mobile: Docs imply that methods can take structs #32376

bemasc opened this issue May 31, 2019 · 1 comment
Labels
Documentation mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bemasc
Copy link
Contributor

bemasc commented May 31, 2019

The gomobile docs say it supports

Any function type all of whose parameters and results have
supported types.

I think this is incorrect: gomobile does not support code like the following

type S struct {
  X int
}

type I interface {
  ReadS(s S)
}

Specifically, it does not appear to support passing a struct by value to a function. (Passing an interface, or a pointer to the struct, is supported.)

Please update the docs to reflect this limitation.

@gopherbot gopherbot added this to the Unreleased milestone May 31, 2019
@gopherbot gopherbot added mobile Android, iOS, and x/mobile Documentation labels May 31, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Jun 6, 2019

/cc @hyangah @eliasnaur

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants