Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: strange autocompletion behaviour for function arguments #32375

Closed
stamblerre opened this issue May 31, 2019 · 6 comments
Closed

x/tools/gopls: strange autocompletion behaviour for function arguments #32375

stamblerre opened this issue May 31, 2019 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Forked from microsoft/vscode-go#2549.
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label May 31, 2019
@stamblerre stamblerre mentioned this issue May 31, 2019
Closed
@muirdm
Copy link

muirdm commented Jun 3, 2019

I can't reproduce this. Could you reproduce it @stamblerre?

@muirdm
Copy link

muirdm commented Jun 5, 2019

@fotonmoton can you try upgrading gopls and see if you can still reproduce this? I wasn't able to reproduce.

@fotonmoton
Copy link

fotonmoton commented Jun 5, 2019 •
edited

@muirrn yeah, no problem, how can i do it? Just go get -u golang.org/x/tools/cmd/gopls will be sufficient? I'm a bit new to go :)

@fotonmoton
Copy link

@muirrn get the same results. How can I supply a bit more info? and what information is needed? When I was installing vscode-go I install all go dependencies, maybe some packages in conflict with each other?

@stamblerre
Copy link
Contributor Author

To update, run go get -u golang.org/x/tools/gopls@master.

@muirrn: I am actually able to reproduce this. Maybe this is something VSCode-specific, but quite clearly in the TextEdit there are no parentheses.

@stamblerre stamblerre changed the title x/tools/cmd/gopls: strange autocompletion behaviour for function arguments x/tools/gopls: strange autocompletion behaviour for function arguments Jul 2, 2019
@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Suggested Issues that may be good for new contributors looking for work to do. labels Jul 10, 2019
@stamblerre stamblerre added help wanted and removed Suggested Issues that may be good for new contributors looking for work to do. labels Aug 8, 2019
@stamblerre
Copy link
Contributor Author

I'm no longer able to reproduce this issue with the more recent improvements to gopls. Thanks @muirrn!

Closing this issue now. @fotonmoton: Please open a new issue if something else comes up.

@golang golang locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@stamblerre @fotonmoton @gopherbot @muirdm