Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link/internal/ld: TestMachoIssue32233 broken on darwin-amd64 builders #32373

Closed
bcmills opened this issue May 31, 2019 · 3 comments
Closed

cmd/link/internal/ld: TestMachoIssue32233 broken on darwin-amd64 builders #32373

bcmills opened this issue May 31, 2019 · 3 comments
Labels
FrozenDueToAge OS-Darwin release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented May 31, 2019

https://build.golang.org/log/b7e0356fc8f515a200229d94f29a72bf9970ce96

--- FAIL: TestMachoIssue32233 (0.65s)
    dwarf_test.go:126: build: # cmd/link/internal/ld/testdata/issue32233/lib
        warning: unknown warning option '-Wunguarded-availability-new'; did you mean '-Wpartial-availability'? [-Wunknown-warning-option]
        go build cmd/link/internal/ld/testdata/issue32233/lib: C compiler warning promoted to error on Go builders
        
    dwarf_test.go:127: build error: exit status 1
FAIL
FAIL	cmd/link/internal/ld	3.216s

The test was introduced in CL 178726 and has been broken on those builders since.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Darwin release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 31, 2019
@bcmills bcmills added this to the Go1.13 milestone May 31, 2019
@thanm
Copy link
Contributor

thanm commented Jun 3, 2019

Should be fixed with https://go-review.googlesource.com/c/go/+/179837

@thanm thanm closed this as completed Jun 3, 2019
@thanm
Copy link
Contributor

thanm commented Jun 3, 2019

From the dashboard it looks like there are a couple of other builders that are consistently failing with timeouts (nocgo, 386). Do we have issues for these?

@bcmills
Copy link
Contributor Author

bcmills commented Jun 3, 2019

I believe that the two broken darwin builders are #31705.

@golang golang locked and limited conversation to collaborators Jun 2, 2020
@rsc rsc unassigned thanm Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Darwin release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @thanm