Skip to content

x/tools/go/packages: several fields in Package struct are explained in terms of deprecated Load constants #32364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dominikh opened this issue May 31, 2019 · 1 comment
Closed

x/tools/go/packages: several fields in Package struct are explained in terms of deprecated Load constants #32364

dominikh opened this issue May 31, 2019 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Unreleased

Comments

@dominikh
Copy link
Member

C.f. https://godoc.org/golang.org/x/tools/go/packages#Package

The documentation of the fields Types and Syntax refer to the deprecated constants LoadTypes, LoadSyntax, and LoadAllSyntax. These fields should likely be explained in terms of the new Need constants instead.

Somewhat related issue I didn't feel like filing separately: the LoadMode type and the constants of said type are no longer grouped in godoc. LoadMode's documentation still refers to "the bits below", but below LoadMode follows the documentation of Package.

/cc @matloob
@dominikh dominikh added the Documentation Issues describing a change to documentation. label May 31, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/179741 mentions this issue: go/packages: update documentation for Package.Types and Package.Syntax

@golang golang locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dominikh @gopherbot