Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: 'go generate' command fails on windows #32349

Closed
alexbrainman opened this issue May 31, 2019 · 2 comments
Closed

x/sys/windows: 'go generate' command fails on windows #32349

alexbrainman opened this issue May 31, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Unreleased

Comments

@alexbrainman
Copy link
Member

I am using

commit ad28b68e88f12448a1685d038ffea87bbbb34148 (HEAD -> master, origin/master, origin/HEAD)
Author: Takuto Ikuta <tikuta@google.com>
Date:   Fri May 24 22:45:01 2019 +0900

    windows: make zsyscall_windows.go generatable on non-WSL env

    mkerrors.bash requires a Windows host, as it hard-codes paths like
    /mnt/c/Program Files (x86)/Windows Kits.
    But this does not allow to generate in non-WSL env.

    Currently mkerrors.bash runs earlier than mksyscall_windows.go
    when we run `go generate` and it fails on non-WSL env.
    So zsyscall_windows.go is not generated in that case.

    To fix that, I reoreder of code generation in this CL so that we can
    generate zsyscall_windows.go in non-WSL env.

    Also update error message in mkerrors.bash.

    Change-Id: I04eccdbfe1e1ff56f8c405250f0724000d66d579
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/178781
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>

version of x/sys repo on windows.

What did you do?

I run these commands

cd %GOPATH%\src\golang.org\x\sys\windows
go generate

What did you expect to see?

I expected my commands to succeed.

What did you see instead?

They fail with this error

gen.go:9: running "./generate.bash": fork/exec ./generate.bash: %1 is not a valid Win32 application.

Alex
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2019
@ALTree ALTree added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows labels May 31, 2019
@gopherbot
Copy link

Change https://golang.org/cl/179580 mentions this issue: Revert "windows: make zsyscall_windows.go generatable on non-WSL env"

@gopherbot
Copy link

Change https://golang.org/cl/179582 mentions this issue: windows: delete mkerrors.go

gopherbot pushed a commit to golang/sys that referenced this issue May 31, 2019
@alexbrainman
Revert "windows: make zsyscall_windows.go generatable on non-WSL env"
46560c3 
This reverts commit ad28b68.

Reason for revert: It completely breaks 'go generate' on windows

Update golang/go#32349

Change-Id: I4bedc6cf5130eb48c18c3208c8029433407430e4
Reviewed-on: https://go-review.googlesource.com/c/sys/+/179580
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@golang golang locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ALTree @gopherbot @alexbrainman