Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/goimports: strict ordering of local packages #32301

Closed
romikser opened this issue May 29, 2019 · 3 comments
Closed

x/tools/cmd/goimports: strict ordering of local packages #32301

romikser opened this issue May 29, 2019 · 3 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@romikser
Copy link

Support for multiple packages was added here.
It would be good to be able to specify strict order of local packages.
For example if I specify local packages as mycompany.com/foo,mycompany.com/bar mycompany.com/foo imports will always be placed above mycompany.com/bar packages.
@gopherbot gopherbot added this to the Unreleased milestone May 29, 2019
@julieqiu julieqiu changed the title x/tools/cmd/goimports: Strict ordering of local packages x/tools/cmd/goimports: strict ordering of local packages May 29, 2019
@julieqiu julieqiu added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 29, 2019
@julieqiu
Copy link
Member

/cc @bradfitz @josharian

@josharian
Copy link
Contributor

I dunno; I'd rather not. The less configuration, the better. As it stands, you won't get code churn if two people set up their flags differently.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@heschi
Copy link
Contributor

heschi commented Nov 7, 2019

We don't want to add more configuration to goimports, and this hasn't attracted much attention, so closing. Please comment if you disagree.

@heschi heschi closed this as completed Nov 7, 2019
@golang golang locked and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@josharian @julieqiu @romikser @gopherbot @heschi