Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: tests failing on linux-amd64-longtest [1.12 backport] #32295

Closed
gopherbot opened this issue May 28, 2019 · 5 comments
Closed

cmd/go: tests failing on linux-amd64-longtest [1.12 backport] #32295

gopherbot opened this issue May 28, 2019 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.6

Comments

@gopherbot
Copy link
Contributor

@jayconrod requested issue #31946 to be considered for backport to the next 1.12 minor release.

@gopherbot Please open backport issue to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 28, 2019
@gopherbot gopherbot mentioned this issue May 28, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.6 milestone May 28, 2019
@jayconrod
Copy link
Contributor

CL 176558 fixes another link error that occurs when -coverpkg covers multiple main packages, seen in #31946 and in #32150. It's a low risk one-line change, and there isn't a good workaround (aside from not using -coverpkg).

CL 164877 and CL 168200 are fixes for closely related problems, and these have already been backported.

@jayconrod
Copy link
Contributor

(Sorry the title is a little misleading. #32150 is the user-reported issue and the motivation for cherry-picking. It was already fixed at tip for a test failure in #31946, which this issue is based on.)

@jayconrod jayconrod mentioned this issue May 28, 2019
Closed
@julieqiu
Copy link
Member

Approving since this is a serious problem with no workaround. Please follow the instructions at https://github.com/golang/go/wiki/MinorReleases to create the cherrypick CL.

@julieqiu julieqiu added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 30, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/179677 mentions this issue: [release-branch.go1.12] cmd/go: force -coverpkg main packages to be built as libraries

@keegancsmith keegancsmith mentioned this issue Jun 5, 2019
Closed
@gopherbot
Copy link
Contributor Author

Closed by merging 451e6d6 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Jun 7, 2019
@dmitshur
[release-branch.go1.12] cmd/go: force -coverpkg main packages to be b…
451e6d6 
…uilt as libraries

This fixes TestScript/cover_pkgall_multiple_mains, which started
failing after CL 174657.

When compiling main packages with coverage instrumentation
(e.g., for -coverpkg all), we now pass -p with the full import path
instead of '-p main'. This avoids link errors
'duplicate symbol main.main (types 1 and 1)'.

Fixes #32295
Updates #31946
Updates #32150

Change-Id: Id147527b1dbdc14bb33ac133c30d50c250b4365c
Reviewed-on: https://go-review.googlesource.com/c/go/+/176558
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 3b8c804)
Reviewed-on: https://go-review.googlesource.com/c/go/+/179677
@golang golang locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.6
Development

No branches or pull requests
3 participants
@jayconrod @julieqiu @gopherbot