Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: unicode/utf8 package docs are not renderable #32275

Closed
kevinburke opened this issue May 28, 2019 · 6 comments
Closed

x/tools/cmd/godoc: unicode/utf8 package docs are not renderable #32275

kevinburke opened this issue May 28, 2019 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone

Comments

@kevinburke
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version devel +a326bc6df2 Wed May 22 17:22:46 2019 +0000 darwin/amd64

Does this issue reproduce with the latest release?

No

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="off"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/kevin/Library/Caches/go-build"
GOENV="/Users/kevin/Library/Preferences/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/kevin"
GOPROXY="direct"
GOROOT="/Users/kevin/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/Users/kevin/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sf/fsn3_vgd0n98r0jb86bgp83r0000gn/T/go-build304907158=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +a326bc6df2 Wed May 22 17:22:46 2019 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +a326bc6df2 Wed May 22 17:22:46 2019 +0000
uname -v: Darwin Kernel Version 17.7.0: Wed Feb 27 00:43:23 PST 2019; root:xnu-4570.71.35~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G6030
lldb --version: lldb-1000.11.38.2
  Swift-4.2

What did you do?

What did you expect to see?

Package text for utf8

What did you see instead?

/src/unicode/utf8/utf8.go:28:8: expected ';', found b00000000 (and 10 more errors)

I cannot reproduce this on tip.golang.org/pkg/unicode/utf8 (maybe it is Darwin specific, or are we supposed to be using that now, or??)

@gopherbot gopherbot added this to the Unreleased milestone May 28, 2019
@agnivade
Copy link
Contributor

Works here on linux/amd64. Possibly darwin specific.

@agnivade agnivade added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin labels May 28, 2019
@josharian
Copy link
Contributor

The unicode/utf8 package uses binary literals, which were introduced in 1.13. I suspect that somehow or other you are using a 1.12 toolchain or a 1.12 go/types.

@bradfitz
Copy link
Contributor

I also can't reproduce.

I see you're not using modules. (GO111MODULE="off" in your go env output, and May 22 build predates flipping it on by default right?). It's possible that your build of "tip" x/tools/cmd/godoc is picking up a not-tip dependency from $GOPATH.

@kevinburke
Copy link
Contributor Author

I'm on Darwin. I just pulled down Go tip (0f897f9), as of ten minutes ago, compiled it using Go 1.12 as a bootstrap, used that to recompile x/tools and I can still reproduce the error.

x/tools only depends on the standard library, x/net and x/sync, and all of those are pointing to their most current versions. I'm not sure go/types can be out of date, it is provided by the Go googlesource.com repository and I just downloaded/recompiled that.

I cannot reproduce the error with the x/website/cmd/golangorg binary.

@bradfitz
Copy link
Contributor

Just tried tip on my Mac and still can't reproduce.

@kevinburke
Copy link
Contributor Author

Ugh, apologies... the Go tool was up to date, and godoc was being recompiled, but somehow an old godoc binary snuck into /usr/local/bin ahead of $GOPATH/bin and I was running that, instead. If you are hitting this error double check your godoc binary was not compiled using 1.11.

@golang golang locked and limited conversation to collaborators May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Development

No branches or pull requests

5 participants