Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue number in branch name #32263

Closed
Windsooon opened this issue May 27, 2019 · 2 comments
Closed

Add issue number in branch name #32263

Windsooon opened this issue May 27, 2019 · 2 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@Windsooon
Copy link

The golang docs make_branch didn't mention what branch name we should use when we create a new branch for an issue. (I know we added the issue number to the commit messages). Learned from the Python and Django communities, I suggest we use bog-XXXX as the branch name (short for "bug of golang") for the issue already created. IMO, that will make maintainers easier to review the PR.

@martisch
Copy link
Contributor

martisch commented May 27, 2019

The local branch name is not shown in the Go gerrit instance: https://go-review.googlesource.com/ (where code review and approval happens) as normal contributions are always made on the master branch into which they are later cherry picked. It does not seem to make it easier for maintainers and constrains the freedom of contributors to have their own system to organizer their CLs. AFAIK the bots use the commit message to associate the CLs with Go issue numbers.

Could you elaborate how standardizing local branch names will help maintainers?

@martisch martisch added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 27, 2019
@ianlancetaylor
Copy link
Member

I don't think there is anything to do here. You can choose any branch name you like. It won't make any difference to the code review process or to the master repository. Closing the issue, but please comment if you disagree.

@golang golang locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants