Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: mkerrors_windows.sh is missing #32252

Closed
alexbrainman opened this issue May 26, 2019 · 2 comments
Closed

syscall: mkerrors_windows.sh is missing #32252

alexbrainman opened this issue May 26, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@alexbrainman
Copy link
Member

Looking at current $GOROOT/src/syscall/zerrors_windows.go file. It starts with

// mkerrors_windows.sh -m32
// Code generated by the command above; DO NOT EDIT.

but there is mkerrors_windows.sh file in $GOROOT/src/syscall directory.

I suspect, mkerrors_windows.sh did not make Great Move c007ce8

We should restore mkerrors_windows.sh.

Alex
@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@julieqiu
Copy link
Member

/cc @rsc @ianlancetaylor @bradfitz

@bradfitz bradfitz added this to the Unplanned milestone May 28, 2019
@alexbrainman
Copy link
Member Author

I suspect, mkerrors_windows.sh did not make Great Move c007ce8

I was wrong. I deleted mkerrors_windows.sh myself in https://codereview.appspot.com/41060044

syscall: replace mksyscall_windows.pl with mksyscall_windows.go

Not many windows users have perl installed. They can just use
standard go tools instead. Also mkerrors_windows.sh script
removed - we don't add any new "unix" errors to windows
syscall package anymore.

Apparently I decided we won't be making changes to zerrors_windows.go.

I suppose it is fine to stay as is. So closing this issue.

Sorry to waste your time.

Alex

@golang golang locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@bradfitz @julieqiu @gopherbot @alexbrainman