Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: automatically tidy go.sum #32231

Open
rsc opened this issue May 24, 2019 · 2 comments
Open

cmd/go: automatically tidy go.sum #32231

rsc opened this issue May 24, 2019 · 2 comments
Labels
modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@rsc
Copy link
Contributor

rsc commented May 24, 2019

Now that we can authenticate new entries in go.sum,
there is less concern about keeping old ones around
that are not part of the current module graph.
If we update go.mod from v0.1.0 to v0.2.0 of a module
and v0.1.0 is no longer referenced in the build graph,
we should probably drop v0.1.0 from the go.sum.

Not sure about Go 1.13 vs Go 1.14.
Depends on how much work it is.
@rsc rsc added this to the Go1.13 milestone May 24, 2019
@rsc
Copy link
Contributor Author

rsc commented May 24, 2019

/cc @bcmills @jayconrod

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@bcmills
Copy link
Contributor

bcmills commented May 29, 2019

Given that we're in the code freeze, and that over-retaining checksums doesn't seem to cause any significant harm in the short term, I think this belongs in 1.14 regardless of size.

@bcmills bcmills modified the milestones: Go1.13, Go1.14 May 29, 2019
@hoshir hoshir mentioned this issue Jul 31, 2019
Merged
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@rsc @bcmills @julieqiu