Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goproxy-forward-util-succuss-or-last #32198

Closed
wants to merge 1 commit into from
Closed

goproxy-forward-util-succuss-or-last #32198

wants to merge 1 commit into from

Conversation

storyicon
Copy link

GOPROXY on the master node promises developers this:

For each request, the go command tries each proxy in sequence,
only moving to the next if the current proxy returns a 404 or 410 HTTP response.

But after a rough look at the code, I think the code on the current master node may not work as expected.
What's more, I think this logic is not in line with the developer's expectations, GOPROXY should try all the proxies in its list until one of them does not return an error.
Even if any of the proxies in the GOPROXY list have an error, then golang’s attempt to other agents should not be interrupted.
The fact is that most goproxy providers (such as athens, goproxy.io) return 500 when the server fails to pull locally.
More about it: https://github.com/storyicon/gos/blob/master/docs/on-goproxy.md

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label May 23, 2019
@storyicon storyicon closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants