Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: provide portrait screen mode friendly style for mobile devices #32183

Closed
hyangah opened this issue May 22, 2019 · 4 comments
Closed

x/website: provide portrait screen mode friendly style for mobile devices #32183

hyangah opened this issue May 22, 2019 · 4 comments
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented May 22, 2019

Browse https://tip.golang.org/cmd/go
from mobile devices, on portrait mode

Particularly the two column TOC is not ideal.

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

Chrome on android
@agnivade
Copy link
Contributor

I had done some work (CL 129135) to generate the TOC at server side for the /search page. For the rest of the pages, AFAIR, the TOC is hard-coded to be 2 columns. Is this issue just about adjusting the no. of columns in TOC for mobile devices or are there other aspects to be tacked ?

@andybons @dmitshur - Is the TOC rendering logic going to be looked at in the new website revamp ?

@andybons andybons changed the title doc: provide portrait screen mode friendly style for mobile devices x/website: provide portrait screen mode friendly style for mobile devices May 22, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 22, 2019
@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 22, 2019
@andybons
Copy link
Member

@agnivade yes it’s likely we’ll look at it at some point.

@hyangah
Copy link
Contributor Author

hyangah commented May 22, 2019

@agnivade I think switching to the single column mode when the width is not sufficient is sufficient for this bug.

I wished we could do something about the pre-formatted text width too but I guess I can live with it.

@seankhliao
Copy link
Member

Seems no longer relevant now that it uses pkg.go.dev

@golang golang locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@andybons @agnivade @hyangah @gopherbot @seankhliao