Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: tip serving 404s for lib/godoc/go-logo-blue.svg #32151

Closed
bcmills opened this issue May 20, 2019 · 3 comments
Closed

x/website: tip serving 404s for lib/godoc/go-logo-blue.svg #32151

bcmills opened this issue May 20, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented May 20, 2019

This logo image appears in godoc pages on tip (such as https://tip.golang.org/cmd/go/), but the server is currently producing 404s for it.

CL 178137 (#9936) seems to be closely related (CC @katiehockman).
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 20, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 20, 2019
@gopherbot
Copy link

Change https://golang.org/cl/178138 mentions this issue: content/static, internal/dl: update header on downloads page

@andybons
Copy link
Member

Not fixed yet. Need to update go.mod in x/website to pull in https://go.googlesource.com/tools/+/d1a3278ee74994e9aa609e9e711c616bba677d5d

@andybons andybons reopened this May 20, 2019
@andybons
Copy link
Member

Fixed by https://go-review.googlesource.com/c/website/+/178237

@golang golang locked and limited conversation to collaborators May 19, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static, internal/dl: update header on downloads page
811bb9d 
The downloads page does not share the root template as other pages.
Update it to use the new header markup.

Also fixes an issue where static.go did not contain the Go logo and
updates the downloads page to be consistent with others when visiting
from China.

Updates golang/go#9936
Fixes golang/go#32151

Change-Id: Ic6d703ccb8fe5cf93d74256bac41ecad69a78e72
Reviewed-on: https://go-review.googlesource.com/c/website/+/178138
Reviewed-by: Katie Hockman <katie@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @bcmills @gopherbot