Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/shiny/driver/gldriver: add missing modifier key codes #32131

Closed
smasher164 opened this issue May 18, 2019 · 3 comments
Closed

x/exp/shiny/driver/gldriver: add missing modifier key codes #32131

smasher164 opened this issue May 18, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@smasher164
Copy link
Member

Currently the right control key and right command keys are not (accurately) represented in the mods struct. After testing for key events, I've determined that

  • key.ControlRight should be represented by the flags 33<<13 | 0x100, the code C.kVK_RightControl, and modifier key.ModControl.
  • kVK_RightCommand should be represented by the flags 1<<20 | 0x110, the code 0x36 (does not appear in Events.h), and modifier key.ModMeta.
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2019
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 18, 2019
@smasher164
Copy link
Member Author

Is there something in particular that needs investigating? The items I mentioned are currently TODOs in shiny/driver/gldriver/cocoa.go. I understand if there is a bandwidth issue with having to review shiny code. I can submit a CL that makes the above changes if desired.

@gopherbot
Copy link

Change https://golang.org/cl/188378 mentions this issue: shiny/driver/gldriver: add missing modifier key codes on cocoa

@dmitshur
Copy link
Contributor

dmitshur commented Aug 6, 2019

Is there something in particular that needs investigating?

It's just the very first triage state an issue goes through. See https://golang.org/wiki/HandlingIssues#issue-states for more information.

Thanks for reporting and fixing this!

200sc pushed a commit to oakmound/shiny that referenced this issue Aug 20, 2019
@smasher164 @200sc
shiny/driver/gldriver: add missing modifier key codes on cocoa
0441991 
key.ControlRight and kVK_RightCommand were found by looking in
HIToolbox/Events.h as well as experimenting with Karabiner-Elements.

Fixes golang/go#32131.

Change-Id: I90c76a3983109cdc2d0a645d7955b631d94ee2ee
Reviewed-on: https://go-review.googlesource.com/c/exp/+/188378
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@golang golang locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @smasher164