Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: TestVerifyHostnameResumed failing on longtest builder #32090

Closed
bradfitz opened this issue May 16, 2019 · 4 comments
Closed

crypto/tls: TestVerifyHostnameResumed failing on longtest builder #32090

bradfitz opened this issue May 16, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bradfitz
Copy link
Contributor

https://build.golang.org/log/1eff95520436e93eb2b0adee96417c7776dc6384

--- FAIL: TestVerifyHostnameResumed (1.53s)
    --- FAIL: TestVerifyHostnameResumed/TLSv13 (0.51s)
        tls_test.go:381: Subsequent connection unexpectedly didn't resume
FAIL
FAIL	crypto/tls	2.430s

It started at seemingly unrelated https://go-review.googlesource.com/c/go/+/176925 (cmd/go) and persisted the following three commits.

Does this test depend on the network? Did some peer change its behavior?

@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 16, 2019
@bradfitz bradfitz added this to the Go1.13 milestone May 16, 2019
@FiloSottile
Copy link
Contributor

Yeah the GFEs started bundling session tickets with the first flight, I think. Sent a fix.

@bradfitz
Copy link
Contributor Author

Sent a fix

Where? I don't see one at https://go-review.googlesource.com/q/owner:filippo%2540golang.org

@gopherbot
Copy link

Change https://golang.org/cl/177877 mentions this issue: crypto/tls: fix TestVerifyHostnameResumed

@FiloSottile
Copy link
Contributor

remote: The push has been rejected because we detect that it contains a private
remote: key. Please check the following commands and confirm that it's
remote: intentional:

https://go-review.googlesource.com/c/go/+/177877

@golang golang locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants