-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: work around insecure redirects for domains hosted on GitHub Pages #32071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(It would be nice to ask GitHub support why on Earth they are doing that, btw. It's bad for any client, not just the go command.) |
I'm curious what I'm doing wrong here. (I'm the Googler responsible for the Go googlemaps project.) I set up redirects in https://github.com/googlemaps/googlemaps.github.io/blob/master/maps/index.html to point to https URLs. Hints on how I can fix this gladly accepted. |
There is an interesting clue in isaacs/github#289 (comment):
|
Reopening to consider workarounds, but I'd really rather GitHub fix their redirects instead. |
If -insecure is not being used and we see https://foo redirect to http://foo/ (that is, the only deltas are |
Yep, that seems like a plausible workaround — it's small, doesn't hard-code information specific to GitHub, and doesn't require that we change the initial URL. |
We deployed a fix for this. Let us know if it has resolved the issue you were seeing. |
This is indeed fixed, thank you @mastahyeti! |
Apologies all..we are having to revert the change for now. We are looking into an issue it caused. |
Can you all check this again? A second attempt (without the bug 🤞) was deployed late last week. |
@ptoomey3, it seems to be working again. Thanks!
|
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
I'd expect the command to succeed. It works on Go 1.12.
What did you see instead?
The text was updated successfully, but these errors were encountered: