Change https://golang.org/cl/177601 mentions this issue: go/analysis/passes/printf: improve support for %w

Weren't part of the errors changes reverted in master? Just want to double-check that we don't add checks to vet that don't reflect the released behavior of fmt.

The %w format was retained, with some slight modification to make it less of a special case:
#29934 (comment) (decision)
https://golang.org/cl/176998 (updated %w implementation)

@neild any update on this?

https://go-review.googlesource.com/c/tools/+/177601

Hello @neild, this is a kind ping to check on this as this Jonathan reviewed and +2'd it and the associated CL is marked for Go1.13 which will soon be released. Thank you!

So, go1.13, go vet doesn't say anything about "%w" in a Sprintf for example. Is it expected behavior?

package main

import (
	"errors"
	"fmt"
)

var (
	ErrOne = errors.New("one error")
	ErrTwo = errors.New("two error")
)

func main() {

	var (
		err = fmt.Errorf("double wrap: %w, and %w", ErrOne, ErrTwo)
		str = fmt.Sprintf("double wrap: %w, and %w", ErrOne, ErrTwo)
	)

	fmt.Println(err)
	fmt.Println(str)
}

play.golang.org

$ go vet main.go

$ go version
go version go1.13.3 linux/amd64

This should be fixed in the 1.14 release (and the beta coming out soon).