Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: error line highlighting broken with multi-file programs #32064

Open
bradfitz opened this issue May 15, 2019 · 2 comments
Open

x/playground: error line highlighting broken with multi-file programs #32064

bradfitz opened this issue May 15, 2019 · 2 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

With the new support for multiple files (#32040), the error highlighting is broken (sometimes):

https://play.golang.org/p/S5z9R-mbAzj

x

/cc @ysmolsky @dmitshur
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 15, 2019
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2019
@dmitshur
Copy link
Contributor

Previously, there was only one file and so the line number was the only thing that mattered. Now, we'll need to have logic that maps a file:line pair to a single line number of the combined txtar file.

That logic can be either in the frontend or backend (but backend is probably easier, since it's Go code).

@ldb ldb mentioned this issue May 24, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/180117 mentions this issue: playground: support error line highlighting for multi-file program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot