-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: occasional hangs in TestCgoCallbackGC #32023
Comments
I noticed that the most recent failure on the power9 builder has a suspicious output file. It is missing the normal header information from the buildlet. It should be:
But instead shows:
Almost like it didn't rebuild the toolchain before testing the packages? |
I have a hunch that this change https://go-review.googlesource.com/c/go/+/339989 might fix the problem. |
Unfortunately it does not seem to have. (That change was merged Oct. 26.)
2021-11-30T20:04:58-7ccbcc9/linux-ppc64le-buildlet |
2021-12-13T16:42:31-4b3d8d1/linux-ppc64le-power9osu |
This is still ongoing in the builders — and note that |
Could it be that it is simply slow? It runs 200 GCs, while the system may be under load running other tests (it has |
Change https://golang.org/cl/373614 mentions this issue: |
The test checks RUNTIME_TESTING_SHORT, whereas the test runner actually set RUNTIME_TEST_SHORT. Check the correct one. Updates #32023. Change-Id: Ie8ab00e1f5b8c02112a9aa1ee0e56028185c8a44 Reviewed-on: https://go-review.googlesource.com/c/go/+/373614 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This hasn't happened again since 2021-12-13, but unfortunately it's rare enough that that doesn't give us much signal on whether Cherry's change fixed it. |
Given how rare this is and the likelihood that this test was just slow and we accidentally weren't filtering it out, I'm going to drop release-blocker. |
Given the plausible fix, should we go ahead and close the issue until/unless it recurs? |
Sounds good to me. |
(CC @golang/runtime) |
Looks like the test hung for some reason.
https://build.golang.org/log/e9e9a00d8fbae5c7ffb803d871b86982849c08ea
CC @aclements @mknyszek
The text was updated successfully, but these errors were encountered: