-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: linux-arm builder intermittently failing TestPhysicalMemoryUtilization #32010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for pointing this out and creating an issue. I've seen this before and it should be resolved sooner rather than later. The test likely needs to be tweaked or revamped because of the new scavenger, or maybe if #32012 is fixed it won't really be relevant anymore. I'll update this issue when I understand better what to do about this test. |
OK so after thinking about this for a bit, and looking over the failures (which are all just failures due to rising slightly above the threshold), I think we should just raise the threshold. The test is still useful, but the scavenging policy now is to retain a 10% overhead of RSS over the heap goal, which means that picking 10% as the test's threshold is probably not reasonable, especially since the scavenger isn't guaranteed to finish by the time the test actually checks what the utilization is. The test is still useful though, to ensure the scavenger is actually doing its job, but there's no guarantee anymore that it'll be under 10%. We could sleep to ensure the scavenger runs for long enough with a worst-case pace to ensure we get close to or below the threshold, but adding more time to Instead, increasing the threshold just accounts for any variability in the scavenger being able to complete its goal. It should be extremely likely for the test's utilization to be under 15%, especially with the fix to #32012, so I think we should just set it to that. Thoughts? |
Change https://golang.org/cl/177237 mentions this issue: |
This problem has been happening intermittently on linux/ppc64 and linux/ppc64le. |
This now happens on linux-amd64-longtest too: |
Fails consistently on my local Linux workstation |
Yeah I can reproduce in linux/amd64 also. I've overhauled the test now and it passes very consistently on linux/amd64 and linux/arm. Waiting on review now for https://golang.org/cl/177237. |
Sample from https://build.golang.org/log/964dcd623fe5a0545b1b96bf2b5368b67b17accc:
cc @aclements @mknyszek
Tentatively marking release-blocker, since we want the builders to be consistently green.
The text was updated successfully, but these errors were encountered: