Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: unify playground.js location #32007

Open
bradfitz opened this issue May 13, 2019 · 3 comments
Open

x/website: unify playground.js location #32007

bradfitz opened this issue May 13, 2019 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Thinking
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

We currently have two copies of the playground's playground.js: one in x/tools (the original) and one in x/website (the new home, but currently unused?).

Unify.

/cc @ysmolsky @andybons @dmitshur @katiehockman @cnoellekb
@gopherbot gopherbot added this to the Unreleased milestone May 13, 2019
@andybons
Copy link
Member

The one in x/website is used by the playground widget on golang.org.

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label May 13, 2019
@dmitshur dmitshur self-assigned this May 13, 2019
@dmitshur
Copy link
Contributor

dmitshur commented May 13, 2019 •
edited

This task is a part of the larger "fully stripping down the godoc binary so that it only displays local code documentation" task in #29206 (comment).

Edit: Created issue #32011 for tracking that more specifically.

@dmitshur
Copy link
Contributor

dmitshur commented Sep 5, 2020 •
edited

We should remove the one in x/website, as it's newer and unused. A better new home would be inside x/playground, but that can be a separate issue.

This caused confusion in CL 252377.

Edit: Not completely unused, I see #32007 (comment) above now.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Thinking and removed NeedsFix The path to resolution is known, but the work has not been done. labels Sep 5, 2020
@ProximaB ProximaB mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Thinking
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @dmitshur @gopherbot